Giter Club home page Giter Club logo

byod's People

Contributors

butchwarns avatar dromer avatar github-actions[bot] avatar jatin-kumar avatar jatinchowdhury18 avatar kaimikkelsen avatar rachelmaryamlocke avatar x31eq avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

byod's Issues

[BUG] VST2 reverts on project reload in REAPER

Describe the bug
The VST2 version reverts to whatever preset is active when reloading a project. So for example if you start with the default (empty) preset, then add some modules and save your project, when reloading the project you'll be back at the empty default preset. Likewise if you pick a preset (user or built-in) and make some tweaks/additions to it, when reloading the project your setup will be reset to the chosen preset. The VST3 version doesn't do this.

Desktop (please complete the following information):

  • OS: Windows 10 21H2 (64-bit)
  • DAW: REAPER
  • Version: 6.51 (64-bit)

[BUG] App is unresponsive at extreme zoom levels

Describe the bug
From TestFlight feedback:

"+" and "-" buttons. At 23% zoom the app become irresponsive. More than 400% zoom may not be necessary.

Expected behavior
Probably best to limit zoom level to maybe [40%, 250%].

Desktop (please complete the following information):

  • OS: iOS 15.1
  • Device: iPad Air (3rd generation)
  • Version: 0.5.1

[BUG] VST3 BYOD's Amp IRs do not open file explorer if click on custom

In VST3 version of BYOD Amp IRs do not show file explorer when choose custom option

To Reproduce
Steps to reproduce the behavior:

  1. Instantiate VST3 BYOD in Ardour
  2. Choose Instant Metal preset
  3. In Amp IRs click under IR and choose custom
  4. Nothing happens

Expected behavior
After clicking on Custom the file explorer should appear

Desktop

  • OS: Linux (Fedora 36)
  • DAW Ardour6.9
  • Version 1.0.2 (Night build)

Log

**********************************************************
This log file is currently being written to...
Log started: 17 Sep 2022 12:05:04pm

Version: BYOD 1.0.2
Commit: c5e9ec7 on main with JUCE version JUCE v7.0.1
Build: 26 Aug 2022 16:39 on SPB-8CC74614BY.kontur with GNU-12.1.1
System:  with Linux (64-bit) on 12 Core, AMD Ryzen 5 3600 6-Core Processor
Plugin Info: VST3 running in Ardour running at sample rate 0.0 kHz with block size 0

Loading preset: Default
Adding connection from Input, port #0 to Output port #0
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Loading preset: Instant Metal
Removing connection from Input, port #0 to Output port #0
Creating processor: Metal Face
Creating processor: Amp IRs
Adding connection from Input, port #0 to Metal Face port #0
Adding connection from Amp IRs, port #0 to Output port #0
Adding connection from Metal Face, port #0 to Amp IRs port #0
Exiting gracefully...

FYI:
Standalone version works just fine. LV2 version can't be loaded, but it's subject for issue #194

Replace cable with 1-to-1 module [FEATURE]

Is your feature request related to a problem? Please describe.
At the moment if you have Module A connected to Module B, and you want to add a new module in between, it's a sort of cumbersome 4-step process:

  1. Disconnect the cable
  2. Add the new processor
  3. Connect the new processor input to the output of Module A
  4. Connect the new processor output to the input of Module B

Describe the solution you'd like
It would be great to be able to right-click on a cable and have the option to replace it with a 1-input/1-output module.

Additional context
At the moment the cables are drawn onto the CableView, but they aren't components themselves, so they aren't able to catch mouse clicks directly. So this could make it a little bit tricky to pick up on the mouse-click behaviour.

[FEATURE] magic_enum as git submodule

Is your feature request related to a problem? Please describe.
Hi,

In some build systems (OBS) fetching the code during build process is prohibited. So the only way is to download the sources from github recursively, archive them, then build it offline.

Describe the solution you'd like
Move fetching magic_enum from cmake to .gitmodules

[BUG] UI freeze when trying to select "custom" amp IR

Describe the bug
From TestFlight feedback:

If I choose Custom in the Amp IR, the u.i.,freezes for me and I need to reboot the host. If I delete the AU instance and create another without rebooting the host, app the ui is still frozen. I tried this in both Loopy Pro and AUM.

Desktop (please complete the following information):

  • OS: iOS 15.3
  • Device: iPad (6th generation)
  • DAW: Loopy Pro, AUM
  • Version 0.5.1

Expected behavior
A file browser should open, to allow the user to select a wav file. If this can't be done safely on iOS, we may have to remove the "custom" IR option for that platform.

[BUG] BYOD 1.0.1-2 Vst3 crashes REAPER

Hi! I'm on Manjaro and BYOD Vst3 crashes REAPER as soon as I try to add it to a FX chain. The Lv2 is working fine (I installed it with Yay from the AUR repository). If you need anything else, just tell me.

Great plugin, by the way. Thanks soo much!!

Greets!

[BUG] Setting Yen Drive gain to 0% terminates plugin output

Describe the bug
Setting Yen Drive gain to 0% terminates plugin output.

To Reproduce
Steps to reproduce the behavior:

  1. Instantiate a Yen Drive unit in the signal path.
  2. Turn gain % all the way down.
  3. Plugin output stops.
  4. Can't get any sound out of the plugin without deleting it and starting again from scratch.

Expected behavior
Presumably gain should go to zero at 0% but when one turns it back up, or deletes the Yen Drive and replaces it with something else, or does anything else that would produce sound typically, the sound should come back.

Screenshots
BYOD-yen-drive-0-crash.zip

  1. Initial state, signal level is visible at both input and output.
  2. Instantiate Yen Drive in signal path, set gain to 0%. Output abruptly stops.
  3. Delete Yen Drive unit and reconnect input to output. Output level stays at 0.
  4. Add an oscilloscope showing input signal. Output level will stay at 0 until the plugin is deleted and reinstantiated.

Desktop (please complete the following information):

  • OS: MacOS 12.2.1
  • DAW Logic
  • Version 10.7.2

[FEATURE] Gate and Compressor modules

Is your feature request related to a problem? Please describe.
Currently there are no dedicated dynamics processors (aside from "Clean Gain").

Describe the solution you'd like
Add a "Gate" and "Compressor" module.

Additional context
Part of feature request #58 from @IsaakCode.

[BUG] BYOD: Saving presets crashes the DAW

Describe the bug
When I try to save a preset, I have to select a folder. After doing that, the plugin crashes the DAW.
The only way to restore the usage of the plugin is to delete the .config/ChowdhuryDSP/BYOD/UserPresets.txt file.

To Reproduce
Load the plugin through any DAW (Reaper, Bitwig, Carla...) and try to save the preset.

Expected behavior
I expect the plugin to save the preset and still usable.

Desktop

OS: Linux Mint 20.3
DAW Reaper, Bitwig, Ardour, Carla
Version:Nightly Build from 27/06/2022

Additional context
Log file:


This log file is currently being written to...
Log started: 29 Jun 2022 2:27:02pm

Version: BYOD 1.0.1
Commit: b12ef1d on HEAD with JUCE version JUCE v6.1.5
Build: 27 Jun 2022 2:43 on fv-az194-698.vahfjs35atkulmpwh5ujf4txfe.jx.internal.cloudapp.net with GNU-9.4.0
System: with Linux (64-bit) on 8 Core, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz
Plugin Info: LV2 running in Unknown running at sample rate 0.0 kHz with block size 0

Adding connection from Input, port #0 to Output port #0
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Saving user preset, name: "MyPreset", category: ""
Loading preset: Default
Removing connection from Input, port #0 to Output port #0
Adding connection from Input, port #0 to Output port #0
Saving user preset, name: "SonicYouth", category: "Player"
Interrupt signal received!
Stack Trace:
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x1d2443) [0x7fc50877a443]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x17e392) [0x7fc508726392]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x1cacad) [0x7fc508772cad]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x14420) [0x7fc551ed8420]
/lib/x86_64-linux-gnu/libc.so.6(+0x188717) [0x7fc551a0b717]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x1cea58) [0x7fc508776a58]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x1d04f0) [0x7fc5087784f0]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x1d0b04) [0x7fc508778b04]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x3d0da0) [0x7fc508978da0]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x17681e) [0x7fc50871e81e]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0xf0bf2) [0x7fc508698bf2]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x3e404a) [0x7fc50898c04a]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x17ede3) [0x7fc508726de3]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x2f2c3e) [0x7fc50889ac3e]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x27c23b) [0x7fc50882423b]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x27c520) [0x7fc508824520]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x1d5233) [0x7fc50877d233]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x1d4c2a) [0x7fc50877cc2a]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x1dd50b) [0x7fc50878550b]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0xd602c) [0x7fc50867e02c]
/usr/lib/lv2/BYOD.lv2/BYOD.so(+0x1b3f73) [0x7fc50875bf73]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x8609) [0x7fc551ecc609]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7fc5519a2133]

Plugin crashing!!!

[FEATURE] Anything to anything routing

@jatinchowdhury18 You already mentioned wanting to implement parallel processing here.

Great! :)

If I may dream out loud: I'd love anything to anything routing, like in Ardour.
Even better would be to include @x42's full latency compensation.
I don't expect this to happen anytime soon, or at all, but wanted to mention it anyway.

Thanks!

[BUG] New Processor button is hidden by notch on some iOS devices

Describe the bug
From AudioBus forum:

it took me a really long time to locate the + button, for adding modules. I thought I was going crazy. Or maybe you were just offering presets. Turns out, the upper notch on my iPhone 13 is blocking the + button, when the phone is in landscape mode and the notch is on the right. When I flipped the phone around I found the +, so I recommend you relocate that button to another part of the screen. Looks like you have many places you could place it.

Expected behavior
One option is to move the button to a different location. Alternatively, we could remove the button and use a right-click/long-press action to make the new processor menu appear anywhere.

[FEATURE] Routing modulation signals

Is your feature request related to a problem? Please describe.
Currently some processors (tremolo, chorus) use modulation signals. Currently there is no way to sync modulation signals or to use custom modulation signals.

Describe the solution you'd like
Processors that use modulation signals could have an extra input and output port (probably marked with a different colour). If the input port is connected, then the signal coming in on that port will be used as the modulation signal. The ouput port will pass on the modulation signal so it can be re-used by other processors.

[BUG] BYOD cannot load on Linux

Describe the bug
When I try to load BYOD as a plugin, it does not load

To Reproduce
Load the plugin through any DAW (Reaper, Bitwig, Carla...)

Expected behavior
I expect the plugin to appear

Desktop

  • OS: Linux Mint 20.3
  • DAW Reaper, Bitwig, Ardour, Carla

Here is the log file:


This log file is currently being written to...
Log started: 27 Jun 2022 9:04:52pm

Version: BYOD 1.0.1
Commit: 2d58afc on HEAD with JUCE version JUCE v6.1.5
Build: 15 Mar 2022 22:43 on fv-az217-784.5fhmivlnczbevhjmk01nzrxweh.bx.internal.cloudapp.net with GNU-9.4.0
System: with Linux (64-bit) on 8 Core, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz
Plugin Info: LV2 running in Ardour running at 0.0 kHz with block size: 0

Loading preset: Default
Adding connection from Input, port #0 to Output port #0

Maybe is it a problem with openGL? which version am I supposed to use? how can I disable openGL in the settings file?

[FEATURE] Separate online / offline quality modes

Please add preset-agnostic online- and offline quality (oversampling) settings in the final version (as in Chow Tape Model). It's one of the best features to have when running a slower machine: having no oversampling on during tracking and premixing, but knowing that when the tracks are rendered / exported they will receive the highest qualiy treatment automatically. Best of both worlds. Thanks Jatin!

[FEATURE] remove JUCE webkit

So juce has a webkit component that requires curl and webkitgtk. It would be great if this was removed from building the plugin.

[BUG] LV2 version of BYOD can't be instantiated by Ardour6.9

Describe the bug
LV2 version of BYOD can't be instantiated by Ardour6.9 but VST3 could (with bug #193)

To Reproduce
Steps to reproduce the behavior:

  1. In Ardour6.9 apply BYOD LV2 on audio track
  2. Get an error The plugin "BYOD" could not be loaded. See the Log window for more details (maybe)

Expected behavior
BYOD plugin applies on track and interface of BYOD appears

Screenshots
Ardour6.9 error
image

Desktop (please complete the following information):

  • OS: Linux (Fedora 36)
  • DAW Ardour6.9
  • Version 1.02 (Night Build)

Additional context
In Ardour6.9 logs the following message appears:

2022-09-17T11:55:20 [ERROR]: LV2: Failed to instantiate plugin https://github.com/Chowdhury-DSP/BYOD

Standalone and VST3 versions successfully start. LV2 version doesn't create any log files. VST3 version create log file with the following content:

**********************************************************
This log file is currently being written to...
Log started: 17 Sep 2022 12:05:04pm

Version: BYOD 1.0.2
Commit: c5e9ec7 on main with JUCE version JUCE v7.0.1
Build: 26 Aug 2022 16:39 on SPB-8CC74614BY.kontur with GNU-12.1.1
System:  with Linux (64-bit) on 12 Core, AMD Ryzen 5 3600 6-Core Processor
Plugin Info: VST3 running in Ardour running at sample rate 0.0 kHz with block size 0

Loading preset: Default
Adding connection from Input, port #0 to Output port #0
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Checking OpenGL availability...
OpenGL is available on this system: FALSE
Loading preset: Instant Metal
Removing connection from Input, port #0 to Output port #0
Creating processor: Metal Face
Creating processor: Amp IRs
Adding connection from Input, port #0 to Metal Face port #0
Adding connection from Amp IRs, port #0 to Output port #0
Adding connection from Metal Face, port #0 to Amp IRs port #0
Exiting gracefully...

Build Issue with Fedora

Have to compile from source since on Fedora. Followed your instructions as well as I could. Had to find distro-specific names for the dependencies, but as far as I'm aware I've managed to get them all. I make it to the cmake --build build --parallel 4 command but keep getting an error. As follows:

gmake[2]: *** [modules/CMakeFiles/juce_plugin_modules.dir/build.make:370: modules/CMakeFiles/juce_plugin_modules.dir/chowdsp_utils/modules/plugin/chowdsp_plugin_utils/chowdsp_plugin_utils.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[2]: *** [modules/CMakeFiles/juce_plugin_modules.dir/build.make:342: modules/CMakeFiles/juce_plugin_modules.dir/chowdsp_utils/modules/gui/chowdsp_gui/chowdsp_gui.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:603: modules/CMakeFiles/juce_plugin_modules.dir/all] Error 2
gmake: *** [Makefile:136: all] Error 2

System info:
OS: Fedora Linux 36 (KDE Plasma) x86_64
Kernel: 5.19.10-200.fc36.x86_64
Shell: bash 5.1.16
DE: Plasma 5.25.5
CPU: Intel i7-4770K (8) @ 3.900GHz
GPU: NVIDIA GeForce GTX 770

Let me know if you need any more info.

Also let me know if this is all on my end and pointless, don't want to be that guy who wastes your time because I don't know enough.

[BUG] Unable to cancel preset saving.

Hi Jatin!

Describe the bug
If you press the "save preset" then "MyPreset" will still active until you press enter and there is no way to cancel that and/or choose another preset .

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'main window'
  2. Click on 'Save Preset'
  3. Press Esc or click out of preset's name text box or "next preset" button.
  4. "MyPreset" is still waiting for input.

Expected behavior
Saving should be canceled.

Desktop (please complete the following information):

  • OS: Linux
  • DAW: Standalone, BespokeSynth with VST3 version
  • Version HEAD

[BUG] VST2 crashes Reaper and VST3 without OpenGL freezes Reaper GUI temporarily

Describe the bug
When using the VST2 version, it crashes Reaper immediately. The VST3 is loadable. Though this version hangs / freezes the Reaper GUI completely, as long as the plugin GUI is open. If it gets closed, Reaper is responsive again (only GUI gets frozen; sound continues to play).

To Reproduce
Steps to reproduce the behavior:
VST2 issue:

  1. Try to load VST2 into Reaper.

VST3 issue:

  1. Load VST3 into any track
  2. Play back Reaper while BYOD GUI is open
  3. Reaper GUI is not responsive anymore, as long as the BYOD GUI has focus

Expected behavior
I expected the VST2 not to crash or give at least any kind of error message.

I expect the VST3 to not freeze the Reaper GUI.

Screenshots
Reaper GUI freeze

Desktop:

  • OS: Windows 10
  • DAW Reaper v6.46
  • BYOD v0.2.0
  • 64 bit

"Copy Diagnostic Info":

Version: BYOD 0.2.0
Commit: a125f33 on HEAD with JUCE version JUCE v6.1.4
Build: 1 Feb 2022 0:33 on fv-az211-197 with MSVC-19.29.30139.0
System: Windows (Desktop) with Windows 10 (64-bit) on 16 Core, Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
Plugin Info: VST3 running in Reaper running at 44.1 kHz with block size: 256

Hope this helps! (=

Version 1.0.1 Release Checklist

  • Close out outstanding issues
  • Bump version number
  • Generate AAX builds
  • Test on Windows:
    • Ableton
    • Reaper
    • Pro Tools
  • Test on Mac:
    • Ableton
    • GarageBand
    • Logic (M1)
    • Pro Tools
  • Test on iOS:
    • AUM
    • GarageBand
  • Submit iOS build for review
  • Generate release builds/installers
  • Release iOS version
  • Update documentation:
    • Update README, CHANGELOG, etc
  • Tag GitHub Release
  • Update website
    • Update build links

[BUG] - saving user presets doesn't save input / output gain, channel config, etc.

Describe the bug
When saving user presets, the parameters along the bottom of the plugin window (channel config, input / output gain) are not saved with the preset.

To Reproduce
Steps to reproduce the behavior:

  1. Create a patch with non-zero input / output gain (e.g. stereo, output gain -6db)
  2. Save as a user preset
  3. Create a new instance of BYOD
  4. Recall the user preset from step 2 - none of the parameters of input / output gain, channel configuration are recalled.

Expected behavior
You expect that user presets will contain these parameters and they'll be recalled correctly. Not recalling input / output gain can cause unexpected loud bursts of audio when scrolling presets.

Desktop (please complete the following information):

  • OS: macOS 12.3
  • DAW: Ableton Live
  • Version: 11.1

Randomise feature [FEATURE]

It would be cool to be able to put together a signal chain comprised of random modules. However there's a few challenges:

  • Volume: the random chain should not be silent or (worse) insanely loud
  • Routing: randomly creating a serial chain probably wouldn't be too hard, but doing anything with more complicated routing could be tricky.

For the volume problem, maybe we could create the chain, then put pink noise through it, and randomly tweak the knobs until the volume is within an acceptable range.

[BUG] [IOS] Crash when quickly flipping through presets

Describe the bug
From AudioBus:

Question: I've noticed that when I was using it in AUM and I clicked through the presets quickly it would crash the app. Anyone else getting this? (Air 2, iOS 14.8 and also on my iPad mini 3 iOS 12.5.5).

[BUG] OpenGL Issues

Describe the bug
Some DAWs have trouble with UI rendering when OpenGL is not enabled (Reaper, FL Studio, Cakewalk). However, OpenGL is not turned on by default, since machines with that don't support newer version of OpenGL will show a black screen whenever trying to render with OpenGL.

Expected behavior
The plugin should check the available OpenGL version, and pick the default behavior accordingly. If the machine does not support OpenGL, no option should be made available.

There should also be a note about using OpenGL in the user manual.

Additional Information
From this JUCE forum post:
auto ver = String::fromUTF8 ((const char*) glGetString (GL_VERSION));

[FEATURE] Gate module or built in gate within input module

Is your feature request related to a problem? Please describe.
Please add input metering and a gate function (either built into the input module or as a separate module). This will help gain staging and starting with a clean slate, before going into the fantastic drive and tone shaping modules.

[BUG] Undo/Redo does not re-load preset name

Describe the bug
When you undo a "load preset" operation, the preset browser shows the name of the preset that was just "unloaded"

To Reproduce
Steps to reproduce the behavior:

  1. Load a preset, and maybe tweak a few parameters.
  2. Load another preset.
  3. Press "undo".
  4. The previous state will re-load correctly but the preset menu will show the name of the second preset, rather than the first.

Expected behavior
When you undo a "load preset" operation, the preset browser should show the name of the previously loaded preset.

Desktop (please complete the following information):
Appears to happen on all platforms.

[BUG] Difficulty with cable connections UI on iOS

Describe the bug
From AudioBus forum:

Also on my iPhone 6s plus, although it is super awesome to be able to zoom in and out of modules or the entire effects chain, the connecting section to create the virtual cable is a bit finicky as far as detecting is concerned. It would be nice for it to be a bit bigger perhaps? Or at least provide some kind of visual feedback that a connection is being stablished?

Expected behavior
Some ideas:

  • larger area for clicking to create new cables.
  • "glow" when mouse is down or hovering to create a new cable.

[FEATURE] Metering on Input/Output modules

Is your feature request related to a problem? Please describe.
Currently there is no way to visually see the level going into the signal chain, which can be a problem, since you can't know what levels are going into the first module in the signal chain.

Describe the solution you'd like
Leve meters on the UI for the input and output processors.

Additional context
Part of feature request #58 from @IsaakCode.

[BUG] GUI laggy in current version (0.2.0)

Describe the bug
Dragging notes and modules is very laggy in the early version on my computer setup, despite the simplicity of the visual elements. I'm sure the issue will be adressed in future versions, so this is just meant as a heads up notice. I experience the issue on an older Windows machine without graphical hardware acceleration (see below).

To Reproduce
Steps to reproduce the behavior:

  1. Add a module
  2. drag a note

Expected behavior
Moving and dragging elements without considerable lag.

Desktop (please complete the following information):

  • OS: Windows 7
  • DAW Ableton Live 11
  • Version 0.2.0
  • 64 bit VST3
  • Third generation Intel i5 desktop processor
  • 8 gb of RAM
  • Intel HD Graphics 2000 (integrated)
  • 1920 x 1080 resolution

Reaper DAW- Will not render properly in any setting over 2x oversampling[BUG]

Describe the bug
Using Reaper v6.51 DAW:
Rendering in OS Factor 1X = fine
Rendering in OS Factor 2X = fine
Rendering in anything 4x or more results in stuttering audio. You hear the dry guitar signal with intermittent spikes where you can hear the wet effected signal for a millisecond.

To Reproduce
Steps to reproduce the behavior:

  1. Select online 1x/4x offline (or higher) (also tried 2x/4x) Had Reaper's asio set to 44.1 khz, 1024 samples buffer.
  2. Click on File/render, offline render (tried all 3 options full speed offline (normal mode), 1 x offline, & 1 x offline render (idle))
  3. Any os factor higher than 2x stutters between dry signal and wet signal rendered file.
    Too bad, I can imagine the sound quality is better at those higher settings!

Expected behavior
Expected to run ok online at 1x, or 2x. OS Factor.
Expected the rendered audio file to render properly at any OS factor using offline render.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 11
  • DAW: Reaper v6.51
  • Version [e.g. 2.3]
  • 64 bit VST3 BYOD
  • Version: BYOD 1.0.0

Commit: 019606a on HEAD with JUCE version JUCE v6.1.5
Build: 9 Mar 2022 10:33 on fv-az211-942 with MSVC-19.29.30140.0
System: Windows (Desktop) with Windows 10 (64-bit) on 16 Core, Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
Plugin Info: VST3 running in Reaper running at 44.1 kHz with block size: 1024

If you are unsure about any of this information, please use the "Copy Diagnostic Info" tool in the plugin settings menu.

Additional context
Here's the preset if that helps:
https://drive.google.com/file/d/1Td6MRHqLYLBYZQxuCWjVu8ziATQEcuQX/view?usp=sharing

"Snap to grid" (or similar) [FEATURE]

Is your feature request related to a problem? Please describe.
It's pretty easy for the board to become a bit cluttered with processors and cables, especially for larger patches.

Describe the solution you'd like
One idea is to have a "snap to grid" kind of thing, where each module is snapped to an ideal location , equally spaced with other processors.

Another idea is to have a sort of "baseline" where all processor start, and then the user can move specific modules away from the baseline.

One more possibility is to have "mini" icons for each module, so they don't take up as much space, and then you can click the icon to bring up the editor.

[BUG] Potential Build Issue

Describe the bug
I see a build issue with current master of BYOB and KlonCentaur source repo.

To Reproduce
Steps to reproduce the behavior:

  1. cmake -Bbuild
  2. cmake --build build/ --config Release

Expected behavior
I see the same issue with building BYOB repo. I can build the RTNeuralExample successfully and run in with Juce generated AudioPluginHost.

Screenshots Here is the
[ 26%] Building CXX object ChowCentaur/CMakeFiles/ChowCentaur.dir/GainStageML/GainStageMLProc.cpp.o
[ 26%] Building CXX object ChowCentaur/CMakeFiles/ChowCentaur.dir/GainStageML/RNNModel.cpp.o
[ 27%] Building CXX object ChowCentaur/CMakeFiles/ChowCentaur.dir//modules/JUCE/modules/juce_audio_plugin_client/juce_audio_plugin_client_utils.cpp.o
[ 28%] Building CXX object **ChowCentaur/CMakeFiles/ChowCentaur.dir/
/modules/JUCE/modules/juce_audio_utils/juce_audio_utils.mm.o
error: Objective-C was disabled in PCH file but is currently enabled
1 error generated.**
make[2]: *** [ChowCentaur/CMakeFiles/ChowCentaur.dir/__/modules/JUCE/modules/juce_audio_utils/juce_audio_utils.mm.o] Error 1
make[1]: *** [ChowCentaur/CMakeFiles/ChowCentaur.dir/all] Error 2
make: *** [all] Error 2

Desktop (please complete the following information):

  • OS: [MacOS 10.15.7 Catalina]
  • DAW [Juce AudioPluginHost AU/VST3 testing]
  • Xcode 12.4 (12D4e)
  • CMake 3.23.0-rc3

KlonCentaurBuildError
Image 3-14-22 at 6 43 PM

[BUG] Editor popup menu is covered by finger on touch screens

Describe the bug
From AudioBus:

I have a similar problem with the long-press menu, it’s covered by the finger/hand and thus hard to read and operate.
I’d personally prefer it if there was a fixed, global place where the current selected module stuff would appear. Info, replace, reset…

Expected behavior
Maybe have a drop-down menu triggered from the bottom corner of the editor instead?

[BUG] fl studio ui freezes whenever the plugin window is open

Describe the bug
When the plugin window is open (i.e. the plugin ui displays on screen), fl studio's ui freezes.
Despite the ui not updating, it is still possible to interact with it (i.e. mouse events are intercepted properly).
The ui of the plugin itself doesn't freeze, only fl studio's ui.

To Reproduce
Steps to reproduce the behavior:

  1. make sure the channel rack is not in detached mode
  2. load the plugin into mixer track 1
  3. open the plugin ui by clicking on the associated entry in the mixer track effects
  4. click on the "View Channel Rack" button, or press f6
  5. notice how the channel rack doesn't seem to appear on screen
  6. close the BYOD instance's ui
  7. notice how fl's ui updates and the channel rack is now displayed as expected

Expected behavior
I would expect fl's ui to not freeze when the plugin window is open. It should stay responsive

Screenshots
In this image, my cursor hovers over the channel rack icon (in red) when the plugin ui is open. You can see that the icon does not light up as it should.
image

In this image, my cursor hovers over the channel rack icon (in red) when the plugin ui is closed. You can see that the icon does light up.
image

Desktop (please complete the following information):

  • OS: Windows 10
  • DAW FL Studio 20.9.1 [build 2826]
  • Version 1.0.0
  • 64 bit

I have no idea what can be causing this since I haven't really developed anything ui related... If you need any other info let me know.

[FEATURE] Replace block button

Describe the solution you'd like
Hi!
It would be useful to have just a little button (near the "close" or "info") which acts as "replace this block with ..."
At present we have to remove the block then a add new one with + menu and then drag it in the right place.

[BUG] [Linux] Version 1.0.1 crashes Renoise/Bitwig

Describe the bug
Loading BYOD 1.0.1 on a track crashes Renoise. Regression from 1.0.0 which didn't cause Renoise to crash.

To Reproduce
Steps to reproduce the behavior:

  1. Open up Renoise
  2. Load the plugin on a track

Desktop (please complete the following information):

  • OS: Arch Linux
  • DAW: Renoise
  • Version: 3.3.2
  • 64bit

[BUG] Crash when editing preset

Describe the bug
From iOS TestFlight:

Edited a preset. Tried to save but the previous detail, category, present name were blank, I put in all the same information and the app locked, the shut down.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: iOS 15.3.1
  • Device: iPad (9th generation)
  • Version 0.5.1

Additional context
From the crash logs, it looks like the crash is happening on the message thread:

Thread 0 name:
Thread 0 name:
Thread 0 Crashed:
0   libsystem_kernel.dylib        	0x00000001b6db6504 mach_msg_trap + 8
1   libsystem_kernel.dylib        	0x00000001b6db6b9c mach_msg + 76 (mach_msg.c:119)
2   CoreFoundation                	0x00000001803d0738 __CFRunLoopServiceMachPort + 372 (CFRunLoop.c:2646)
3   CoreFoundation                	0x00000001803d4a2c __CFRunLoopRun + 1212 (CFRunLoop.c:3000)
4   CoreFoundation                	0x00000001803e8468 CFRunLoopRunSpecific + 600 (CFRunLoop.c:3268)
5   Foundation                    	0x0000000181c06c84 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 236 (NSRunLoop.m:373)
6   Foundation                    	0x0000000181c47db8 -[NSRunLoop(NSRunLoop) runUntilDate:] + 92 (NSRunLoop.m:420)
7   BYOD                          	0x0000000105035140 0x104d68000 + 2937152
8   BYOD                          	0x000000010505fff0 0x104d68000 + 3112944
9   BYOD                          	0x0000000104dae864 0x104d68000 + 288868
10  BYOD                          	0x0000000104dae2e0 0x104d68000 + 287456
11  BYOD                          	0x0000000104db247c 0x104d68000 + 304252
12  BYOD                          	0x0000000104fc8f3c 0x104d68000 + 2494268
13  BYOD                          	0x0000000104fc8a88 0x104d68000 + 2493064
14  BYOD                          	0x0000000104fc8208 0x104d68000 + 2490888
15  BYOD                          	0x0000000104fbd0f8 0x104d68000 + 2445560
16  BYOD                          	0x0000000104fbcd40 0x104d68000 + 2444608
17  BYOD                          	0x0000000104fbf1f0 0x104d68000 + 2454000
18  UIKitCore                     	0x00000001829e458c -[UIWindow _sendTouchesForEvent:] + 980 (UIWindow.m:2974)
19  UIKitCore                     	0x0000000182a15f48 -[UIWindow sendEvent:] + 4456 (UIWindow.m:3274)
20  UIKitCore                     	0x0000000182bc5e34 -[UIApplication sendEvent:] + 828 (UIApplication.m:11877)
21  UIKitCore                     	0x00000001829e9140 __dispatchPreprocessedEventFromEventQueue + 7904 (UIEventDispatcher.m:2290)
22  UIKitCore                     	0x00000001829ddf2c __processEventQueue + 6760 (UIEventDispatcher.m:2597)
23  UIKitCore                     	0x0000000183824d54 updateCycleEntry + 176 (UIEventDispatcher.m:102)
24  UIKitCore                     	0x000000018304fb44 _UIUpdateSequenceRun + 84 (_UIUpdateSequence.mm:112)
25  UIKitCore                     	0x00000001836cc84c schedulerStepScheduledMainSection + 144 (_UIUpdateCycleScheduler.m:1174)
26  UIKitCore                     	0x00000001836cbe3c runloopSourceCallback + 60 (_UIUpdateCycleScheduler.m:1262)
27  CoreFoundation                	0x00000001804840d0 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28 (CFRunLoop.c:1972)
28  CoreFoundation                	0x0000000180494d90 __CFRunLoopDoSource0 + 208 (CFRunLoop.c:2016)
29  CoreFoundation                	0x00000001803cf098 __CFRunLoopDoSources0 + 268 (CFRunLoop.c:2053)
30  CoreFoundation                	0x00000001803d48a4 __CFRunLoopRun + 820 (CFRunLoop.c:2951)
31  CoreFoundation                	0x00000001803e8468 CFRunLoopRunSpecific + 600 (CFRunLoop.c:3268)
32  GraphicsServices              	0x000000019bf8c38c GSEventRunModal + 164 (GSEvent.c:2200)
33  UIKitCore                     	0x0000000182d8b5d0 -[UIApplication _run] + 1100 (UIApplication.m:3493)
34  UIKitCore                     	0x0000000182b09f74 UIApplicationMain + 364 (UIApplication.m:5047)
35  BYOD                          	0x0000000104f35b5c 0x104d68000 + 1891164
36  dyld                          	0x0000000105541aa4 start + 520 (dyldMain.cpp:879)

Saving presets per module, and per module group [FEATURE]

Is your feature request related to a problem? Please describe.
Right now it's possible to save a preset, but what if you just want to save a group of 3 or 4 modules that you use regularly in combination with other things.

Describe the solution you'd like
There should be a way to select a group of modules and save them in their current state.

Version 1.0 Release Checklist

  • Close out outstanding issues
  • Bump version number
  • Generate AAX builds
  • Test on Windows:
    • Ableton
    • FL Studio
    • Reaper
    • Pro Tools
  • Test on Mac:
    • Ableton
    • GarageBand
    • Logic (M1)
    • Pro Tools
  • Test on iOS:
    • AUM
    • GarageBand
  • Submit iOS build for review
  • Generate release builds/installers
  • Release iOS version
  • Update documentation:
    • User Manual
    • Update README, CHANGELOG, etc
  • Tag GitHub Release
  • Update website
    • Update compatibility requirements
    • Update build links
    • Update manual link
  • Postings:
    • KVR
    • AudioBus
    • Webpage (news)
    • Patreon
    • Beat Community

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.