chockenberry / markdownattributedstring Goto Github PK

See attached unit tests.

NSAttributedString+Markdown_Tests.m.txt

See attached unit tests.

NSAttributedString+Markdown_Tests.m.txt

Setting NSUnderlineStyleAttributeName in MarkdownStyleEmphasisSingle only seems to work if MarkdownStyleEmphasisDouble is defined as well that contains a significant attributed style difference.

Use case underlining "bar" in "Foo bar".

Using SampleApp's ViewController, and enabling USE_STYLE_ATTRIBUTES, I would expect the following style attributes to work:

@{
        MarkdownStyleEmphasisSingle: @{
            NSUnderlineStyleAttributeName: @1
        }
}

However, this is insufficient to underline "bar" in the example. In order for the single emphasis style to take effect, one needs to add a MarkdownStyleEmphasisDouble definition, which has a significant difference from the base attributes (font, foregroundColor, underline style all seem to do the trick).

Example:

[It's a link, but it won't be (converted) to NSAttributedString.Key.link](https://google.com)

In the function updateAttributedString():

endRange = [scanString rangeOfString:endMarker options:options range:remainingRange];

It doesn't check for an escaped endMarker:

if (hasCharacterRelative(scanString, endRange, -1, escapeCharacter)) { continueScan = YES; //scanEndIndex = endRange.location + endRange.length; scanEndIndex = endRange.location + 1; }

Therefore, it will fail to properly parse:
[\(\)](http://apple.com)

As this snippet shows if there is a styleAttributes for links the url attribute is ignored.

I need to customise the link color and keep them tappable.
I'll send a PR soon.

The function:
static BOOL hasCharacterRelative(NSString *string, NSRange range, NSUInteger offset, unichar character)
takes a NSUInteger offset. Many clients of this call pass -1.