chidg / pyb2 Goto Github PK

Hi. I came across your project since I may try to use B2 in a personal project but I do not have experience with these types of APIs.

Anyway, I like the simplicity of your code (compared to say, backblaze-b2) but I noticed two related issues. You read the entire file to get the SHA1 hash and then you use that to sent the request.

Again, I am rather inexperienced here, but my quick reading suggests using an updated checksum on the SHA1 (see this for example). Similarly, based on this StackExchange answer you can stream the upload.

It certainly seems like an easy change but I really don't know.

Thanks!