chernodub / eslint-config Goto Github PK

https://github.com/saritasa-nest/zincasa-zapp/blob/739aea69d006d00c1cb8e0bfa47b97dfdd3a70b3/projects/common/shared/components/datepicker/datepicker.component.ts#L31

https://github.com/xjamundx/eslint-plugin-promise

Issue:

When we set way, as on repo readme file
("lint": "eslint src/**/*.ts --fix")
, linter does not work with child directories. It's happen cause of eslint CLI rules.
For check it, visit eslint CLI docs: https://eslint.org/docs/user-guide/command-line-interface

To reproduce:

Generate angular project
Install eslint via npm or yarn
install current eslint (repo) via npm, or command from readme file
(npm i -D @chernodub/eslint-config && echo "{ "extends": "@chernodub/eslint-config" }" > .eslintrc.json
)

Expected result:

Lint working with all .ts file in src directory and child directories

Actual result:

Lint working only with .ts files in describe directory,
Lint doesn't working with .ts files from child directories;

Environment:

Ubuntu 20/04 LTS, IDE WebStorm (JetBrains), angular v.12.2.0, npm v 7.20.3, node v. 16.6.1

Proposed solution:

Add quotes to set way, like that:
"lint": "eslint 'src/**' --fix"

Additional issue:
After added quotes, lint working with all childs directories, and check all formats.
Unfortunatelly, if we using quotes for setting global scope, formats names will be ignored.
(Info from eslint documentation)

The rule causes rxjs constructions to look ugly