cheaterpaul / enchantmentmachine Goto Github PK

i think it was after the enchantment block is placed

I was testing this mod in my modpack and i noticed that with some enchantments of other mods there are no problems (like for example Potato Recovery by create: https://www.curseforge.com/minecraft/mc-mods/create), but other enchantments of other mods are not compatible (such as Curse of Blindness by Cursery: https://www.curseforge.com/minecraft/mc-mods/cursery).

If any disenchanted books remain in the Disechanter and then i insert a book with an incompatible enchantment, the books will disappear and will be replaced with the input of the disenchanter. Here's the video: https://drive.google.com/file/d/1gi9KsJWi4kfLWdr3TACrPf4H9fVDhHAx/view?usp=sharing.

Versions:
Enchantment Machine: EnchantmentMachine-1.19.1-1.0.2,
Cursery: cursery-1.19.2-3.1,
Forge: Forge - 43.2.10

Minecraft 1.18.1
EnchantmentMachine-1.18.1-1.0.11
Forge 39.0.55

Crash report
crash-2022-01-23_02.24.07-server.txt

I got some help from a modder who told me that one of the tile entities had some trouble saving its contents, and that you should "use the saveAdditional function and not the save one" for 1.18.

Is this already released somewhere or are there still some things to implement?

so im playing with modded enchants and vanilla the disenchanter disenchants modded enchants and the enchanter gives them in my sword but it only works 1 time then i need to rejoin my single player world replace the enchanter to get another enchantment samt with vanille stuff help i activated aaal(cheat Mode) stuff in the config but i cant seem to find out how to edit /max enchantment levels) i hope this can fix my problem i used non enchanted weapons to

Edit: only the first button works the top one all below dont

Minecraft: 1.16.5
Forge: 36.1.0
Mods: jei-1.16.5-7.7.0.107, EnchantmentMachine-1.16.4-1.0.3, Quark-r2.4-314, AutoRegLib-1.6-49
description:
Ancient tomes from the quark mod duplicates enchantments
https://quarkmod.net/#features --> Tools

Photo:

There is a problem when you have many enchantments stored in which when you hit the arrow on an enchantment it does not select the enchantment you have but instead takes one of the first enchantments

TinyModularThings/UniqueEnchantments#60

Moving this to you since you didn't look at minecrafts documentation.
(Last comment explains it)

Hi, could you please publish last fix?

I did enchant (vanilla) and disenchant (your mod) my golden pick about 20 times until a "silk touch" was found. This was then disenchanted likewise.

Now there's the big moment when the enchantment would make its way to my shiny new diamond pick.
It is popped into the enchanter, silk touch and many other pick-enchants are shown.

Clicking on silk touch or on any other just gives a click sound. The pick gets not enchanted. The green arrow says "enchant using 4 levels". Click. Nothing happens. Nothing is consumed, nothing is destroyed.

Trying to enchant other things like a diamond helmet (using up 4 levels also) just worked nicely as expected.

Did I miss something?

Hi,

Just wanted to report what appears like a bug I noticed when testing this mod. When using the disenchanter, and an item is in the output slot, if you break the disenchanter before removing the item, the disenchanter drops, but the item does not, and is not in the output slot when re-placed.

Minecraft: 1.18
Forge: 38.0.14
Mod: EnchantmentMachine-1.18-1.0.7-alpha+20211204-1727.jar

Description:
When attempting to break the Enchanter, Disenchanter, or the Enchantment Block with any tool (including things like hoes, axes, pickaxes, etc.) the blocks will take a very long time to break and once broken will never drop the actual block as stated in the title of this report. Mods that display block and entity info such as The One Probe, say that the blocks do not require ANY tool in order to break (I'm assuming that's why it never drops the actual block).

Minecraft Version: 1.17.1
Forge Version: 37.0.75
Mod Version: EnchantmentMachine-1.17.1-1.0.5.jar
Verified with: The One Probe

Note: Using CTRL+Middle-Click to select the blocks in creative mode shows that they have their NBT data saved, but their tooltips still say 0 enchantments stored. Removing any enchantment from either block results in the enchantment staying there. Example: If I remove the single Efficiency 4 enchantment I have and apply it to any tool it will still be visible in the Enchantment Block but not in the Enchanter, this I can only assume is another bug to fix.

Hi, thanks for fixing the last bug but now the enchantment block is storing the data but the enchanter isnt showing them and the disenchanter is not working either when reloading world. I have to break both the disenchanter and the enchanter for them to work again. Once the enchanter is broke and placed again it shows all enchantments that are stored in the enchantment block.

the enchanter costs levels to enchant, however when you remove the levels from the player, you are doing exactly that. the problem is each level increases the XP required to reach the next level. this is a problem because if hypothetically someone at level 10 spends 4 levels to add an enchantment, then it would cost them 40 experience. however, if someone at level 68 did the same enchant that costs 4 levels, they would lose 1726 experience. from what I understand Minecraft stores a player's xp in a 32-bit integer and the cost of an enchant can be calculated with the equation: (2*L)+7 Where "L" is the level cost of the enchantment

MC 1.20.1

When placing enchanted books in disenchanter the enchantment is stripped but the resulting book is labeled "Enchanted Book" and still has enchantment glint and will not stack with others.

我做了一个简体中文的语言文件，希望可以在后续版本支持

I made a simplified Chinese json, and I hope it can be used in subsequent versions.

{
"block.enchantmentmachine.enchanter_block": "附魔机",
"tile.enchantmentmachine.enchanter.name": "附魔机",
"block.enchantmentmachine.disenchanter_block": "祛魔机",
"tile.enchantmentmachine.disenchanter.name": "祛魔机",
"block.enchantmentmachine.enchantment_block": "附魔方块",
"itemGroup.enchantmentmachine": "附魔机器",
"text.enchantmentmachine.enchant": "附魔",
"text.enchantmentmachine.enchant_for_level": "附魔将要使用 %d 等级",
"text.enchantmentmachine.require_level": "需要 %d 等级",
"text.enchantmentmachine.unavailable": "有冲突的",
"text.enchantment_block.contained_enchantments": "包含的附魔能量: %s",
"text.enchantmentmachine.next_to_storage_block": "必须放置在 %s"
}

Any chance to get fabric support?

Can't join the server with this mod installed on both.
After the second attempt at login into the server I crash.
https://pastebin.com/PgFLwGin

Server latest
latest.log
.

add a note for the item tool tip that the blocks need to touch each other

Weird bug, but you can only apply Enchantments that are note below the "main window".
Anything that is below it aka when you have to scroll is not clickable for me.

Video Showcase:
https://i.imgur.com/j35o4Nv.mp4

The depthTest settings are not configured correctly for the rendering of the scrollablelist button resulting in e.g description is not cut off.

ContainerScreen#102 disables the depthtest

Enthanter says that I need 2 levels to enchant, I have 2 levels ,and still I can't enchant

Each time I reopen my world all enchantments are gone from the enchanter

https://pastebin.com/K3hCag92