Comments (5)
Hi Drizzling, there are no special settings for Per-FedAvg, maybe there is an update on implementation for per-fedavg and I haven't checked the running result. Please check this issue:
#8
from pfedme.
Hi CharlieDinh, thank you for your prompt response. I have reviewed this issue #8 and verified that the previous experimental results are no longer correct after preliminary experiments. Here I would like to sincerely thank you @CharlieDinh, @chuanting, and @sshpark for your contributions.
from pfedme.
HI @Drizzlingg,
I will try to test the new implementation of per-fedavg and update the results soon.
from pfedme.
What about the train_one_step
method of UserPerAvg
? Seems it still uses the two-step-update mentioned in #8 .
pFedMe/FLAlgorithms/users/userperavg.py
Line 73 in caf24b1
In addition, why do we need 2 batches of test data in train_one_step
, which is used for evaluating personalized models in per-FedAvg? The per-FedAvg paper mentions that
The second and third algorithms that we consider are two different efficient approximations of Per-FedAvg.
Similarly, we evaluate the performance of these methods for the case that one step of local stochastic
gradient descent is performed during test time. (Page 8, 2nd paragraph of Sec 5)
I think it should simply be one step of SGD with 1 batch of test data?
from pfedme.
HI @mengcz13
It follows the way per-FedAvg trains the model but on the test data (perFedAvg requires to adapt one step on the test data before evaluate.). One step means one local epoch not one batch. If just uses one batch, it will not follow the training step.
from pfedme.
Related Issues (18)
- Experiment image
- Unable to generate non-iid MNIST Data HOT 4
- why train loss will be nan? HOT 1
- pfedme Optimizer Probelem HOT 6
- Something maybe wrong in data/mnist/generate_niid_20users.py HOT 1
- Some mistakes in generating niid mnist data HOT 11
- Client's train method HOT 2
- A question in PerAvg algorithm HOT 1
- Question about pFedMeOptimizer. HOT 2
- About the Hessian Approximation
- Hello author, why did Loss become Nan after more than a dozen rounds of training?
- UserpFedMe class HOT 4
- A question about train_one_step() method. HOT 3
- Some questions about your peper and your code HOT 2
- Why does FedAvg only train on 1 batch in each local epoch? HOT 2
- Cifar-10 running error HOT 1
- Is Per-FedAvg implemented properly? HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pfedme.