Possible race condition? about gush HOT 4 CLOSED

Are you able to reproduce the issue? A sample code which fails would be helpful. I tested with hundreds of thousands jobs running in parallel (empty jobs to make sure they run and finish at the same time), but the issue never occurred.

Every job has a key in Redis, after the job finishes it gets marked in that key.
When A finishes, it marks itself as finished and checks if there are any child jobs with satisfied dependencies. If there are, then it queues them.
Same thing with B.

So if A finishes slightly sooner, it doesn't trigger child job since B is running.
And if B finishes last, then C's dependencies are satisfied and it gets queued.

from gush.

No, it's a completely theoretical question. I'm still wondering what would happen if they finish at precisely the same time.

from gush.

If they do finish at precisely the same time, then it is possible.

That said, I probably should add some mutex to job enqueuing to make sure they don't get enqueued twice. 👍

Thanks for bringing this up :)

from gush.

Closing as this wasn't actually spotted in actual apps using Gush.

from gush.