Comments (6)
Hi,
I prefer using refinements 😄
# Temporary fix: https://github.com/chaps-io/gush/issues/61
# Overrides Gush::Job start! method.
# Resets failed_at variable when Sidekiq reloads a job.
module GushJobFix
refine Gush::Job do
def start!
super
@failed_at = nil
end
end
end
class MyJob < Gush::Job
using GushJobFix
def perform
...
end
end
from gush.
You rock 👍
Great specs BTW 😃
from gush.
@mickael-palma-argus @theo-delaune-argus @jdreic this is now released as 2.0.1
, thanks again for the report and help with identifying the issue ❤️
/cc @devilankur18 @hqm42 @vadshalamov
from gush.
Hey @jdreic, thanks for the report. This sounds like a bug!
from gush.
Hi,
The problem occurs in the job parameters.
If job first launch failed, it set @failed_at = time of fail
.
But when job is replayed, @failed_at
is not resetted to nil.
If you take look at https://github.com/chaps-io/gush/blob/master/lib/gush/worker.rb#L73, when children jobs are enqueued, it checks if parent has succeeded.
Since the parent job still had the @failed_at
non-nil, the children are not enqueued.
This is my fix :
# Override Gush::Job start!
# To ensure failed_at is reset when job is relaunched by Sidekiq
class BaseJob < Gush::Job
def start!
super
@failed_at = nil
end
end
from gush.
Hey guys! Thank you for finding the culprit! Will release a fix ASAP!
from gush.
Related Issues (20)
- Allow redis 5 HOT 1
- Are you open for a Postgresql client? HOT 2
- Integration with sidekiq-status HOT 3
- Many mutex fails after #49000a30fd34ac21cabdc7d HOT 9
- Activejob callbacks not available in the Gush::Job
- Long-running jobs and human job completion HOT 11
- Gush.configure with namespace issue HOT 3
- Can we run same workflow parallelly with different arguments? HOT 1
- bundle exec viz workflow with parameters HOT 6
- Shortcircuit workflows HOT 16
- Cannot assign requested address - connect(2) for [::1]:6379 HOT 12
- Overlapping workflows HOT 1
- Update Gem on RubyGems HOT 3
- Project status HOT 8
- Can I create a dynamic workflow based on job's output? HOT 1
- Project Idea - Web UI HOT 1
- cannot create workflow instance HOT 2
- Dead Link to "Parallelizing Operations With Dependencies" by Stephen Toub
- Polling scenario in job HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gush.