Jobs that eventually succeed will not queue downstream jobs about gush HOT 6 CLOSED

Hi,

I prefer using refinements 😄

# Temporary fix: https://github.com/chaps-io/gush/issues/61
# Overrides Gush::Job start! method.
# Resets failed_at variable when Sidekiq reloads a job.
module GushJobFix
  refine Gush::Job do
    def start!
      super
      @failed_at = nil
    end
  end
end

class MyJob < Gush::Job
  using GushJobFix

  def perform
    ...
  end
end

from gush.

You rock 👍
Great specs BTW 😃

from gush.

@mickael-palma-argus @theo-delaune-argus @jdreic this is now released as 2.0.1, thanks again for the report and help with identifying the issue ❤️

/cc @devilankur18 @hqm42 @vadshalamov

from gush.

Hey @jdreic, thanks for the report. This sounds like a bug!

from gush.

Hi,

The problem occurs in the job parameters.
If job first launch failed, it set @failed_at = time of fail.
But when job is replayed, @failed_at is not resetted to nil.

If you take look at https://github.com/chaps-io/gush/blob/master/lib/gush/worker.rb#L73, when children jobs are enqueued, it checks if parent has succeeded.
Since the parent job still had the @failed_at non-nil, the children are not enqueued.

This is my fix :

# Override Gush::Job start!
# To ensure failed_at is reset when job is relaunched by Sidekiq
class BaseJob < Gush::Job
  def start!
    super
    @failed_at = nil
  end
end

from gush.

Hey guys! Thank you for finding the culprit! Will release a fix ASAP!

from gush.