chafey / cornerstonedemo Goto Github PK

I'm currently trying to play around with the demo, but I can't manage to have actual images displaying. Wether it's on the live demo (http://chafey.github.io/cornerstoneDemo/) or locally, everything is black. From what I understand the images are just not accessible.

What would be the best way to get images to display? Do I have to create a server that responds to xmlhttprequests, or can I serve local files/files accessible via http? If I can serve local files, how? Modifying the JSON to lead to local files seem unsuccessful, and modifying the code in the js (loadStudy.js) files seem unsuccessful too.

Github allows you to assign the main branch to something other than master, we should do that to make the repo easier to search.

I'm not sure if it's actually possible to remove the master branch altogether, but if it is we could do that too.

Steps:

Draw or a ROI, move it so that part of it is outside the imaged area and part of the background color on the page changes.

Not sure if this is already possible but I could not fnd it.

Some studies which are large take a long time to load, specialy CTs, is there any way to add a generic image while a particular image within a series has not been loaded but someone navigates to that stack index?

Or on the other hand, is there a way to replace a particular stack index, say pass the generic image as the stack index initially but then replace it with another one?

Between 1000 and Infinity.... and beyond!

Dear sir,

First please allow me to show my thanks for your great job of dicom file parser, viewer and tools.

I’m working on a web-based remote clinic project. I’m modifying your demo to show organized dicom files in a web-storage. And most of the file packages can be well shown.

But I’ve just meet a problem with two dicom files. You may try the files here:

http://pacs.yunshung.com/201507140000119q5cjcv97jev6f1mtv1tsmuusi.json?view

or

http://test.yunshung.com/csDemo/index2.html
which is an attempt to upgrade the libraries to the latest version of your great works (not done yet).

Could you please check the dicom files laid in the web-storage:

http://dicom.yunshung.com/201507140000119q5cjcv97jev6f1mtv1tsmuusi/1.3.46.670589.26.802276.1.20141114.154321.46183/1.3.46.670589.26.802276.2.20141114.154341.39249/1

http://dicom.yunshung.com/201507140000119q5cjcv97jev6f1mtv1tsmuusi/1.3.46.670589.26.802276.1.20141114.154321.46183/1.3.46.670589.26.802276.2.20141114.154422.39250/1

These files are well manipulated in OsiriX Lite in my laptop.

Are these files non-standard? Or should the libraries be modified to improve the compatibility with different files?

Thanks again for you time and help.

Wish you all the best.

BRs
KingMario

Plays automatically, does not stop with the stop button.

I am not sure what this code is supposed to do:

function resizeMain() {
    var height = $(window).height();
    $('#main').height(height - 50);
    $('#tabContent').height(height - 50 -42);
}

$(window).resize(function() {
    resizeMain();
});
resizeMain();

but I don't think that #main is defined.

Also are you missing overflow-y: scroll on #tabContent?

I have a new moto g phone with android kitkat. I can change w/l with single finger swipe,
change zoom with pinch, but I can't find a way of scrolling through the thumbnails: this is necessary because not all thumbnails can fit into the screen at one time.

Looking at the network graph on the developer tools, I see that images are being loaded sequentially:

Can they be loaded simultaneously? Would this increase performance?

swim.zip

Steps to repro:

1. open multiple image tabs
2. click on tab A
3. resize browser
4. switch to tab B

Layout is now messed up. Resizing again will fix for this tab, but then other tabs will be broken.

It is difficult to zoom to the desired size.

Will this application be supporting the playclip of dicom video which is of wadoURI type.

Measuring on images with no definitive scale, such as CR or MG results in a "NaN" measurement like this:

Perhaps it would be better if images with no real scale disabled the measurement tool.

if the user selects the same study more than once from the study tab, the original
tab for this study could be displayed.

When I run the demo and click any row, no image displays.

There needs to be a mechanism to delete measurements. This may go back to having key bindings. BIR specifies how to select the tool, and how to apply a "Dsiplay reset", but nothing about deleting specific measurements. This is useful in the clinical setting, however.

The tool gets disabled when trying to place start point. Tested on iPad.

forgive my poor english....

Not sure if the demo is meant to be used on mobile yet, but just in case, some work would be needed to make it look good on phones.

Since you are using Bootstrap, I may be able to help a little with that if needed.

When the demo is launched in IE11 and a study is selected, the viewport screen layout is messed, no images displayed and the console log shows the following error:

SCRIPT5022: InvalidStateError
cornerstoneWADOImageLoader.js (3737,5)

tapping invert makes the image change twice: invert, then back to original. So, it seems to receive two events.

In one place it is called WW/WC in the other WW/WL:

• cornerstoneDemo/index.html

  Line 390 in c112d07

  $(bottomRight[1]).text("WW/WL:" + Math.round(e.detail.viewport.voi.windowWidth) + "/" + Math.round(e.detail.viewport.voi.windowCenter));

• cornerstoneDemo/index.html

  Line 209 in c112d07

  <div>WW/WC:</div>

Currently the button indices are hard coded. This same code is much less fragile in the allImageTools example.

Open study tabs cannot be closed, may clutter up the UI when there are many open.

Some feedback on image loading would be useful. Perhaps a discrete progress bar type indicator?

For those of us with trackpads, it is often useful to switch between tools using keyboard modifiers due to a lack of [right or center click] + drag

For example, in OsiriX, the default tool is WW/WL, but pressing Command = Pan, and Shift = Zoom

Some kind of key binding functionality might prove useful.

Why call each tooltip on each button like this rather than a simple: http://getbootstrap.com/javascript/#opt-in-functionality

Scrolling on Chrome normally "bounces" when it reaches theupper or lower ends of a page.

Maybe this can be disabled when scrolling over a viewport?

I got the following version conflicts:

    1) cornerstone#~0.8.4 which resolved to 0.8.4 and is required by cornerstoneWADOImageLoader#0.7.2, cornerstoneWebImageLoader#0.5.3
    2) cornerstone#~0.8.1 which resolved to 0.8.4 and is required by cornerstoneDemo
    3) cornerstone#~0.9.0 which resolved to 0.9.1 and is required by cornerstoneTools#0.7.9

    1) jquery#~2.1.1 which resolved to 2.1.4 and is required by cornerstone#0.8.4, cornerstone#0.9.1, cornerstoneDemo, cornerstoneWADOImageLoader#0.7.2
    2) jquery#~2.2.0 which resolved to 2.2.4 and is required by cornerstoneTools#0.7.9
    3) jquery#1.9.1 - 3 which resolved to 3.2.1 and is required by bootstrap#3.3.7

The versions of the cornerstone* packages are quite old in bower.json. I tried updating them to the latest, but got into more version issues between the cornerstone packages so I just used the following resolutions:

"resolutions": {
   "cornerstone": "~0.8.1",
   "jquery": "~2.2.0"
}

This seems to work.

It would be nice to have some dicom data available for the demo, even one study.

Hi,

I put a length measurement on one image then I selected the tool wwwc.
And if i tried to resize my length measurement by moving one handle but the wwwc it's also applied.
I took a look on your sample allImageTools of cornerstoneTools and the same operation is working well.
Is it a issue or the cornerstone demo or do these two project do not have the same version of cornerstoneTools?

Many Thanks for your answer.

Adil

Mac Chrome Version 57.0.2987.133 (64-bit) is getting a cross-origin error when visiting http://chafey.github.io/cornerstoneDemo/ It was working a few days ago. Also happens in Safari. In Firefox, the requests hang. Here's there Chrome error:

chafey.github.io/:1 XMLHttpRequest cannot load http://cornerstonetech.org/images/ClearCanvas/MRStudy/1.2.840.113619.2.5.1762583153.215519.978957063.226.dcm. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://chafey.github.io' is therefore not allowed access.
XHR failed loading: GET "http://cornerstonetech.org/images/ClearCanvas/MRStudy/1.2.840.113619.2.5.1762583153.215519.978957063.226.dcm".

I cleared cache/history in Safari, and still the same error.

http://cornerstonetech.org redirects to a godaddy ad page, btw.

The highlight tool is available at: https://github.com/chafey/cornerstoneTools/blob/master/examples/allImageTools/index.html but not in the cornerstoneDemo. Should be easy to add using:

<button id="highlight" type="button" class="btn btn-sm btn-default" data-container='body' data-toggle="tooltip" data-placement="bottom" title="Highlight"><span class="fa fa-pencil-square-o"></span></button>

            $(buttons[12]).on('click touchstart',function() {
              disableAllTools();
              cornerstoneTools.highlight.activate(element, 1);
            });

I tried accessing this demo link - http://chafey.github.io/cornerstoneDemo/

But after choosing a model or patient data nothing gets displayed.

I would like touch panel gestures, important ones to me are;

• Pinch to zoom in and out
• windows and level mode
• Some ways of going through CT stacks

Probably need a row of small gesture mode change buttons...

More esoteric ones are

• Re-order the images, shuffling. This however will require much thoughts since if you allow this, then you would want to do this in the entire study, so how would you shuffle a 138 image study easily...