Giter Club home page Giter Club logo

cr-async's People

Contributors

fourjr avatar isaacli430 avatar kyb3r avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

isaacli430

cr-async's Issues

await profile.get_clan() issue (what is this?)

2017-10-29T19:40:45.894855+00:00 app[worker.1]: Ignoring exception in command profile:
2017-10-29T19:40:45.895155+00:00 app[worker.1]: Traceback (most recent call last):
2017-10-29T19:40:45.895219+00:00 app[worker.1]:   File "/app/.heroku/python/lib/python3.6/site-packages/discord/ext/commands/core.py", line 62, in wrapped
2017-10-29T19:40:45.895221+00:00 app[worker.1]:     ret = yield from coro(*args, **kwargs)
2017-10-29T19:40:45.895240+00:00 app[worker.1]:   File "/app/cogs/profile.py", line 38, in profile
2017-10-29T19:40:45.895241+00:00 app[worker.1]:     clan = await profile.get_clan()
2017-10-29T19:40:45.895267+00:00 app[worker.1]:   File "/app/.heroku/python/lib/python3.6/site-packages/crasync/core.py", line 92, in get_clan
2017-10-29T19:40:45.895269+00:00 app[worker.1]:     data = await self.request(url)
2017-10-29T19:40:45.895286+00:00 app[worker.1]:   File "/app/.heroku/python/lib/python3.6/site-packages/crasync/core.py", line 56, in request
2017-10-29T19:40:45.895287+00:00 app[worker.1]:     data = await resp.json()
2017-10-29T19:40:45.895307+00:00 app[worker.1]:   File "/app/.heroku/python/lib/python3.6/site-packages/aiohttp/client_reqrep.py", line 730, in json
2017-10-29T19:40:45.895308+00:00 app[worker.1]:     headers=self.headers)
2017-10-29T19:40:45.895352+00:00 app[worker.1]: aiohttp.client_exceptions.ClientResponseError: 0, message='Attempt to decode JSON with unexpected mimetype: text/html; 

members with no clan returns an error

Traceback (most recent call last):
File "/app/cogs/utils.py", line 852, in _eval
ret = await func()
File "", line 4, in func
File "/app/.heroku/python/lib/python3.6/site-packages/crasync/core.py", line 65, in get_profile
return Profile(self, data)
File "/app/.heroku/python/lib/python3.6/site-packages/crasync/models.py", line 36, in init
self.from_data(data)
File "/app/.heroku/python/lib/python3.6/site-packages/crasync/models.py", line 258, in from_data
self.clan_tag = clan.get('tag')
AttributeError: 'NoneType' object has no attribute 'get'

arena image url

might wanna add this so people don't have to manually set it

Unit Tests

Assuming that you would still like to become the official wrapper for cr-api, please pick an async testing framework and include unit tests in a folder so that we can run + test to see that the framework is behaving properly.

Manual example testing with print statements cannot be automated and is prone to error.

Create requirements.txt and put requirements there

To make it easier to install, please consider making a document called requirements.txt and put it in the top level.

Then run:

pip freeze > requirements.txt

to put all the required libraries there.

docs

lacking a lot

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.