cgeoga / besselk.jl Goto Github PK

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Suggestion: with a bit of creativity, it should be possible to use Unicode to greatly improve the readability of the README. For example, see jbytecode/JMcDM#31.

I would have suggested a PR for this repo already if \nu (ν) was available as subscript. That isn't the case unfortunately, so that's why a bit of creativity is needed. Would it be possible to use another character than ν so that the subscript would work out?

The below bug is a deal-breaker for me using the library - or am I doing something wrong?

I have [432ab697] BesselK v0.3.1, on Julia 1.7.1, ubuntu linux 20.04, Ryzen 5700U CPU:

using BesselK
julia> adbesselk(0,8.4999999)
8.625757540580426e-5
julia> adbesselk(0,8.5)
NaN
julia> adbesselk(1,8.5)
9.119724831363708e-5

I have not had time to look into the src code logic, but it looks like a bad human decision point at 17/2.

Also, for timings per eval for nu=0, arg in (0,10) range:
adbesselk K_0 time: 205 ns
SpecialFunctions besselk K_0 time: 269 ns
Since adbessel is native Julia code, I was hoping for something faster. Do you have a claimed speedup vs Amos complex-arg zbesk Fortran code (which is what SpecialFunctions.jl wraps) ?

Thanks, Alex

Just an FYI, this expression : https://github.com/cgeoga/BesselK.jl/blob/main/paperscripts/testing/notinuse/matern_derivative_speed.jl#L7-L18

doesn't actually do what it seems like! Currently, writing (@foo x, @foo y) is parsed as (@foo(x, @foo(y))), not (@foo(x), @foo(y)) though changing that is currently under consideration in JuliaLang/julia#36547

https://github.com/heltonmc/Bessels.jl is in the process of implementing all the bessel functions, so it might make sense for this code to become part of that library.

Suggestion: you can use a citation file to make it easier for people to cite this repo. Once done, people can, for example, add your project Zotero with one click. More info at https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files.