cfht / opera Goto Github PK

I think in Line::getLineYWidth() we should be multiplying by the cos instead of dividing by it. Attached picture shows how I expect the geometry to work, with W_y being the result of the function.

Changing this would affect the extraction aperture spacing, which may or may not have a big impact on results, and probably requires a lot of testing on quality of the results.

OS gentoo, gcc v6.4.0. Tried to compile it on Debian 9(gcc is 6.4.0 too),got same results.
fail.log
Compiled nearly fine on CentOS 7, gcc 4.8.5

Both the operaArrayMedian and operaArrayMedian_d functions will produce incorrect results in some cases. The Median template function, which is correct, doesn't work with arrays, so either the array median functions should be fixed, or more ideally, any place using arrays could be swapped out with Vectors. However, the latter option may require turning lots of C code into C++.

Will result in errors such as:
https://stackoverflow.com/questions/4035445/linker-error-undefined-reference-to-stdctypechar-m-widen-init
https://stackoverflow.com/questions/18712754/linker-error-undefined-reference-to-stdctypechar-m-widen-init-from-st
As a workaround, can remove -L/usr/lib and other system path references, e.g. /usr/local/lib, /usr/include, /usr/local/include, etc.
Potentially we could replace automake system with something simpler and more portable. We're not doing much that requires advanced build features.