ceronman / loxido Goto Github PK

I read your blog post and and I'm using your unsafe implementation as a reference for my own implementation.

I might be misunderstanding, but wouldn't this particular line just free memory up to the size of a GcObject (i.e. just the header part of your object) and not the full object?

Wouldn't you need to do a match and transmute to each type, similar to how you've done it in blacken_object?
e.g.

Hi,

great implementation!

Would it be difficult to add the ability of scripts to return values ? For example if I would like to evaluate an expression and would expect an boolean return type, or if I want to evaluate a number expression and would expect a number to be returned ?

Thanks

Hi,
Thank you so much for sharing your great code and your experience in the blog.
I'm reading your GC code in unsafe https://github.com/ceronman/loxido/blob/unsafe/src/gc.rs and have a question.

Question

Is it intentional that trace_references is marking objects (= trace from roots) and pushing them to grey_stack?

Why I'm asking

In my understanding the GC works in 3 steps as below.

1. Mark roots and push them to grey_stack. (= Mark)
2. Iterate over grey_ stack and recursively mark used objects (= Trace).
3. Free unused objects (= Sweep).

I see grey_stack as a collection of root objects and it is created in 1 and used in 2.
But I see grey_stack is actually updated in 2 which makes me think why.

Thank you in advance,
Taro