Giter Club home page Giter Club logo

Comments (5)

anoopcs9 avatar anoopcs9 commented on July 18, 2024 2

@ansiwen @phlogistonjohn @anoopcs9 We can modify the test case to treat it error rather than no error. But this may require the versioning check for ceph.

Modifying the test case accordingly calls for new test file with proper build tags to differentiate between Ceph versions. Let's not go that way.

Otherwise we can remove the test case entirely since it is checking an invalid case

I would vote for the removal of those related test cases.

from go-ceph.

thotz avatar thotz commented on July 18, 2024

Even though it is failure behaviour seems to be right for error. RGW was sending empty list for unknown user, now it is sending error. I tired to tracked which PR might cause this change. And looks like ceph/ceph@5083612 made a lot of changes for that API

from go-ceph.

ansiwen avatar ansiwen commented on July 18, 2024

Even though it is failure behaviour seems to be right for error. RGW was sending empty list for unknown user, now it is sending error. I tired to tracked which PR might cause this change. And looks like ceph/ceph@5083612 made a lot of changes for that API

@thotz Would you be willing to do a PR to fix that? Because you seem to be the last man standing who knows something about RGW. 😬

from go-ceph.

anoopcs9 avatar anoopcs9 commented on July 18, 2024

I tried to do some mapping w.r.t git commit hashes and container image hashes around the time when CI failure was first reported and kind of concluded on ceph/ceph#56863 as the change which converted response from empty list([]) to null.

Previously:

HTTP/1.1 200 OK
Content-Length: 2
Connection: Keep-Alive
Date: Tue, 16 Apr 2024 01:41:10 GMT
Server: Ceph Object Gateway (squid)
X-Amz-Request-Id: tx00000c270c1b2e7b9ad07-00661dd736-4196-default

[]

and now:

HTTP/1.1 200 OK
Connection: Keep-Alive
Date: Thu, 18 Apr 2024 01:40:53 GMT
Server: Ceph Object Gateway (squid)
X-Amz-Request-Id: tx0000031b3662f2b264cdc-0066207a25-4188-default
Content-Length: 0


=== NAME  TestRadosGWTestSuite/TestUserBucket
    user_bucket_test.go:37: 
        	Error Trace:	/go/src/github.com/ceph/go-ceph/rgw/admin/user_bucket_test.go:37
        	Error:      	Received unexpected error:
        	            	failed to unmarshal radosgw http response. . unexpected end of JSON input
        	Test:       	TestRadosGWTestSuite/TestUserBucket

from go-ceph.

thotz avatar thotz commented on July 18, 2024

@ansiwen @phlogistonjohn @anoopcs9 We can modify the test case to treat it error rather than no error. But this may require the versioning check for ceph. Otherwise we can remove the test case entirely since it is checking an invalid case

from go-ceph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.