Comments (3)
phlogistonjohn
commented on July 18, 2024
cc: @manishym @nixpanic @anoopcs9
from go-ceph.
anoopcs9
commented on July 18, 2024
We all knew this was coming and that's exactly why I requested for an issue early on to track the changes required with the build tags for 2 variants of test files(fs_quiesce_test.go and fs_quiesce_reef_test.go).
Let's keep the issue open until squid release is out with the feature and corresponding CI job is enabled for go-ceph.
Till then we could have the following change in build tags:
index 5a1075c..73e28ff 100644
--- a/cephfs/admin/fs_quiesce_reef_test.go
+++ b/cephfs/admin/fs_quiesce_reef_test.go
@@ -1,4 +1,4 @@
-//go:build (nautilus || octopus || pacific || quincy || reef || squid || ceph_pre_squid) && ceph_preview
+//go:build (nautilus || octopus || pacific || quincy || reef) && ceph_preview
package admin
diff --git a/cephfs/admin/fs_quiesce_test.go b/cephfs/admin/fs_quiesce_test.go
index db2d94d..4aa4b05 100644
--- a/cephfs/admin/fs_quiesce_test.go
+++ b/cephfs/admin/fs_quiesce_test.go
@@ -1,4 +1,4 @@
-//go:build !(nautilus || octopus || pacific || quincy || reef || squid || ceph_pre_squid) && ceph_preview
+//go:build !(nautilus || octopus || pacific || quincy || reef) && ceph_preview
package adminI would also suggest a change in name for fs_quiesce_reef_test.go as it is applicable for any version prior to squid(upcoming).
from go-ceph.
Related Issues (20)
- APIs pending stability updates in v0.23.0
- Support crush manager HOT 4
- Add timeout to Ceph GET API calls HOT 2
- Missing rbd API components: function peer_site_remove HOT 2
- macos m1pro fatal error: 'rados/librados.h' file not found HOT 12
- Image corruption when doing Copy(...) HOT 1
- Potential memory leak on rbd image copy HOT 6
- CI job 'check' emits a warning about go.mod
- rgw: Empty usage problem HOT 3
- TestPingMonitor crashes HOT 6
- Enhance `GetPoolStats()` Method to Include `Num_bytes_available` Field in `PoolStat` HOT 2
- APIs pending stability updates in v0.24.0
- Support bucket scope quota HOT 4
- Add support for rbd_resize2
- Implement subvolume quiesce API HOT 4
- Need squid branch support
- Pacific CI jobs are failing with package dependencies HOT 5
- Should `Resize()` after `EncryptionLoad()` account for the encryption header space? HOT 7
- TestCloneSubVolumeSnapshot failing on ceph main branch HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-ceph.