Add wrappers for `rbd trash` functionality about go-ceph HOT 5 CLOSED

@noahdesu After merging #66, would you mind please running go fmt ./... on the tree? The go-ceph source is in general not formatted as per gofmt, and I didn't want to do that myself in this PR as it would obscure what was actually new code, and what was just reformatting. Maybe you can include a gofmt into the CI pipeline, so as to fail tests if source is not formatted.

from go-ceph.

Thanks, that's in the CI now along with fmt fixes.

from go-ceph.

The current plan is to keep go-ceph master branch up-to-date with ceph master, and then fork out branches for versions that have backwards compat issues. I believe the current go-ceph master branch has some deprecations, but we haven't yet cut any branch according to this plan.

So if you'd like to build these wrappers you can submit a PR against the master branch and we'll figure out how to build these other branches in the future.

If you happen to have any opinions about how to handle the compat issues, we are also interested in hearing those. But so far these simple plan has been the consensus.

from go-ceph.

@dswarbrick do you know what the command is to validate with go fmt? I think it go right here https://github.com/ceph/go-ceph/blob/master/entrypoint.sh#L12

from go-ceph.

@noahdesu You can use something like gofmt -d -s . which will write a diff to stdout, instead of modifying the files in-place. If the code is already well formatted, this should be an empty string.

Added to travis.yml, it should appear in the script section something like:

script:
  - diff -u <(echo -n) <(gofmt -d -s .)

from go-ceph.