Giter Club home page Giter Club logo

gatsby-remark-images-grid's Introduction

Hi I'm Cédric Delpoux

As a front-end web developer, bringing ideas to life is what excites me on a daily basis. Thinking algorithms and solving problems are why I choose this job. Code is beautiful. Possibilities are endless. From the white canvas to the final design, it makes me feel like an artist. What I enjoy most is to be able to be creative every day.

Website

Technologies I enjoy working with

Node.js Netlify React CSS3 Figma Gatsby GraphQL Styled Components Npm Html5 Git Prettier Babel Javascript Github

Open-source projects

Repository Stars Downloads

Places you can reach me

gatsby-remark-images-grid's People

Contributors

cedricdelpoux avatar dependabot[bot] avatar hendra-go avatar rwieruch avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

gatsby-remark-images-grid's Issues

Code example is wrong

module.exports = {
plugins: [
{
resolve: "gatsby-transformer-remark",
options: {
plugins: [
// Make CSS grids available
// without options
"gatsby-remark-grid"
// or
// with options
{
resolve: "gatsby-remark-grid",
options: {
className: "myCustomClassName",
gridGap: "20px",
margin: "20px auto",
},
},
],
},
},
],
}

Should be

module.exports = {
plugins: [
{
resolve: "gatsby-transformer-remark",
options: {
plugins: [
// Make CSS grids available
// without options
"gatsby-remark-images-grid"
// or
// with options
{
resolve: "gatsby-remark-images-grid",
options: {
className: "myCustomClassName",
gridGap: "20px",
margin: "20px auto",
},
},
],
},
},
],
}

Plugin not working with Amsterdam-theme

Hi. The plugin doesn't seem to work with amsterdam-theme. It's quite a popular theme so would be nice to figure out why the plugin doesn't trigger the grid after adding the plugin to the gatsby-config and rebuilding. Attached a screenshot of current behaviour.

Screenshot 2020-02-23 at 16 45 03

Plugin not working for me

Hi!
I couldn't make this plugin work here.
Has anyone managed to make this work in conjunction with gatsby-remark-images? I'm wondering it might be a compatibility problem.

I've followed the guide and put it before any other image plugins:

{
  resolve: `gatsby-transformer-remark`,
  options: {
    plugins: [
      {
        resolve: "gatsby-remark-images-grid",
        options: {
          gridGap: "2rem",
        },
      },
      {
        resolve: `gatsby-remark-images`,
        options: {
          maxWidth: 1036,
          linkImagesToOriginal: false
        },
      },
      'gatsby-remark-smartypants',
      `gatsby-remark-reading-time`,
      'gatsby-remark-component',
    ],
  },
},

Here's how it looks like in the markdown code:

```grid|4|test
![](./day2-dev.jpg)
![](./day2-dev2.jpg)
![](./day2-meeting.jpg)
![](./day2-team.jpg)

Here's how the final result looks like when inspected:

image

--

Full project code can be find here: https://github.com/cmdalbem/portfolio

HTML/Markdown in caption is not processed

I'd like to include a link in the caption for my image grid.

I've tried

```grid|2|Caption with a <a href="/dest">link</a> and another ![link](/dest2)
![](image1)
![](image2)
```

but the caption is rendered with the code in text:

Caption with a <a href="/dest">link</a> and another ![link](/dest2)

Ideally at least the HTML would be processed as HTML in the rendered output.

Rendered caption only includes first word of caption

Not sure when this started happening, but it looks like the rendered output of this module does not handle the caption properly anymore.

For example, if you have the following in your markdown document:

![](../photo1.jpg)
![](../photo2.jpg)

The grid will render with the two images, but the caption will only include "My", ignoring everything else.

Poking around, it looks like the full caption is no longer included as part of node.lang that's used here: https://github.com/xuopled/gatsby-remark-images-grid/blob/master/src/index.js#L6

Instead, anything after the first space is put into node.meta. I've forked this and fixed it by just naively concatenating the two fields, but I'm not sure if you want to investigate something more robust. Might be worth identifying why the behaviour of node.lang changed in the first place.

Here's my "hotfix":
BruOp@517daee

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.