cdown / exifrename Goto Github PK

Right now when we have an error we just print it out with eprintln!(), but the exit code is still 0. Ideally we should show that an error occurred by having an error code >0 -- 1 is fine.

You can do this with process::exit(1) at the end of main. We should still continue anyway, but just indicate at the end that it failed with a >0 exit code.

The big ones to be split:

1. get_paths
2. get_names
3. rename_files

Will need to pass error_seen.

Currently the log looks like:

/tmp/sdcard/P0030.jpg -> /tmp/FUJIFILM/20230126_190651.jpg
failed to finalise /tmp/sdcard/P0030.jpg -> /tmp/FUJIFILM/20230126_190651: File exists (os error 17)
/tmp/sdcard/P0032.jpg -> /tmp/FUJIFILM/20230126_190654_0.jpg
failed to finalise /tmp/sdcard/P0032.jpg -> /tmp/FUJIFILM/20230126_190654: File exists (os error 17)
/tmp/sdcard/P0033.jpg -> /tmp/FUJIFILM/20230126_190654_1.jpg
failed to finalise /tmp/sdcard/P0033.jpg -> /tmp/FUJIFILM/20230126_190654: File exists (os error 17)

Firstly, it would be good for the log to show the full name if at all possible.

Secondly, it would be better to avoid printing the first group of interleaved lines on failure, since they're already shown in full context in the failure.