ccao-data / assessr Goto Github PK

This JSON query no longer works.

Recent literature from the IAAO and others has suggested using a Gini-like index for measuring vertical equity in property assessments. We should add such a measurement to this package and the ccao package, then add it to our existing batch of output statistics.

See https://researchexchange.iaao.org/jptaa/vol17/iss2/2/ and https://www.sciencedirect.com/science/article/abs/pii/S1051137723000372.

• Add new Gini function with R/formulas.R
• Make sure your code updates meet styling and linting requirements:
  • Styling: Run styler::style_pkg() in the console
  • Linting: Run lintr::lint_package() in the console
• Build any documentation updates by running devtools::document() in the console
• Add unit tests, copying the existing tests for cod()
• Run the build and test processes locally to check for errors:
  • Build: In RStudio, go to the Build tab, then hit Check
  • Test: In RStudio, go to the Build tab, then hit Test OR devtools::test() in the console
• Update DESCRIPTION file with new version (using SemVer) and date
• Make pull request
• Cut new release version in GitHub

We should add functions to replicate the methods outlined in the IAAO Data Quality Standard. Specifically, we can likely add functions for:

• Appendix F. Sold and Unsold
• Appendix I. Edge Case Identification
• Appendix J. General Data Quality Score
• Appendix K. Impact Identification

Ask @dfsnow for a copy of the document.

When this issue is closed, notify Travis.

I have a set of ratios, and I group them and try to calculate CODs using dplyr's summarise() function. Some groups are empty. I get the error:

Error in `dplyr::summarise()`:
ℹ In argument: `cod = assessr::cod(ratio)`.
ℹ In group 101: `year = 2016`, `triad_name = "North"`, `stage = "Certified by Assessor"`, `sale = "Year following
  reassessment year"`.
Caused by error in `FUN()`:
! length(x) > 1 is not TRUE

It may be better to return an NA value for groups that don't have any observations.