cbasolutions / osticket-plugins Goto Github PK

As stated in the official forum a re-configuration must be tested because currently the plugin has stopped to work:
[https://forum.osticket.com/d/92134-openid-authentication-for-microsoft-in-osticket/15]

The LOGIN_TYPE cookie is set als CLIENT and AGENT when trying to sign-in as an agent. This results in a redirect after login to https://osticket/login.php instead of https://osticket/scp/login.php

Steps to reproduce:

1. Open https://osticket/login.php
2. Click Sign In
3. Click I'm an agent — sign in here
4. Click Sign in with Microsoft
5. After successful sign-in, redirected to https://osticket/login.php instead of https://osticket/scp/login.php

Analysis:

This issue occurs when both agent and client login via auth-openid-ms is configured. When following the steps above two LOGIN_TYPE cookies are set:

Hello,

First of all, thanks for making this and open-sourcing it. It's working well for us in testing.

If a user creates their account through this plugin by signing into their Office 365, their email address is stored both in the ost_user_account table's username) column and also as the default record in the ost_user_email table. My concern is for those occasions where a user has their Office 365 administrator change their account's email address. This is typical for name changes, such as an employee getting married and changing their last name, then updating their email address to match.

How does this plugin handle that upon the first login with the new email address? Does it change the email addresses stored in osTicket's database, or does it treat it as a new user? If the latter is the case, which update scripts need to be run on the osTicket side to get those email addresses in sync so that a duplicate account scenario doesn't arise?

Side note: you should consider creating a pull request to add this great plugin to the official https://github.com/osTicket/osTicket-plugins repo so others can find it. I would not have chosen osTicket as our help desk solution if it weren't for your plugin, and I bet other people are in the same boat.

For login staff when the url has https://mysoportesite.com/tickets.php not hiden de login option

Thanks

Hey @cbasolutions ,

I changed one setting of the OpenID plugin on OST, which I believe now prevents me from logging back into the admin portal? Quite annoyingly....

Last thing I change I made before this happened was changing some of the settings for the OpenID plugin. On this page, I checked the 2 last boxes (which weren't previously checked). By doing so, my goal was to remove the manual login both for the client and the staff, as everyone would be using Microsoft's SSO.

It did remove it for the Staff login page: /scp/login.php (I can actually see the local login appear for a micro-second when the page loads). For some reason it did not remove it for the client login: /login.php.

I made these settings changes yesterday, and today the SSO does not work anymore. I am unable to log back into the admin, which prevents me from reverting any settings... Once I click on the Microsoft Login button it just leads me to a blank page that has the following URL: /scp/login.php?do=ext&bk=openid_ms.staff

Would it be possible that this is due to the OpenID settings change I made??
How can I get back to the admin and revert this setting? Am I stuck for life? haha