carterfaceysmith / dagonsmountain Goto Github PK

Hello, as part of a task of my university for the subject of Software Design, together with my group we selected your repository and performed a search for the so-called Code Smells and we want to make some suggestions to improve the code using refactoring techniques, thank you.

Duplicate Code

Problem: Methods have the same function
Technique to use: Substitute Algorithm
Benefits: If we create a new algorithm to replace the code we can organize it in a better way and make it more efficient, in this case with a fairly simple switch in which you can always add new options.

Data clumps

Problem: All of these variables could become classes.
Technique to use: Extract Class
Benefits: By separating into classes you can better organize your code so that your code is more understandable for reading, modification or maintenance.

Large class

Problema: La clase dagonsMountain posee muchas líneas de código
Técnica a usar: Extract Class
Beneficios: Se en clases distintas hace el código mucho más entendible y ayuda a aplicar el principio de responsabilidad única.