Based on the backend PR#1237, frontend PR#2094, and the protobuf PR#81

We should add new tests (or modify the existed tests) case based on the enhancement of image fitting

• Design
• Implementation

A new issue has suddenly appeared on macOS12. None of the ICD tests can run. When they try to run, the following message appears:

There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.

The react-scripts package provided by Create React App requires a dependency:

  "babel-jest": "^24.9.0"

Don't try to install it manually: your package manager does it automatically.
However, a different version of babel-jest was detected higher up in the tree:

  /Users/acdc/node_modules/babel-jest (version: 27.5.1) 

Manually installing incompatible versions is known to cause hard-to-debug issues.

If you would prefer to ignore this check, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That will permanently disable this message but you might encounter other issues.

To fix the dependency tree, try following the steps below in the exact order:

  1. Delete package-lock.json (not package.json!) and/or yarn.lock in your project folder.
  2. Delete node_modules in your project folder.
  3. Remove "babel-jest" from dependencies and/or devDependencies in the package.json file in your project folder.
  4. Run npm install or yarn, depending on the package manager you use.

In most cases, this should be enough to fix the problem.
If this has not helped, there are a few other things you can try:

  5. If you used npm, install yarn (http://yarnpkg.com/) and repeat the above steps with it instead.
     This may help because npm has known issues with package hoisting which may get resolved in future versions.

  6. Check if /Users/acdc/node_modules/babel-jest is outside your project directory.
     For example, you might have accidentally installed something in your home folder.

  7. Try running npm ls babel-jest in your project folder.
     This will tell you which other package (apart from the expected react-scripts) installed babel-jest.

If nothing else helps, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That would permanently disable this preflight check in case you want to proceed anyway.

P.S. We know this message is long but please read the steps above :-) We hope you find them helpful!

It seems there is a newer version of babel-jest on the system (/Users/acdc/node_modules/babel-jest) and that is conflicting with the older version used by the ICD tests. One solution may be to delete the newer version, however, it might not be the best solution if a user requires the newer dependency for something else.

I have found two working solutions:

1. The .env workaround. When I create a file called .env containing SKIP_PREFLIGHT_CHECK=true, then the ICD tests can run successfully.

2. I have determined that it is our react-scripts dependency that uses babel-jest. Our package.json uses react-scripts version 3.4.4, and that installs babel-jest version 24.9.0. I have tried using the latest react-scripts version which is 5.0.1. That installs babel-jest version 27..5.1 and the error is gone.

@acdo2002 Do you think we should update the react-scripts dependency in our package.json to 5.0.1?

Now FileOpen ICD message contains "support aips", we need a test for testing this sub-message

The backend PR#1194 add new function to support the swap images.
Then the current ICD-RxJS FILEINFO_FITS_MULTIHDU.test.ts need to update because the header description may include the axes descriptions.

e.g.
Expected: "[830, 870]"
Received: "[830, 870] (Right Ascension, Declination)"

Based on the backend #1378, the frontend , and the protobuf updated
We need at least one test to measure sure this ICD message working fine.

Because now the backend PR#1270 can send the request tiles for the second matched image.
The document should be updated and the corresponding test should be changed.

Based on the backend PR#1229 and the frontend PR#2019, and the protobuf PR#80

• Design and add tests in the document
• implementation

Because the backend PR has updated the protobuf, the RASTER_TILE_DATA and RASTER_TILE_SYNC of some tests should be updated.

Based on the PR#2011 (frontend), PR#1194 (backend), and PR#77 (protobuf).

There is a small change in the FILEINFO_FITS_MULTIHDU.test.ts.

the old PV related ICD tests may need to modify

need to add new PV preview tests because we have new protobuf message

Because the Jenkins found the RESUME_CONTOUR.test.ts does not pass in all platform.
This part requires investigation.

Will review whether they should keep in the future.
someone may duplicate to the unit tests

• ACCESS_CARTA_DEFAULT.test.ts
• ACCESS_CARTA_DEFAULT_CONCURRENT.test.ts
• ACCESS_CARTA_KNOWN_SESSION.test.ts
• ACCESS_CARTA_NO_CLIENT_FEATURE.test.ts
• ACCESS_CARTA_SAME_ID_TWICE.test.ts
  ==================================
• CATALOG_FITS_VOT.test.ts (including catalog streaming)
• CATALOG_LARGE.test.ts
• CATALOG_GENERAL.test.ts (including catalog streaming)
  ==================================
• CLOSE_FILE_MULTI_FILES.test.ts
  ==================================
• CONCAT_ERROR_MESSAGE.test.ts
• CONCAT_STOKES_IMAGES.test.ts
• CONCAT_STOKES_IMAGES_AXIS_DEGENERACY.test.ts
  ==================================
• CONTOUR_DATA_STREAM.test.ts
• CONTOUR_IMAGE_DATA.test.ts
• CONTOUR_IMAGE_DATA_NAN.test.ts
• CONTOUR_CHANGE_SMOOTH_AND_DEMICATION_FACTOR.test.ts
  ==================================
• CURSOR_SPATIAL_PROFILE.test.ts
• CURSOR_SPATIAL_PROFILE_NaN.test.ts
• CURSOR_SPECTRAL_PROFILE.test.ts
• CURSOR_SPECTRAL_PROFILE_NaN.test.ts
  ==================================
• DS9_REGION_IMPORT_INTERNAL.test.ts
• DS9_REGION_INFO.test.ts
  ==================================
• SAVE_IMAGE_CHANNEL.test.ts
• SAVE_IMAGE_CHOP.test.ts
• SAVE_IMAGE_CHOP_SHARED.test.ts
• SAVE_IMAGE_DROP_DEG.test.ts
• SAVE_IMAGE_ERROR_MESSAGE.test.ts
• SAVE_IMAGE_ORIGINAL.test.ts
• SAVE_IMAGE_STOKES.test.ts
  ==================================
  FILEINFO_CASA.test.ts
  FILEINFO_CASA_VARIENTS.test.ts
  FILEINFO_FITS.test.ts
  FILEINFO_FITS_NONSTANDARD.test.ts
  FILEINFO_HDF5.test.ts
  FILEINFO_HDF5_COMPARE_FITS.test.ts
  FILEINFO_MIRIAD.test.ts
  FILETYPE_PARSER.test.ts
  ==================================
• FILE_LIST_PROGRESS_CANCELLATION.test.ts
• FILE_LIST_PROGRESS_COMPLETE.test.ts
  ==================================
• FITS_DS9_REGION_EXPORT_IMPORT_MATCHING.test.ts
• FITS_REGION_EXPORT_IMPORT_MATCHING.test.ts
  ==================================
• GET_FILELIST.test.ts
  ==================================
• IMPORT_MULTIPLE_CATALOG.test.ts
  IMPORT_MULTIPLE_IMAGE.test.ts duplicate to OPEN_IMAGE_APPEND.test.ts
• IMPORT_MULTIPLE_REGION.test.ts
  ==================================
• MATCH_SPATIAL.test.ts
• MATCH_SPECTRAL.test.ts
• MATCH_STATS.test.ts
• MATCH_STATS_BORDERLINE.test.ts
• MATCH_STATS_WIDE.test.ts
• MATCH_STATS_WIDE_BORDERLINE.test.ts
  ==================================
  MOMENTS_GENERATOR_PROFILE_STREAM.test.ts
  ==================================
• MULTI-SPECTRAL-PROFILE-IMAGE.test.ts
• MULTI-SPECTRAL-PROFILE-POLARIZATION.test.ts
• MULTI-SPECTRAL-PROFILE-REGION.test.ts
• MULTI-SPECTRAL-PROFILE-STATISTIC.test.ts
  ==================================
• OPENFILE_CASA_BEAMTABLE.test.ts
• OPENFILE_FITS_BEAMTABLE.test.ts
• OPEN_FITS_GZ.test.ts
• OPEN_IMAGE_APPEND.test.ts
• OPEN_IMAGE_CASA_VARIENTS.test.ts
• OPEN_IMAGE_PV.test.ts
  ==================================
• REGION_DATA_STREAM.test.ts (documentation link)
• REGION_HISTOGRAM.test.ts (documentation link)
• REGION_HISTOGRAM_ITERATION.test.ts
• REGION_REGISTER.test.ts (documentation link)
• REGION_SPECTRAL_PROFILE_ELLIPSE.test.ts (documentation link)
• REGION_SPECTRAL_PROFILE_POLYGON.test.ts
• REGION_SPECTRAL_PROFILE_RECTANGLE.test.ts
• REGION_SPECTRAL_PROFILE_STOKES.test.ts

Based on this backend PR, the FITTING* ICD related tests need to be update.

• IMAGE_FITTING_FITS.test.ts
• IMAGE_FITTING_CASA.test.ts
• IMAGE_FITTING_HDF5.test.ts
• IMAGE_FITTING_CANCEL.test.ts
• IMAGE_FITTING_BAD.test.ts

OPEN_SWAPPED_IMAGES.test.ts may cause the carta-backend crash with building the backend with Address Sanitizer backend flag. Without the Address Sanitizer flag, backend is alive.

Should be investigate this!

So far the long-term performance regression for each commit are running with old carta-backend-ICD-test.
Should be ready the RxJS based tests before v4 release.

I found the rawValuesFp64 calculation is not always the same.
Possible the decode the rawValuesFp64 to the number and compare the value directly.

I would like to migrate the performance test to RxJS version from release v4 (e315a6f0).

• PERF_LOAD_IMAGE_FITS.test.ts
• PERF_LOAD_IMAGE_CASA.test.ts
• PERF_LOAD_IMAGE_HDF5.test.ts
• PERF_RASTER_TILE_DATA_FITS.test.ts
• PERF_RASTER_TILE_DATA_CASA.test.ts
• PERF_RASTER_TILE_DATA_HDF5.test.ts
• PERF_CONTOUR_DATA_Mode0.test.ts
• PERF_CONTOUR_DATA_Mode1.test.ts
• PERF_CONTOUR_DATA_Mode2.test.ts
• PERF_CUBE_HISTOGRAM_FITS.test.ts
• PERF_CUBE_HISTOGRAM_CASA.test.ts
• PERF_CUBE_HISTOGRAM_HDF5.test.ts
• PERF_REGION_SPECTRAL_PROFILE_FITS.test.ts
• PERF_REGION_SPECTRAL_PROFILE_CASA.test.ts
• PERF_REGION_SPECTRAL_PROFILE_HDF5.test.ts
• PERF_ANIMATION_PLAYBACK_FITS.test.ts
• PERF_ANIMATION_PLAYBACK_CASA.test.ts
• PERF_ANIMATION_PLAYBACK_HDF5.test.ts
• PERF_MOMENTS_FITS.test.ts
• PERF_MOMENTS_CASA.test.ts
• PERF_MOMENTS_HDF5.test.ts
• PERF_PV_FITS.test.ts
• PERF_PV_CASA.test.ts
• PERF_PV_HDF5.test.ts

Because this frontend PR
We need to add one tile related test to test the condition that open two file and set channel and set stoke of inactive file.

• Documentation
• Implementation

Based on the Mark's new cube histogram PR.
protobuf PR
backend PR

There is a new sub-message under regionHistogramData(Stream), so we need at least one new ICD test to test this sub-message (modify the current ICD test is another option, I will check which way is better)

Because the fileID has been updated in the carta-backend
the corresponding tests: image fitting, PV, and moment should be updated
the functional message would be fine, the failures come from the new generated image (fileId)

Keep ICD-RxJS tests just check the protobuf messages: correction and execution time with different platforms
So remove Processed.ts from any branch and check rawValuesFp64 directly. Leave rawValuesFp64 => value checking work to the frontend unit tests.