carbonpackages / carbon.includeassets Goto Github PK

Add file extension *.mjs for rendering Javascript modules

I tried - successfully - to install Neos from scratch yesterday. The installation of a skeleton-site as recommended by the neos-team did not work though because the necessary helper-package carbon/includeassets cannot be installed for Neos 5.0

The same ConditionPrototype is called multiple times with the same params for each page resulting in the execution of the same queries. To optimise this, the result of the condition should be cached based on its parameters.

On my homepage that were 10 queries for Jonnitto.PrettyEmbedHelper:IncludeAssets.

My MacBook is in repair, so can't do a proper pull request right now.

The Readme line should be changed from

 # set in under `Carbon.IncludeAssets.Default.Path.inline`

to

 # set in under `Carbon.IncludeAssets.Default.Path.Inline.CSS`

This extensions works fine. Great job!!

But I'm missing browser specific includes like:

<!--[if lt IE 9]>
  <script src="_js/html5shiv-3.7.2.min.js"></script>
  <script src="_js/respond-1.4.2.min.js"></script>
<![endif]-->

Or ist there a possibility thats currently not described?

I have 2 css files, one with essential instructions - that I want to load regularly (blocking). One with additions, that I would like to load asynchronously (none-blocking). Is that possible?

Hey I just saw, that Google Fonts now supports variable fonts. This comes with an api change. The syntax & url has been modified to support more axis.

Currently the api endpoint is hardcoded here:

At the moment it leads to errors if you add a file with attributes. (If you use it with Flowpack.CacheBuster)