to start:

• rebase
• squash
• sawtooth

looks like this triggers a number (too many) of database lookups.

be suspicious of Investigator.investigate/1

an approximation of a proposal from @dopatraman

let's just do something really simple like "Funnel" in Arial bold for the header and a link to the repositories index on the homepage.

recheck all other branches' statuses instead of just failing all of them on push to default branch

Steps to reproduce:

1. Install funnel on a repo
2. Fork that repo to another person/organization
3. Make a properly rebased and squashed branch on the forked repo
4. Submit a PR from the forked repo to the original

Pretty sure Funnel will fail

See current status on #28 - I believe it's rebased and squashed.

https://github.com/direnv/direnv

While this tool is great, there are still several valid reasons for the Swell team to use the "lock-unlock" system in Slack. I wonder if it would be possible to streamline that process by adding a lock/unlock action button at the right of the funnel bar. If this would be a sensible amount of work, I would expect it to work like this:

1. If my PR has a green checkmark, and the lock is available, I can click on the lock action button to reserve the lock. This means that nobody else can merge to development while I have reserved the lock.
2. Once my PR is merged to development (even better if we check that CI passes), the lock is automatically unlocked.
3. Not necessary but maybe a nice to have: messaging to our #dev-status Slack channel.

https://github.com/keathley/wallaby

test:

• repositories interface
• login flow

basically, we need to be able to associate an installation with a GitHub user that can change settings stored on funnel for use with that installation.

google? github?

perhaps Investigator should be under Platter. they should definitely be grouped together somehow

proposed by @dopatraman

need a linode or a paid heroku dyno

would have to check a branch when its pushed to (assuming a pr is already open) and when a pr is opened or changed

add mix dialyzer to circleCI config

and make all the tests pass. this will require modifying many of the tentacat calls because the standard arguments order was changed to make client always be first

need a bunch of design first

maybe implement oauth?

This is a place to tell us about other things funnel could check for in a PR. Let us know what you would like to see!

http://www.phoenixframework.org/

i think i keep seeing my pr status get reevaluated when i make non-code changes to the pr

if there's a bug, its likely in https://github.com/carbonfive/funnel/blob/f0ab433e3d424955754e3eaed470ff4a567c616a/lib/funnel/investigator/helpers.ex#L55-57

we need to make sure that this function only returns true for "opened", "reopened", and "synchronize". and that Investigator is using that value to skip investigation when is_notable_action? returns false.

more context from the GitHub API docs: https://developer.github.com/v3/activity/events/types/#pullrequestevent