Portability to R 4.0 about mobster HOT 12 CLOSED

With no rush, we will have to check it works with a fresh install.

from mobster.

I get this error on R v4.0 FYI

Error: Failed to install 'mobster' from GitHub:
  (converted from warning) package ‘vcfR’ is not available (for R version 4.0.2)

Looks like vcfR will reappear on CRAN at some point (knausb/vcfR#165)

from mobster.

Hi @marcjwilliams1 ,
there's not much we can do to make the package available on CRAN however you can install vcfR directly from their github repository ( https://github.com/knausb/vcfR ) with the command:

devtools::install_github(repo="knausb/vcfR")
library(vcfR)

from mobster.

Yes, was just flagging in case this hadn't been spotted. vcfR doesn't look key so it could be moved to suggests and/or added to remotes if we want a clean install.

from mobster.

Thanks @marcjwilliams1 it makes sense. There is a number of packages that have really minor importance for mobster to work. This is one of those as it only help some pre-processing of VCF files. I wish there was (or I knew) some elegant way of declaring some packages are required, and others as optional in terms of dependencies...

from mobster.

@caravagn give me 5 minutes... http://r-pkgs.had.co.nz/description.html

from mobster.

@caravagn The suggests in the DESCRIPTION can work like this can't it?

Then in the load_vcf function you add something like:

    if (!requireNamespace("vcfR", quietly = TRUE)) {
      stop("Package \"vcfR\" needed for this function to work. Please install it.",
           call. = FALSE)
    }

from mobster.

Ah yes, this is what @luca-dex link says too...

from mobster.

Fantastic guys; are now master an development in synhc? I am using development locally ...

from mobster.

from mobster.

from mobster.

Already fixed

from mobster.