Giter Club home page Giter Club logo

Comments (7)

githubsaturn avatar githubsaturn commented on May 14, 2024 8

We wouldn't limit deployment architecture to git. We will have an adapter for github.

Answer to your second question is no. In fact, that's how I'm going to address the github deployment issue. Once implemented, it will work like this:

You push to github
Webhook calls captain saying a new commit is pushed
Captain pulls from github and build

from caprover.

josegonzalez avatar josegonzalez commented on May 14, 2024 1

Just wanted to chime in with a few thoughts:

  • Dokku isn't "limited to git". In fact, we support deploys of bare docker images and tarballs (alongside git). We just so happen to store the current state of your service within a repository on the server if you choose to push code via git.
  • You can support a "push to deploy" type system pretty easily using something like sshcommand. If you wanted to vendor such a thing into captainduckduck, the code is relatively simple and should be able to be ported into nodejs. Once you have a codebase on the server, it's relatively simple for you to extract a tarball and build from there, same as how captainduckduck currently works.

Great project btw, hope your users get excellent value from it :)

One of the Dokku maintainers

from caprover.

fergyfresh avatar fergyfresh commented on May 14, 2024

Look up dokku. We could probably modify this to be dokku like (docker-like heroku deploy)

from caprover.

githubsaturn avatar githubsaturn commented on May 14, 2024

Dokku is extremely limited to git. Most of the benefits that come with Captain is due to the fact that Captain is not limited to git. It uses git, but it's not limited to git. Things like deploy through web dashboard, one click apps and etc wouldn't have been possible if the architecture was limited to git. The last thing we want is limit ourselves to git like Dokku as that would mean losing everything else.

I guess what you meant was automatic deployment when you push to github, right? The good thing about Captain's generic REST API is that the requested feature is surely possible thorough some sort of adapter. I'll keep this issue open to see how many people actually need this! It requires some non-significant amount of work, so I'll put it in the queue if it's actually a feature that people need πŸ˜„

from caprover.

willwade avatar willwade commented on May 14, 2024

from caprover.

fergyfresh avatar fergyfresh commented on May 14, 2024

@githubsaturn but doesn't Github deployment also significantly limit this to git as well?

A random related question @githubsaturn Captain support event based triggers? Could we trigger a deploy on the Captain server via a Github webhook? Where-ish could I look for event based code? I'll look on my own, but if you get to it before I do any input would be great.

from caprover.

githubsaturn avatar githubsaturn commented on May 14, 2024

Thanks for your note and clarification. I'll look into sshcommand. Sounds viable.

from caprover.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.