The chess-game from canxkoz

chess-game's People

Contributors

Stargazers

Watchers

chess-game's Issues

a function that prevent moving out of board for all pieces.

Hello Jacob,
Why don't we create a function in the file that is extended by all of the pieces so that we can check if the movement is in bounds?

//checks to make sure that nextRow and nextCol are in bounds
		if (nextCol >= 7 || nextCol <= 0 || nextRow >= 7 || nextRow <= 0)
			return false;

		if (this.row == nextRow || this.col == nextCol) {
			ChessPiece piece = null;
			int d = (this.row == nextRow) ? nextCol : nextRow;

This is how you describe the bounds issue and I turned this into a function. (Took this from Rook.java)

Below is how I solve the problem:

/**
* Verify that piece is on board
* @param board
* @param nextRow
* @param nextCol
* @return
*/
public boolean isOnBoard(Board board, int nextRow, int toY){
/* Cannot move to position currently occupying */
        if(initialRow == nextRow && initialCol == nextCol){
	       return false;
}
/* Prevent moving out of Board */
          if(initialRow < 0 || initialCol < 0 || initialRow > 7 || initialCol > 7 || nextRow < 0 || nextCol < 0 || nextRow > 7 ||nextCol > 7){
	        return false;
}
	else return true;
}

do you think that we should do it your way by writing this for all pieces or shall we put this into the file that we extend?

Recommend Projects