Giter Club home page Giter Club logo

encrypt-cloud-image's People

Contributors

chrisccoulson avatar gjolly avatar ivanp-ms avatar jaskaran-khurana avatar jk-microsoft avatar xnox avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

encrypt-cloud-image's Issues

Typos in error message in main

There are two typos in the following error message:

Unsuppoted device path: %s. Please look at the code to deterimine what's currently supported

False detection of root partition.

In main.go we are discovering root partition by using filesystem guid, incase of migrating traditional server images which have efi boot root, the detection logic false detects boot as the root partition. Should we do something similar to https://www.freedesktop.org/software/systemd/man/systemd-gpt-auto-generator.html

///THis is doing false detection in main.go
root := partitions.FindByPartitionType(linuxFilesystemGUID)

@chrisccoulson could you please take a look at this ask, maybe we need to harden this check.
Scenario is we take a Ubuntu server image, remove grub and linux kernel and add the Ubuntu linux fde kernel package there, then run encryption tools on that image, it is detecting boot partition as root partition and encrypting that. I have moved detection logic to our service and pass uuid to the tools based on detection.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.