cani1see / betterpopupblocker Goto Github PK

Hi,

I'm working for a big social networking site where we log javascript exceptions 
happening in the user's browser.
In the past weeks one strange js error caught our attention:
"Uncaught TypeError: Property 'scrollTo' of object [object DOMWindow] is not a 
function"

The strange thing about this error is that it only appeared in Chrome.
After some investigation I found this extension which seems to be the cause for 
this error.

In line #100 of blockStart.js a bunch of javascript functions (including 
window.scrollTo) is set to 'null'.
I can fully understand that unsetting those variables makes sense.

The only problem I have is that the type of the variable is changed which leads 
to javascript exceptions and prevents other "non-annoying" functionality from 
being executed.

Imagine this piece of code:
doSomething();
window.scrollTo(0, 0); // <-- not a function, therefore causes a js exception
doSomethingElseImportant(); // <-- will never be executed when window.scrollTo 
is null

If the extension is enabled the "doSomethingElseImportant()" will never be 
executed since the window.scrollTo method throws a js error which stops 
javascript execution at that point.

Would be really helpful if the "Better PopUp Blocker" would preserve the 
original type.
So instead of setting all those javascript functions to null, it would make 
more sense to set them to an empty function. "window.scrollTo=function(){};"

Thanks!

Christopher

What steps will reproduce the problem?
1. install on latest safari
2. no icon for settings
3.

What is the expected output? What do you see instead?

expect icon to set up exceptions.

What version of the product are you using? On what operating system?
 lion/safari 5.1.4

Please provide any additional information below.

What steps will reproduce the problem?
1. block escape and uneval
2. go to a page that uses it (such as the messages system at deviantart.com)

What is the expected output? What do you see instead?
it should block the code using whatever awesome magic you provided.

it works as advertised. however you cant tell when it is working, and you can't 
whitelist sites for this function. that makes a lot of sites look broken that 
are not. the alternative, not using the option, is less attractive than 
offering a toggle for the effect and a whitelist. 

ideally it would try to detect the effect in action but thats kinda hard to do 
(background incognito page reload without the option when there is a javascript 
error and see if the error is the same?) but at least a whitelist and an on/off 
toggle would be nice

-- hey I dumped a lot of comments today .. I really like this plugin and I 
don't want to ask too much. I'll shut up now :D

What icons would I like to replace?
1. icon_forbidden / default icons:
<svg width="600" height="525" xmlns="http://www.w3.org/2000/svg">
 <g>
  <title>forbidden</title>
  <g id="svg_1">
   <path id="svg_2" d="m598.299988,499.600006l-283.799988,-491.600006c-2.899994,-5 -8.200012,-8 -13.899994,-8c-5.700012,0 -11,3.1 -13.899994,8l-283.800022,491.600006c-2.9,5 -2.9,11.100006 0,16.000031c2.9,5 8.2,8 13.9,8h567.599974c5.700012,0 11,-3.100037 13.900024,-8c2.900024,-5.000031 2.900024,-11.100037 0,-16.000031z"/>
   <polygon id="svg_3" fill="#ff0" points="44.599999248981476,491.5 300.5999878048897,48.20000076293945 556.5999878048897,491.5 "/>
   <path id="svg_4" d="m280.599976,378.299988l-46.799973,81.100006c42.599991,24.600006 91.099991,24.600006 133.699997,0l-46.800018,-81.100006c-0.299988,0.200012 -0.600006,0.400024 -0.899994,0.600006c-1.100006,0.600006 -2.299988,1.200012 -3.5,1.700012c-1.200012,0.5 -2.399994,1 -3.700012,1.399994c-1.299988,0.399994 -2.5,0.700012 -3.799988,1c-1.299988,0.299988 -2.600006,0.5 -4,0.600006c-1.299988,0.100006 -2.700012,0.199982 -4.100006,0.199982c-1.399994,0 -2.699982,-0.099976 -4.100006,-0.199982c-1.299988,-0.100006 -2.699982,-0.300018 -4,-0.600006c-1.299988,-0.299988 -2.599976,-0.600006 -3.799988,-1c-1.299988,-0.399994 -2.5,-0.799988 -3.700012,-1.399994c-1.199982,-0.5 -2.399994,-1.100006 -3.5,-1.700012c-0.399994,-0.199982 -0.699982,-0.399994 -1,-0.600006z"/>
   <path id="svg_5" d="m233.800003,227.800003c-42.600006,24.599991 -66.800003,66.599991 -66.800003,115.800003h93.599976c0,-1.399994 0.100006,-2.799988 0.200012,-4.100006c0.100006,-1.299988 0.399994,-2.699982 0.600006,-4c0.299988,-1.299988 0.600006,-2.599976 1,-3.799988c0.399994,-1.299988 0.799988,-2.5 1.399994,-3.700012c0.5,-1.199982 1.100006,-2.399994 1.700012,-3.5c0.599976,-1.099976 1.299988,-2.199982 2,-3.299988c0.699982,-1.100006 1.5,-2.100006 2.299988,-3.100006c0.799988,-1 1.700012,-1.899994 2.600006,-2.799988c0.899994,-0.899994 1.899994,-1.800018 2.899994,-2.600006c1,-0.799988 2,-1.600006 3.100006,-2.299988c0.799988,-0.5 1.600006,-1 2.399994,-1.5l-46.999985,-81.100021z"/>
   <path id="svg_6" d="m367.5,227.800003l-46.799988,81.099991c0.799988,0.5 1.599976,0.899994 2.399994,1.5c1.100006,0.700012 2.100006,1.5 3.100006,2.300018c1,0.799988 1.899994,1.699982 2.899994,2.599976c0.899994,0.900024 1.799988,1.900024 2.600006,2.800018c0.799988,1 1.599976,2 2.299988,3.100006c0.700012,1.099976 1.399994,2.199982 2,3.299988c0.600006,1.100006 1.200012,2.299988 1.700012,3.5c0.5,1.200012 1,2.399994 1.399994,3.700012c0.399994,1.299988 0.699982,2.5 1,3.799988s0.5,2.600006 0.600006,4c0.099976,1.299988 0.199982,2.700012 0.199982,4.100006h93.600006c-0.200012,-49.200012 -24.400024,-91.200012 -67,-115.800003z"/>
   <circle id="svg_7" cx="300.6" cy="343.6" r="26.699997"/>
  </g>
 </g>
</svg>
2. icon_forbidden_blocked
<svg width="600" height="525" xmlns="http://www.w3.org/2000/svg">
 <g>
  <title>forbidden blocked</title>
  <g id="svg_1">
   <path id="svg_2" d="m598.299988,499.600006l-283.799988,-491.600006c-2.899994,-5 -8.200012,-8 -13.899994,-8c-5.700012,0 -11,3.1 -13.899994,8l-283.800022,491.600006c-2.9,5 -2.9,11.100006 0,16.000031c2.9,5 8.2,8 13.9,8h567.599974c5.700012,0 11,-3.100037 13.900024,-8c2.900024,-5.000031 2.900024,-11.100037 0,-16.000031z"/>
   <polygon id="svg_3" fill="#ff0000" points="44.599999248981476,491.5 300.5999878048897,48.20000076293945 556.5999878048897,491.5 "/>
   <path id="svg_4" d="m280.599976,378.299988l-46.799973,81.100006c42.599991,24.600006 91.099991,24.600006 133.699997,0l-46.800018,-81.100006c-0.299988,0.200012 -0.600006,0.400024 -0.899994,0.600006c-1.100006,0.600006 -2.299988,1.200012 -3.5,1.700012c-1.200012,0.5 -2.399994,1 -3.700012,1.399994c-1.299988,0.399994 -2.5,0.700012 -3.799988,1c-1.299988,0.299988 -2.600006,0.5 -4,0.600006c-1.299988,0.100006 -2.700012,0.199982 -4.100006,0.199982c-1.399994,0 -2.699982,-0.099976 -4.100006,-0.199982c-1.299988,-0.100006 -2.699982,-0.300018 -4,-0.600006c-1.299988,-0.299988 -2.599976,-0.600006 -3.799988,-1c-1.299988,-0.399994 -2.5,-0.799988 -3.700012,-1.399994c-1.199982,-0.5 -2.399994,-1.100006 -3.5,-1.700012c-0.399994,-0.199982 -0.699982,-0.399994 -1,-0.600006z"/>
   <path id="svg_5" d="m233.800003,227.800003c-42.600006,24.599991 -66.800003,66.599991 -66.800003,115.800003h93.599976c0,-1.399994 0.100006,-2.799988 0.200012,-4.100006c0.100006,-1.299988 0.399994,-2.699982 0.600006,-4c0.299988,-1.299988 0.600006,-2.599976 1,-3.799988c0.399994,-1.299988 0.799988,-2.5 1.399994,-3.700012c0.5,-1.199982 1.100006,-2.399994 1.700012,-3.5c0.599976,-1.099976 1.299988,-2.199982 2,-3.299988c0.699982,-1.100006 1.5,-2.100006 2.299988,-3.100006c0.799988,-1 1.700012,-1.899994 2.600006,-2.799988c0.899994,-0.899994 1.899994,-1.800018 2.899994,-2.600006c1,-0.799988 2,-1.600006 3.100006,-2.299988c0.799988,-0.5 1.600006,-1 2.399994,-1.5l-46.999985,-81.100021z"/>
   <path id="svg_6" d="m367.5,227.800003l-46.799988,81.099991c0.799988,0.5 1.599976,0.899994 2.399994,1.5c1.100006,0.700012 2.100006,1.5 3.100006,2.300018c1,0.799988 1.899994,1.699982 2.899994,2.599976c0.899994,0.900024 1.799988,1.900024 2.600006,2.800018c0.799988,1 1.599976,2 2.299988,3.100006c0.700012,1.099976 1.399994,2.199982 2,3.299988c0.600006,1.100006 1.200012,2.299988 1.700012,3.5c0.5,1.200012 1,2.399994 1.399994,3.700012c0.399994,1.299988 0.699982,2.5 1,3.799988s0.5,2.600006 0.600006,4c0.099976,1.299988 0.199982,2.700012 0.199982,4.100006h93.600006c-0.200012,-49.200012 -24.400024,-91.200012 -67,-115.800003z"/>
   <circle id="svg_7" cx="300.6" cy="343.6" r="26.699997"/>
  </g>
 </g>
</svg>
3. icon_allowed
<svg width="600" height="525" xmlns="http://www.w3.org/2000/svg">
 <g>
  <title>allowed</title>
  <g id="svg_1">
   <path id="svg_2" d="m598.299988,499.600006l-283.799988,-491.600006c-2.899994,-5 -8.200012,-8 -13.899994,-8c-5.700012,0 -11,3.1 -13.899994,8l-283.800022,491.600006c-2.9,5 -2.9,11.100006 0,16.000031c2.9,5 8.2,8 13.9,8h567.599974c5.700012,0 11,-3.100037 13.900024,-8c2.900024,-5.000031 2.900024,-11.100037 0,-16.000031z"/>
   <polygon id="svg_3" fill="#00ff00" points="44.599999248981476,491.5 300.5999878048897,48.20000076293945 556.5999878048897,491.5 "/>
   <path id="svg_4" d="m280.599976,378.299988l-46.799973,81.100006c42.599991,24.600006 91.099991,24.600006 133.699997,0l-46.800018,-81.100006c-0.299988,0.200012 -0.600006,0.400024 -0.899994,0.600006c-1.100006,0.600006 -2.299988,1.200012 -3.5,1.700012c-1.200012,0.5 -2.399994,1 -3.700012,1.399994c-1.299988,0.399994 -2.5,0.700012 -3.799988,1c-1.299988,0.299988 -2.600006,0.5 -4,0.600006c-1.299988,0.100006 -2.700012,0.199982 -4.100006,0.199982c-1.399994,0 -2.699982,-0.099976 -4.100006,-0.199982c-1.299988,-0.100006 -2.699982,-0.300018 -4,-0.600006c-1.299988,-0.299988 -2.599976,-0.600006 -3.799988,-1c-1.299988,-0.399994 -2.5,-0.799988 -3.700012,-1.399994c-1.199982,-0.5 -2.399994,-1.100006 -3.5,-1.700012c-0.399994,-0.199982 -0.699982,-0.399994 -1,-0.600006z"/>
   <path id="svg_5" d="m233.800003,227.800003c-42.600006,24.599991 -66.800003,66.599991 -66.800003,115.800003h93.599976c0,-1.399994 0.100006,-2.799988 0.200012,-4.100006c0.100006,-1.299988 0.399994,-2.699982 0.600006,-4c0.299988,-1.299988 0.600006,-2.599976 1,-3.799988c0.399994,-1.299988 0.799988,-2.5 1.399994,-3.700012c0.5,-1.199982 1.100006,-2.399994 1.700012,-3.5c0.599976,-1.099976 1.299988,-2.199982 2,-3.299988c0.699982,-1.100006 1.5,-2.100006 2.299988,-3.100006c0.799988,-1 1.700012,-1.899994 2.600006,-2.799988c0.899994,-0.899994 1.899994,-1.800018 2.899994,-2.600006c1,-0.799988 2,-1.600006 3.100006,-2.299988c0.799988,-0.5 1.600006,-1 2.399994,-1.5l-46.999985,-81.100021z"/>
   <path id="svg_6" d="m367.5,227.800003l-46.799988,81.099991c0.799988,0.5 1.599976,0.899994 2.399994,1.5c1.100006,0.700012 2.100006,1.5 3.100006,2.300018c1,0.799988 1.899994,1.699982 2.899994,2.599976c0.899994,0.900024 1.799988,1.900024 2.600006,2.800018c0.799988,1 1.599976,2 2.299988,3.100006c0.700012,1.099976 1.399994,2.199982 2,3.299988c0.600006,1.100006 1.200012,2.299988 1.700012,3.5c0.5,1.200012 1,2.399994 1.399994,3.700012c0.399994,1.299988 0.699982,2.5 1,3.799988s0.5,2.600006 0.600006,4c0.099976,1.299988 0.199982,2.700012 0.199982,4.100006h93.600006c-0.200012,-49.200012 -24.400024,-91.200012 -67,-115.800003z"/>
   <circle id="svg_7" cx="300.6" cy="343.6" r="26.699997"/>
  </g>
 </g>
</svg>

What size are these SVGs? How can I resize them?
They are all 600x525. You can resize them by changing the first line's width 
and height, and adding the property transform="scale( [myScale] )". For 
example, to transform to a 128 pixel size, set the width to 128 and the height 
to 128/600 * 525 = 112, and add the transform with myScale = 128/600 = 0.213333.


How can I convert an SVG to PNG or some other format?
Any non-trivial iomage editor program aught to do.

Please provide any additional information below.

I hope you dont mind the playfulness of the response. I like this program and 
hope to see the icons soon. I might just gerry-rig my version on my machine if 
I can figure that out.. but I basically cant do any code or work with such a 
minimal computer as I have, so I was hoping the SVGs would suffice.  Please 
feel free to jot me a note.

What steps will reproduce the problem?
1. go to Manage extensions: chrome://extensions/

What is the expected output? What do you see instead?
no icon in the omnibar
instead: icon in the omnibar

What version of the product are you using? On what operating system?
2.1.6 on Vista and Chrome 11.0.696.60

Please provide any additional information below.

Extensions aren't allowed to work on some pages anyway, and the plugin 
shouldn't show the icon on these pages. Anything beginning with chrome:// for 
example. (You're not the only one guilty of this — I've seen official by 
google code doing this from time to time.)

What steps will reproduce the problem?
1. Make these settings for Better Popup Blocker
[true] Blink the extension icon when a pop up window is blocked
[false] Show action button in URL bar for Better Pop Up Blocker (Will take 
effect on new page loads)
2. go to the test page to see a blocked popup

What is the expected output? What do you see instead?
icon appears and blinks, then remains on the omnibar until the url changes.

instead: icon appears and blinks, disappearing once the blink cycle is complete.

What version of the product are you using? On what operating system?
2.1.6 on Vista and Chrome 11.0.696.60

What steps will reproduce the problem?
1. Go to Chrome Store
2. Search Better Pop-up blocker
3. Not found

What is the expected output? What do you see instead?
I expected it to be there... it was not.

What version of the product are you using? On what operating system?
2.16 Windows 7

Please provide any additional information below.
I really like this and have it on almost all of my computers... but now it is 
not available to install ... please make it available again...

What steps will reproduce the problem?
1. go to http://support.ts.fujitsu.com/de/support/downloads.html
2. whitelist the page
3. try to select a product, for example: Notebooks --> Amilo --> Amilo Xa --> 
Amilo Xa 2528

What is the expected output? What do you see instead?
The Driver Download section should open.
Only the navigation of the page, not the content.

What version of the product are you using? On what operating system?
Version: 2.1.6,
Chrome: 13.0.782.112
OS: Win 7

Please provide any additional information below.
The Example page uses frames with iframes in it. At a first glance the inner 
iframe tries to load the page via JS Command "open('../123.asp')", which seems 
to be blocked, even if the page is whitelisted.