The current form view handles many types of requests:

• it displays the initial form,
• it inserts the form data in the database (after confirmation)
• it just validates the form data when the user goes from one step to another
• it stores the form data in the session after submission but before confirmation

The code is complex, and inflexible. For example we want to support the following use-cases:

• it should be possible to create forms without multi-step
• it should be possible to create forms without the confirmation page (a.k.a. "two-step submission")
• it should be possible to redirect to a custom read-only view after submission

This requires somehow untangling that view, and split it into multiple functions/views.

At some point we'll need to handle database migrations. We'll use Alembic for that.

When a date field is defined as not null in database, the interface does not take it into account (it is allowed to let the field blank). See the two dates in the first page of https://preprod.cartoriviera.ch/c2cgeoform/wsgi/fouille/form

Following on #9 we should add a test Makefile target that runs the automated test suite.

• Support projections: database vs. map projection
• Deform map: draw and modify controls
• Support for read-only

That use-case: users of a given role do not need to see fields that are specific to other roles. We think this can be implemented by the application administrator in the form template. Per-role classes can be used in the HTML. And a select element displaying and hiding fields based on the selected role.

This should be implemented in the pully example.

The link to an example model in the first README sentence is invalid: it leads to https://github.com/camptocamp/c2cgeoform/blob/master/c2cgeoform/pully/model.py

"c2cgeoform is a framework easing the creation of web pages with forms. Users of c2cgeoform declaratively create models (example), from which the framework can create forms, views, lists, …"

Test if a map can be used in a sub-form (e.g. in a relation). Maybe the map will not be initialized properly if a new entity is added in the form (with "Add Contact" for example).

#89 required a change to ColanderAlchemy. That change is merged into ColanderAlchemy's master branch, but there's no new release yet. When ColanderAlchemy 0.3.2 is released we need to use ColanderAlchemy >= 0.3.2 in setup.py.

The initializedb command fails for me on my development environment:

sqlalchemy.exc.ProgrammingError: (ProgrammingError) column "locationposition" does not exist
 'CREATE INDEX "idx_excavations_locationPosition" ON "public"."excavations" USING GIST (locationPosition)' {}

So the failure occurs on the creation of the index for the locationPosition geometry column.

If I copy the CREATE INDEX SQL query in psql I get the same error. And if I add double-quotes around locationPosition in the query the error is gone. This may be a bug in GeoAlchemy.

Maybe use reCAPTCHA: https://gist.github.com/reedobrien/701444

Following up on #9 we need to set up Travis CI for the project.

The grid and index methods should return a non-cacheable response.
Currently it specifies no caching strategy.

Ping @llienher, @sbrunner.

At the moment, we have Mako and Chameleon templates in our project: Mako templates for the page templates and Chameleon templates for the map widget and the form.
Originally we wanted to use Mako because the prospective users are already familiar with Mako. Deform uses Chameleon, that's why the map widget is written with Chameleon.

PR #15 showed how to customize the form by overriding the Deform form template. This form template is also a Chameleon template. But because overriding the form template is the envisaged way to customize the form, we would force the users to write templates in Mako AND in Chameleon. We should try to only have one template language.

I see two possibilities:

Only Chameleon templates
+ We would have to convert the existing Mako templates, but this is no big deal.
+ Deform is still our friend.
- Users will have to learn Chameleon.

Only Mako templates
+ Maybe easier for the users.
- We will have to force Deform to use Mako for the form template (and maybe also for the map widget), but to continue using Chameleon for all other field widgets (so that we don't have to port all templates).
- If a user wants to customize a field (for example the date picker), he/she would still have to deal with Chameleon.

I would go with Chameleon only.

This issue is about making it possible to fill a form in multiple steps, with some sort of wizard. One potential option is to use jQuery Steps.

• Use pep8-naming plugin: https://pypi.python.org/pypi/pep8-naming
• Rename database table field names

It looks like only themes.css is used.

A boolean field with specific text.

Like in camptocamp/c2cgeoportal#3827
Note that in c2cgeoportal admin case some dependencies / pyramid config may be given by c2cwsgiutils.

Right now the developer-guide includes a section about Session management configuration. It should not be in the developer-guide as this is an information for the application developer.

Currently the forms list just includes the form ids. This is not enough information/context to be able to identify forms in the list.

This is to comply with OSM's terms of use.

It could be good to add a css_class property on ListField class :
https://github.com/camptocamp/c2cgeoform/blob/master/c2cgeoform/views/abstract_views.py#L48

As it is possible for widgets :
https://github.com/Pylons/deform/blob/master/deform/templates/textinput.pt#L6

Or to prefix field names in css class, example : column-label.

• Add more comments to the example
• Improve documentation
  • The basic idea
  • Creating the model
    • hash-column
    • colander property: Deform widgets, Colander validators
    • map widget
  • The views provided by c2cgeoform
    • Overriding the site and widget templates
  • Creating a project with c2cgeoform
• Improve c2cgeoform documentation a bit

For Pully we would like to introduce a two-step submission, where the user gets a confirmation page before actually submitting his form. The confirmation page includes a read-only view of the form and a checkbox that must be checked for submitting the form.

In form template ${myvar} with utf8 string throw errors.
Should'nt they supposed to be utf8 by default.
we use ${myvar.decode('utf-8')} as a workaround.

https://groups.google.com/forum/#!msg/pylons-discuss/GYc-T2AAn74/i-ulDCdKsAUJ

Traceback (most recent call last):
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/waitress-0.8.9-py2.7.egg/waitress/channel.py", line 337, in service
task.service()
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/waitress-0.8.9-py2.7.egg/waitress/task.py", line 173, in service
self.execute()
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/waitress-0.8.9-py2.7.egg/waitress/task.py", line 392, in execute
app_iter = self.channel.server.application(env, start_response)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid-1.5.1-py2.7.egg/pyramid/router.py", line 242, in call
response = self.invoke_subrequest(request, use_tweens=True)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid-1.5.1-py2.7.egg/pyramid/router.py", line 217, in invoke_subrequest
response = handle_request(request)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid_debugtoolbar-2.2-py2.7.egg/pyramid_debugtoolbar/toolbar.py", line 165, in toolb
ar_tween
return handler(request)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid-1.5.1-py2.7.egg/pyramid/tweens.py", line 21, in excview_tween
response = handler(request)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid_tm-0.7-py2.7.egg/pyramid_tm/init.py", line 82, in tm_tween
reraise(_exc_info)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid_tm-0.7-py2.7.egg/pyramid_tm/init.py", line 63, in tm_tween
response = handler(request)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid-1.5.1-py2.7.egg/pyramid/router.py", line 163, in handle_request
response = view_callable(context, request)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid-1.5.1-py2.7.egg/pyramid/config/views.py", line 377, in rendered_view
context)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid-1.5.1-py2.7.egg/pyramid/renderers.py", line 418, in render_view
return self.render_to_response(response, system, request=request)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid-1.5.1-py2.7.egg/pyramid/renderers.py", line 441, in render_to_response
result = self.render(value, system_values, request=request)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid-1.5.1-py2.7.egg/pyramid/renderers.py", line 437, in render
result = renderer(value, system_values)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/pyramid_chameleon-0.3-py2.7.egg/pyramid_chameleon/zpt.py", line 47, in call
result = self.template(__system)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/Chameleon-2.16-py2.7.egg/chameleon/template.py", line 123, in call
return self.render(__kwargs)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/Chameleon-2.16-py2.7.egg/chameleon/zpt/template.py", line 258, in render
return super(PageTemplate, self).render(__vars)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/Chameleon-2.16-py2.7.egg/chameleon/template.py", line 188, in render
raise_with_traceback(exc, tb)
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/Chameleon-2.16-py2.7.egg/chameleon/template.py", line 170, in render
self._render(stream, econtext, rcontext)
File "form_ef67fe0b2dabab19a29176a33a82da3b.py", line 129, in render
File "/home/amorvan/pullymorges_dpfe/geoform/.build/venv/local/lib/python2.7/site-packages/Chameleon-2.16-py2.7.egg/chameleon/zpt/template.py", line 262, in include
self._render(_args, **kwargs)
File "site_658ecdaad617d9582f8c1232b810651b.py", line 222, in render
File "site_658ecdaad617d9582f8c1232b810651b.py", line 82, in __quote
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 38: ordinal not in range(128)

• Stream: ... des de permis de fouilles et empiétements
  ^
• Expression: "${request.registry.settings['title']} - ${request.registry.settings['subtitle']}"
• Filename: ... van/pullymorges_dpfe/geoform/dpfe/templates/site/site.pt
• Location: (line 9: col 11)
• Source: ... ${request.registry.settings['title']} - ${request.registry.settings['subtitle']} ...
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
• Arguments: repeat: {...} (0)
  renderer_name: templates/site/form.pt
  deform_dependencies: {...} (2)
  form: \n

  Commune de Pully

  \n

  Filing a request fo...
  localizer: <Localizer - at 0x2e39290>
  site: <PyramidPageTemplateFile - at 0x3056b10>
  renderer_info: <RendererHelper - at 0x2be5b10>
  _: <function auto_translate at 0x2bba758>
  req: <Request - at 0x2ae4dd0>
  request: <Request - at 0x2ae4dd0>
  context: <instance None at 0x2e3ab90>
  view: <function form at 0x2be82a8>

• Make fields that are shown configurable (for example with a property admin_list: True)
• Add pagination
• Make columns sortable
• Add search

Once a new version of Deform is released, which contains this PR Pylons/deform#243, we can do the following change in views.py:

Replace

 except ValidationFailure, e:
    # FIXME see https://github.com/Pylons/deform/pull/243
    rendered = e.field.widget.serialize(
    e.field, e.cstruct, custom_data=custom_data)

with

 except ValidationFailure, e:
    rendered = e.serialize(custom_data=custom_data)

Currently c2cgeoform supports two user profiles only: user and admin. There are use-cases where other profiles may be needed. Profiles are an application-specific thing. c2cgeoform should allow using any number and any type of profiles. In particular it should be possible to assign a user profile to a field, and c2cgeoform could provide a function that creates a Form for a given profile.

Currently, an application that uses c2cgeoform (config.include('c2cgeoform')) gets the c2cgeoform views and routes. This is because the c2cgeoform views and routes are defined in c2cgeoform's includeme function. So if some views/routes are unwanted in an application then they must be explicitly removed. See dpfe project for example. Instead, the use of the c2cgeoform views should optional.

http://mapfish-geoportal.demo-camptocamp.com/c2cgeoform/wsgi/fouille/form/

http://mapfish-geoportal.demo-camptocamp.com/c2cgeoform/wsgi/fouille/

Would be great to have a few printscreens?

Colander documentation's "Extending Colander" chapter says that "The cstruct_children method became required in Colander 0.9.9.". So our colander_ext.Geometry type should probably implement that method.

• in templates
• in the model: field labels/descriptions

After the update to 14.04 I had to install the following packages to make it work:

postgresql-server-dev-9.3
python-dev

File upload fields should be supported. Deform 2 has a file upload widget, but we need to verify that colander and colander-alchemy also support that type.

We need to enforce the use of deform 2.0a2.

Custom templates

• Test server
• mod_wsgi config
• requirements.txt
• build file
• Travis CI

See https://github.com/camptocamp/c2cgeoform/pull/16/files#r15748141

How to change the main templates (site, list, form, edit)?

If one clicks on a map to draw a point, the resulting point is not shown.

Most probably (tested...), because no style for point objects is defined here:
https://github.com/camptocamp/c2cgeoform/blob/master/c2cgeoform/templates/widgets/map.pt#L41-L50

Currently after form submission we just display a new page including a read-only view of the form. For more flexibility, and to avoid re-submitting the form data when the user reloads the page, we should use a redirect (HTTPFound). The page we redirect to will have its own view and template. In this way the application developer will be able to customize the view and the template.

This issue is related to #51 which is invalid because the read-only view we have currently is "admin only".