camphul / coinmarketcap-api Goto Github PK

Coinmarketcap is now charging for API. You can consider using CoinGecko API instead: https://www.coingecko.com/api/docs/v3

When I invoke CoinMarketList.sort() in my code, I saw exception:

java.lang.UnsupportedOperationException
	at java.util.Collections$UnmodifiableList.sort(Collections.java:1331)
	at com.lucadev.coinmarketcap.model.CoinMarketList.sort(CoinMarketList.java:133)

Then I found what it does in sort:

@Override public void sort(Comparator<? super CoinMarket> comparator) { marketList.sort(comparator); }

However marketList is an UnmodifiableList as it is instantiated by this.marketList = Collections.unmodifiableList(new ArrayList<>(markets));

Hi Lucas

nice job, thx !
I would be interested but i wonder why the api doesn't produce json formatted result like this:

{
"PriceQuote": {
"price": 7094.8268024,
"dayVolume": 3.9292290664E9,
"marketCap": 1.20927151089E11,
"hourChange": 0.28,
"dayChange": 0.45,
"weekChange": -3.03
}
}

It would be much easier to automatically deserialize the response in a java program !

MrIzi

Your API looks nice, and it would reduce the friction between the user and the library if the artifact were released in a binary repository (either MavenCentral or JCenter).

Exception in thread "main" javax.ws.rs.client.ResponseProcessingException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "attention" (class com.lucadev.coinmarketcap.model.CoinListingsApiResponse), not marked as ignorable (2 known properties: "data", "metadata"])
at [Source: org.glassfish.jersey.message.internal.ReaderInterceptorExecutor$UnCloseableInputStream@6d7fc27; line: 12629, column: 2] (through reference chain: com.lucadev.coinmarketcap.model.CoinListingsApiResponse["attention"])

After installing the library, i tried to test it but the following errors popped out.

Exception in thread "main" javax.ws.rs.client.ResponseProcessingException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "attention" (class com.lucadev.coinmarketcap.model.CoinMarketListApiResponse), not marked as ignorable (2 known properties: "data", "metadata"])
......

The fix is to add Jackson's class-level annotation to ignore non declared property at the CoinMarketListApiResponse file.

The Public API will be migrating to the new, more powerful Professional API on December 4th, 2018. Please update your application to use the free tier of the Professional API before then.

Any plan for supporting Pro API ?

In case if Jersey dependencies will be managed to version 2.26 we have this exception:

ava.lang.NullPointerException: null
	at com.lucadev.coinmarketcap.GlobalTicker.get(GlobalTicker.java:71)
	at ....refresh(....java:16)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.springframework.scheduling.support.ScheduledMethodRunnable.run(ScheduledMethodRunnable.java:65)
	at org.springframework.scheduling.support.DelegatingErrorHandlingRunnable.run(DelegatingErrorHandlingRunnable.java:54)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

As an example of when this may be the problem is when we are using Spring Boot 2.0.0.RELEASE as maven parent, in this case many popular dependencies including Jersey are managed to latest stable versions.

As temporary workaround we can change version of Jersey dependencies back to 2.25.1 and then we will don't have this exception.