Giter Club home page Giter Club logo

Comments (5)

calumryan avatar calumryan commented on August 19, 2024 1

Thanks, that's fixed it now to scale much better in all cases for resize, zoom level consistently without any overflow.

Updated with overall AA grade 🎉

from a11ywebsites.

tunetheweb avatar tunetheweb commented on August 19, 2024

@calumryan many thanks for reviewing the site and for identifying the reflow issues on large text and smaller viewports. I’ve just pushed a fix that I believe addresses this, but would be very keen to hear if this is not the case. Thanks again for running the site and for featuring us!

from a11ywebsites.

calumryan avatar calumryan commented on August 19, 2024

That's improved for 320 pixels. Still some issues at around 1000 pixels wide as demonstrated here with the dropdown open it causes a reflow issue.

Screenshot 2021-02-22 at 21 20 51

from a11ywebsites.

tunetheweb avatar tunetheweb commented on August 19, 2024

Thanks for looking again.

I can see what happened here: it decides the left/right hang on menu open based on whether it will overflow the screen. So can overflow if you zoom or change browser width while it's open - if you closed it and then reopened it again it would stop overflowing. Or if you'd opened it after zooming or changing size it would also not have been an issue. So a bit of an edge case, I hadn't fully considered. I added an onresize call to check this again and rehang it if necessary.

I also decided to change to em-based media queries as felt the desktop view wasn't the ideal view at those very large base font sizes except on really wide screen. So we go to mobile view more often which makes this issue less likely to happen - but still, the functionality is in there for when it does.

Both those changes are released now.

from a11ywebsites.

tunetheweb avatar tunetheweb commented on August 19, 2024

Thanks @calumryan for the time you spent on this and for helping improve our site!

from a11ywebsites.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.