callumacrae / jscolor Goto Github PK

I noticed that the jscolor I get when using bower install ("bower install JSColor --save") does not work on the following element:

<p>Color: <input id="background-color" class="jscolor {onFineChange:'updateBackground(this)'}" value="6A9AAB"></p>

Which should be valid + works with the minified version I got from the site (the zip you can download from http://jscolor.com/)

I debugged it and saw that in this line in bind():

if(!e[i].color && e[i].className && (m = e[i].className.match(matchClass))) {

It fails on the condition:

e[i].className.match(matchClass)

So I compared this part with the minified version I had from the site (I edited the names etc in the minified so it will be easier to compare):

var matchClass =    new RegExp('(^|\\s)('+jscolor.bindClass+')\\s*(\\{[^}]*\\})?', 'i');   // from bower
var r =             new RegExp('(^|\\s)('+jscolor.bindClass+')(\\s*(\\{[^}]*\\})|\\s|$)','i');  // minified

as you can see the regex is slightly different which I guess is the problem.

tl;dr

The bower version of jscolor have a wrong regex that don't identify valid input fields that are shown as examples in the site and are successfully identified by the (probably older) minified zip version.

Awesome lib btw 👍

Thanks!