cadixdev / bombe Goto Github PK

Currently, JarEntryRemappingTransformer uses the full path of class files to map their names. This works fine for normal jars where the class name is relative to the jar root, but does not work for multi-release jars where the class name is relative to the META-INF/versions/<n>/ directory.

The actual fix for this should be fairly straightforward, but for other API users it would be nice to integrate some of that handling into the JarClassEntry API (exposing whether a class is a multi-release variant, and a way to get/set the class name no matter how it is located).

If a consumer calls TypeReader#readObjectType() directly - they may inadvertantly read a malformed input.

    public ObjectType readObjectType() {
        final int start = this.index();
        this.advance();

        while (this.available() && this.peek() != ';') {
            this.advance();
        }

        if (this.peek() != ';') throw new IllegalStateException("Incomplete descriptor provided!");
        this.advance();

        return new ObjectType(this.substring(start + 1, this.index() - 1));
    }

There is no validation that the first character is L - therefore any character could be in its place. This is not a problem with readType() or readFieldType() as they will only pass onto readObjectType() in the circumstance that the check that needs be introduced here is done.

• An exception should be thrown when calling readObjectType() with the input Cjava/lang/String;