c3-tko / smash-api Goto Github PK

Swagger

• Team 2 Player
• Game 2 Team
• Game 2 Round

Unit Test

• Team 2 Player
• Game 2 Team
• Game 2 Round

Controller

• Team 2 Player
• Game 2 Team
• Game 2 Round

@see: http://williamdurand.fr/2014/02/14/please-do-not-patch-like-an-idiot/

If PATCH method routes will be implemented, they should implement RFC6902

• Unit test
• Repository updated

• Unit test
• Repository updated

• Reference for pagination parameters
• Reference for pagination responses

Currently 400 is not providing a detail property

400:
description: Bad Request
schema:
type: object
properties:
status:
type: integer
type:
type: string
title:
type: string

Whereas the other 4xx error have the detail property defined

Check if it is possible to combine all 4xx responses into one definition

• Update swagger.yaml 7e77aad
• Implement TeamControllerTest - PUT fe3731c
• Implement TeamController - PUT b757192
• Populate all new teams when a player is created -> Update PlayerController 57730a4

https://knpuniversity.com/screencast/symfony-rest4/jwt-other-things

@see https://tools.ietf.org/html/draft-ietf-appsawg-http-problem-00#section-3.1

• Deploy to server
• Backup Database
• Create api documentation from spec

Sawgger Spec

• POST 0481778
• GET 0481778
• GET/{$id} f9d9ead
• PUT/{$id} f9d9ead
• DELETE/{$id} f9d9ead

Unit Test

• POST acc6fb9
• GET 4c9b6fb
• GET/{$id} 03b97b1
• PUT/{$id} cfdf520
• DELETE/{$id} 8235dfa

Controller

• POST acc6fb9
• GET ff2bb8d
• GET/{$id} fa19f45
• PUT/{$id} 692d857
• DELETE/{$id} ed9197e

rounds table

• MySQL Schema
• ORM
• Entity
• Repository

games table

• MySQL Schema
• ORM
• Entity
• Repository

Foreign keys are a pain the ass with doctrine and the form types

• Remove foreign keys from team table
• Remove orm annotation for fk constraint in team entity
• Consider the removal of the brutal purge amendment

Consider a base class for the three update form type classes

Swagger Spec

• Model cf83ca1
• POST 3fa5a38
• GET 892c5ac
• GET/{$id} 892c5ac
• PUT/{$id} 892c5ac
• DELETE/{$id} 892c5ac

Unit Test

• POST 1548f37
• GET f518bb6
• GET/{$id} c61b367
• PUT/{$id} 82bd662
• DELETE/{$id} 39cb89e

Controller

• POST 1ee3d07
• GET 623d298
• GET/{$id} 86f8dd5
• PUT/{$id} 078890e
• DELETE/{$id} 0b4c46a

https://knpuniversity.com/screencast/symfony-rest4/jwt-other-things

Sawgger Spec

• GET
• GET/{$id}

Unit Test

• GET
• GET/{$id}

Controller

• GET
• GET/{$id}