c2fo / comb Goto Github PK

Hi Douglas,

I've just been playing around with patio, which looks like it could fit my requirements very well. Great work.

When trying out the code from http://pollenware.github.com/patio/ I though ran into the TypeError
TypeError: Object # has no method 'executeInOrder'

Then I noticed that you did quite a bit of refactoring, such as renaming http://pollenware.github.com/comb/symbols/comb.html#.executeInOrder

I generated the docs for myself now, but I thought I let you know. Keeping the documentation up to date always slips... ;-)

BTW, it seems that there is an active development for JSDoc 3 going on at https://github.com/jsdoc3/jsdoc

Regards,
Carsten

Hello!

I updated my comb version to 0.2.0, but now the logger that I used in my application fails, because it is using the new function that was added in node 0.8.14: process.getgid().
I can upgrade my node.js, but just for your information, I think it is better to gracefully fallback to an mpty string instead of failing the process:

    getLogEvent: function getLogEvent(level, message) {
        return {
            hostname: os.hostname(),
            pid: process.pid,
            gid: (process.getgid) ? process.getgid() : "",
            processTitle: process.title,
            level: level,
            levelName: level.name,
            message: message,
            timeStamp: new Date(),
            name: this.fullName
        };
    },

Thank you,
dearwish

Hey there!

I'd like to report a security issue but cannot find contact instructions on your repository.

If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.

Thank you for your consideration, and I look forward to hearing from you!

(cc @huntr-helper)

This is not so much an issue than a feature request.

It would be fantastic for comb to have a syslog appender!

Comb will not install on the Windows version of Node due to a dependency on node-proxy. Node-proxy is built after install and this fails on Windows.

'make' is not recognized as an internal or external command,
operable program or batch file.

Line 1 in lib/define.js requires profiler module. It looks like this line should be changed, and profiler dependency removed.

I installed via NPM and I got errors like below. Looks like the requires './Appender' './Level' etc need to be lowercase i.e. './appender'.

Error: Cannot find module './Appender'
at Function._resolveFilename (module.js:320:11)
at Function._load (module.js:266:25)
at require (module.js:348:19)
at Object. (/blyve/opt/node-v0.4.5/lib/node_modules/comb/lib/logging/appenders/consoleAppender.js:1:220)

Hello, I'm newbie in Comb and I have the following problem with PromiseLists. I follow the documentation for PromiseLists and create following code:

var comb = require('comb');
    fs = require('fs');

function readFiles(){
	var files = comb.argsToArray(arguments).map(function(file){
		return fs.readFile(file);
	});
	return new comb.PromiseList(files, true).promise();
	
}

readFiles("1.txt", "2.txt", "3.txt").then(function(files){
	files.forEach(function(data){
		console.log(data);
	});
}, errorHandler);

When I run it, I got error:

/opt/dbtest/test2/node_modules/comb/lib/promise.js:529
            promise.then(
                   ^

TypeError: Cannot read property 'then' of undefined
    at wrapper.__addPromise (/opt/dbtest/test2/node_modules/comb/lib/promise.js:529:20)
    at forEach (/opt/dbtest/test2/node_modules/comb/lib/base/array.js:191:18)
    at wrapper.constructor (/opt/dbtest/test2/node_modules/comb/lib/promise.js:515:17)
    at spreadArgs (/opt/dbtest/test2/node_modules/comb/lib/base/functions.js:30:17)
    at new wrapper (/opt/dbtest/test2/node_modules/comb/lib/define.js:77:19)
    at spreadArgs (/opt/dbtest/test2/node_modules/comb/lib/base/functions.js:30:17)
    at wrapper.defineConstructor (/opt/dbtest/test2/node_modules/comb/lib/define.js:329:9)
    at readFiles (/opt/dbtest/test2/app.js:10:9)
    at Object.<anonymous> (/opt/dbtest/test2/app.js:14:1)
    at Module._compile (module.js:570:32)

I'm running it on Node 6.10.2, the version of Comb is 1.0.1

Thanks,
Stoyan