c-x1 / pyflashaero Goto Github PK

https://github.com/cyborg-x1/PyFlashAero/blob/master/src/FlashAir/card.py#L47 code when ran against the example date value from https://www.flashair-developers.com/en/documents/api/commandcgi/ (17071) creates an invalid value - (2013, 21, 15)

It looks to me that month value is taken too wide - 0x1F = 5 bits and not 4 bits like in the documentation.

(((date&(0x3F<<9))>>9)+1980,((date&(0x0F<<5))>>5),date&(0x1F)) parses the date to a more reasonable (2013, 5, 15)

Packaging the software requires a version number. If you consider the software somewhat usable (I do), please add one, and preferably also git tag the releases.

In #3, I removed the strict import of Qt, which breaks it for OS X (it's rather inconvenient getting the required Qt version running there). Following my tests importing only when using the GUI worked fine; did that break anything or was there a special reason to always import the library again?

My coding skills is very low but i dident get your script to work, all i got was a "ERROR Opcode 100 not supported in firmware!". I located this error to line 145 in card.py where it checks for firmware version, i have version 2.00.02 and "self" is "1.00.03" somehow the script thinks my is lower than "self" and exits.

I disabled the return(-1,'') afterwards and it then worked fine.

Nice script, thank you! (also featurure request, a "download all" would be nice!)

I want to propose to put PyFlashAero under some free/open source license. Read the GitHub page on open source licensing for more thoughts on this.

I'd love to do some minor tweaks and package it on homebrew (an OS X package manager), but especially the latter requires a proper license.

As this is a rather simple and small project, but might be useful as a library, I'd propose MIT/BSD or LGPL. choosealicense.com might help you in selecting a license.

Loading new images stops at midnight, new pictures will not be recognized any more. No error messages, just stops working. Works again after cancelling and restarting the script.

I haven't done further analysis yet whether the local or remote (camera) time counts and what the problem is.

How to reproduce:

• Start picture polling
• Wait for midnight
• Pictures will not be transmitted any more