Giter Club home page Giter Club logo

markdown-it-github-alert's People

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

markdown-it-github-alert's Issues

Suggestion: empty line maybe shouldn't stop the rendering

Thank You

First thing first, fantastic idea to allow this GitHub behaviour in VS Code too (infact I thought it was odd vscode-github-markdown-preview wasn't allowing it yet (as I found out in your PR too).

Before having your extension running on my Code I had to write it with an extra empty line in order to avoid this mess

blockquote-note not rendered by vs code


My Issue

Now that I have it installed, a minor problem arised (and I bet it's just for me)

Here is what bugs me: my friendly empty line now stops the rendering

empty line not helping in rendering blockquote-note as in GitHub

Works fine without an empty line

correctly rendered blockquote-note

My Suggestion

It might be useful to allows that empty line to still be rendered as in GitHub
e.g.:

> [!NOTE]  
>
> This Works In Here

Note

This Works In Here

Suggestion - Add an option to change the icon colors

Hello, I'm using your plugin and it seems pretty cool so far, but i had an issue:
Due to how your plugin works, the icon of the alerts always seems to be black and it doesn't really fit my page:
image

I wanted to ask if you could add a way to easily modify the icon's colors by maybe adding a config passable to the plugin via the use function of markdown-it (i think it's doable since you're using svgs)
A little example from matkdown-it-anchor in case you didn't get my explanation:

markdownIt({ html: true }).use(
    markdownItAnchor,
    {
      permalink: true,
      permalinkClass: 'anchor',
      permalinkSymbol: '#'
    }
  )

I also noticed that not all warnings from GitHub are present in your lib, github currently supports

Note

Notes (supported by your plugin)

Tip

Tip (unsupported)

Important

Important (supported)

Warning

Warning (supported)

Caution

Caution (unsupported)

version issue in 1.79.2

Hi!

Thank U for make this editor

1. ๐Ÿค” version issue

i use in 42seoul mac but there are not update version of vscode
so i can't use it.. can U support low version?

image

2. ๐Ÿค” white space check

Note

space check!

it need to be perfectly clean next side of alert
it little bit not comfortable

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.