Post.find("invalid_id") returns invalid Post about buttercms-ruby HOT 2 CLOSED

@gaffneyc Thanks for raising this. The current behavior is definitely not ideal. Do you think an exception is the preferred way to control flow versus, for example, the find method returning nil if the post isn't found?

Also see jnunemaker/httparty#320

from buttercms-ruby.

@rogerjin12 honestly it depends on the context, in this case I knew that find would raise an error and we could rescue from it in our controllers. That said, I'm actually partial to how ActiveRecord does find_by which returns nil when the record does not exist and find_by! which raises an exception.

I've started on a pull request that I'll be pushing here shortly that raises an exception (ButterCMS::NotFound) and switches to net/http. It might be a good start to the discussion.

from buttercms-ruby.