ButterCMS::Post.find does not work correctly when slug includes a `#` character about buttercms-ruby HOT 5 CLOSED

Thanks @dabrorius ! You're right, that should return a NotFound. @hcatlin any suggestion on how to deal with # or other invalid characters passed in as the slug?

That said - # is not a valid character in post slugs so could you strip them out on your end before calling the API in the short term?

from buttercms-ruby.

@jakelumetta is there an official list of slug format rules? Like a regexp?

@dabrorius yeah, this was us at @veuelive trying to help get rid of deprecation warnings that would break this in Ruby 3.0! Was this just kind of strange data making it in or did you all use "#" named slugs with the encoding as a feature? Is the 404 important to your logic, or is rejecting it via a format error more in-line with your needs?

from buttercms-ruby.

@hcatlin typical slugification rules: should be lowercase alphanumeric and also supports dashes

My Favorite #Post -> my-favorite-post

from buttercms-ruby.

Thanks for the reply! We don't use # in the slugs, however what we did was pass the param containing the slug from our Rails route directly to the ButterCMS API and relied on catching the ButterCMS::NotFound error to handle invalid slugs.

After an unrelated issue on our side, some users ended up accessing invalid routes that included # in the slug and that's how we caught this error. We can do the sanitation of slugs on our side but I wanted to share the issue with your team.

from buttercms-ruby.

Thanks @dabrorius ! Going to close this issue for now but thanks for the heads up. We may consider adding more cleaning logic to the SDK in the future.

from buttercms-ruby.