busterc / assert-dotenv Goto Github PK

fs.exists is considered an antipattern and is documented as a potential deprecation in the documentation. It seems like it should be possible to just do the read and handle the error appropriately.

I personally find that a bit funky although it likely makes sense in this particular use case.

The client code would be a lot cleaner if this could be done synchronously rather that async as there would be no need for a callback. There are also cases where different runners (e.g., gulp, mocha) seem to expect things to be run immediately and they register nextTick handlers to process their stuff. This doesn't work with the async callback.

It should be possible to switch this to a synchronous API using the fs.*Sync calls. find-parent-dir also offers a synchronous API that can be used.

The expected result of this would be changing this:

require('assert-dotenv')({}, function() {
  // some code
});

into this:

require('assert-dotenv')({});
// some code