Inline flag (?x) with comment doesn't work due to automatic wrapping of patterns inside non-capturing group about ripgrep HOT 1 OPEN

There's really no way to get this completely right without individually validating each regex. I very specifically wanted to avoid doing that because of the extra cost it would add. With that said, now that I'm thinking about it more, it might be possible to do that with a fast path that skips the check in most cases. (For example, if a pattern doesn't contain a meta character anywhere, then you know it's valid. That would help when searching large dictionaries of literals.)

But yeah, when I added a fix for #2480, I knew it wouldn't work in all cases. Another example of this is rg ')('. That should be invalid, but it actually works.

With that said, one thing I realized here is that by adding the group around the regex, that group (which the user did not type) now appears in error messages. That's bad juju and I'll need to revert that for that reason alone. When I do that, I'll look into validating each pattern manually.

For PCRE2, we'll probably just need to accept a wontfix bug there. I don't see a good reason to completely disable multi-pattern matching there just for this reason.

from ripgrep.