bunnycinnamon / offhandcombat Goto Github PK

Hello, this is my first time using Github so I hope this is the correct way to ask.
Is there a solution to the off-hand attacks being so rapid? there is no cooldown between hits on the off-hand, making it OP unlike the primary hand which has a wait time in-between hits. This issue allows me to quickly knockback and kill enemies. People said download Better Hurt Timer but all that does is make your primary hand the same way as your off-hand, OP. this mod is perfect but that is literally the only issue. Thank you :)

This issue was already submitted and closed, but the problem still remains in 0.0.2.

There is a problem that if you equip a weapon in your left hand,
it will attack opponents you can interact with by right-clicking.
When trading with villagers or trying to feed pets,
you must disarm the weapon in your left hand.

So, if player is holding something other than a tool or weapon in right hand,
I would like it to work as an interaction priority.

Minecraft v1.15.2
Forge v31.2.45
Offhand Combat v1.0.0.0

I got a crash immediately after launch with Mixin.
Crash Report

https://drive.google.com/file/d/1WXhMJm-JKom9Tu9f_PmpNK1oyrf237xC/view?usp=sharing
↑ mainhand → offhand (normal)

https://drive.google.com/file/d/1x6LK1wnyQMbMHMtB0kAgnEKAu8eWJeFo/view?usp=sharing
↑ offhand → mainhand (problems)

https://drive.google.com/file/d/1U4A1WWgpDJh9FX86PfOpZJwXro43gz2R/view?usp=sharing
↑ hand tremor

If you attack with your mainhand after attacking with your offhand,
even if the cooldown is complete, you will not receive perfect attack power.

If you use both hands too quickly, the last one used will tremble.

There is a problem when this Mod is in the environment of 1.16.5 and
https://www.curseforge.com/minecraft/mc-mods/enhanced-armaments-reload
https://www.curseforge.com/minecraft/mc-mods/gokistats
When these two Mods are installed together, any item held by the player's right hand in the game will cause the equipment quality damage bonus, skill effect and skill damage bonus provided by these two Mods to be invalid. The left hand must be emptied, exited and re entered to recover. This bug affects the game experience. Do you know what solution is available?

Not sure if it is related to the other issue, but here is my crash report.
@BunnyCinnamon

crash-2021-07-19_11.51.16-client.txt

Minecraft: 1.18.2
Forge: 40.1.80
OffHandCombat: 0.0.4

Every time I load up my game OffHandCombat's mixins aren't specifying their minVersion property at the beginning of every gaming session and I do believe that this issue has been going on for a while now but I've never really bothered to get this resolved till now when the author of Rubidium that I've made a crash report for had mentioned OffHandCombat that's potentially causing problems which I would like to get all of these issues resolved since sometimes the game crashes randomly which the game says and sometimes screams Rubidium's name in the logs and crash reports when the game crashes at random from Rubidium.

To be honest there's nothing that can possibly be done to fix whats going on with Rubidium since it's a forge port of the fabric mod Sodium which apparently Sodium's code was written poorly which means that Rubidium's code is also written poorly since again Rubidium is a forge port of Sodium so I and many other people who've experienced the random crashes with Rubidium will just have to suck it up or stop playing with Rubidium.

Anyways, the mixins in the mod that aren't working correctly on start up are; offhandcombat-common.mixins.json and offhandcombat.mixins.json, so could you fix them to specify their minVersion property for 1.18.2 as well as 1.19.2?

Yeah, the two mods Better Combat and OffHandcombat load up fine.
The issue is that when I actually use it the framerate always drops.

I like both mods, is there a way to make them work together?

Suggest adding the ability to use tools with offhand. For example, if i have in offhand a hoe, this feature allows me to use the hoe in various modes so that i can break blocks with it and use it for plowing.

Hi. Remember me from my last two issue reports? Well I'm here to report yet another issue regarding datapacks with your mod and why I'm reporting this about it's datapack(s) is cause I'm sick and tired of losing my worlds due to incomplete or missing data within the datapacks or outdated datapacks of some of the mods that I'm playing with which at some point I lose the world that I would be playing on and how I know this is cause when making a new world you can apply datapacks except for datapacks that mods adds, when I look in there I see some red ones that when I hover my mouse over them they say "Incompatible, made for an older version of Minecraft." When I would try to load into a modded world I get a message that says that the selected datapacks have errors and asks me to either enter safe mode (which I can't enter safe mode) or go to title screen and in the message it says that I can manually fix them which Idk how to fix incomplete, missing, outdated, or even broken datapacks to mods that has these errors....

Using latest version. -> (v3.2.0.3)
Using Forge version. -> (36.0.42)
Using Mixing Bootstrap version. -> v1.0.5

crash-2021-03-05_15.15.43-client.txt
latest.log Line 51.

instantly crashes when you place a sword in the off hand

When I died by a group of zombies my screen instantly went like this in the screenshot above and I had to go into spectator mode and use what Gravestone mod provided me to make it back to my grave while the screen was still white but before I decided to go into spectator mode I latterly tried to go back to where I died without being able to see exept for using my minimap to see where I was going... When I gotten my stuff in spectator mode I had to go back to survival mode (since graves in creative can be destroyed and everything in the grave will be deleted) and blindly break my grave since the screen was still white and all I had for me to see was my minimap... before I went on my blinded white trip back to where I died to retrieve my items I tried to fix the issue by leaving the world and rejoining it and nothing worked so after I tpped back home using the minimap mod's tp I left the world and took out the mod to see if this mod was causing the issue and when I returned onto my world I'm able to see again but now I can't use this mod again till this issue gets fixed.... But at least I was able to dual wield my weapons before this issue happened when I died by a group of zombies in an abandoned mineshaft... I hope this comment ain't too much to read and I was trying to upload the screenshot in the comment section of this mod on curseforge but I wasn't able too...

UPDATE; It happened again but without this mod installed.... Now Idk what's going on with my modded minecraft cause every one to two deaths my screen whites out....

FINAL UPDATE; I think that the cause of the problem was that I made my modded world when forge was at 35.0.1 that my launcher (Tlauncher) is using and I manually installed the latest version of forge that possibly bugged out the world that every time I died or every few times that I died that the screen would get whiteout... How I know this is cause I made a test world and /kill @s or /kill Coraline77447 over 20 times, 8 times without the three mods that I took out of my mods folder then I reinstalled one of the three mods that I thought was causing this problem and then /kill Coraline77447 10 times, then again after I reinstalled the third mod, after all of that while on the test world and still didn't got white screened so then I went back onto the world that I played on and after I /kill Coraline77447 3 times I gotten white screened which told me that the world got bugged by possibly updating forge manually from 35.0.1 to the latest version of forge... Which lead me to delete the world... So I would like to apologize for reporting a false report for an issue that was solved by just making a new world and making you waste your time reading this
<:((

So you can just ignore this entire thing altogether and again I'm sorry for reporting a false report on an issue that was solved by just making a new modded survival world (even though I didn't make a new modded survival world yet) and wasting your time reading all of this................. <:((

the left hand melee weapons seem to be taking the player's block reach, instead of entity reach. i tested with pehkui mod by increasing specifically the block reach, the left hand melee was increased. i tested without pehkui to make sure it wasn't causing a problem, but i still have more reach with the left hand weapon.

Below, both weapons are in reach, as indicated:

Stepping back 2-3 blocks, the left hand still can reach:

off-hand-combat-0.0.0-forge and architectury-3.6.16
When lauching the game with these mods, it turns back to the launcher giving error 0, the loading window doesn't even appear.

Forge Version:

• 36.2.2

Mod Version:

• 3.2.0.3

Crash Reports/Logs:

off-hand-combat-0.0.1-forge and architectury-3.6.17
All the hand animations in first person, like attacking, placing a block or breaking a block, look choppy and not fliud.

I cannot figure out what the issue is, but for some reason it crashes on launch. It's the kind of crash where it says "unexpected issue has occurred" but doesn't actually save any crash reports. I have the latest version of mixinbootstrap, the latest version of the mod, and it says on the issues page that a similar issue with optifine was solved.

I have a long list of mods installed so any known incompatibilites would be good to bring up first

It's kind of annoying that you have to switch your food to your off hand and your off hand weapon to your main hand when trying to eat while dual wielding. I think it would be really useful if you could eat while a weapon is in your off hand. This is the only problem I found about this mod.

so i have off hand combat in my modpack and it worked without issues but when i added armor hotswap it started crashing after i removed off hand combat it started working well again

if i have both off hand combat and armor hotswap the game won't load because it crashes
but i have one of them or none it works fine
i don't know if its a problem on the end of off hand combat or armor hotswap but i want to use both in my modpack
(my modpack is on forge 1.16.5 i tried starting the game with and without mixinboostrap, i am using the latest vesion of off hand combat)

It ran perfectly fine up until I tried to join the server. Then it started posting this error over and over again in the logs:

[22:53:14] [Netty Epoll Server IO #0/FATAL]: java.lang.NoClassDefFoundError: Could not initialize class net.minecraft.network.ConnectionProtocol
[22:53:14] [Netty Epoll Server IO #0/WARN]: An exception 'java.lang.NoClassDefFoundError: Could not initialize class net.minecraft.network.ConnectionProtocol' [enable DEBUG level for full stacktrace] was thrown by a user handler's exceptionCaught() method while handling the following exception:
io.netty.handler.codec.DecoderException: java.lang.NullPointerException: Cannot invoke "net.minecraft.network.ConnectionProtocol.m_178321_(net.minecraft.network.protocol.PacketFlow, int, net.minecraft.network.FriendlyByteBuf)" because the return value of "io.netty.util.Attribute.get()" is null
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:477) ~[netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276) ~[netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:324) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:311) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:432) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at net.minecraft.server.network.LegacyQueryHandler.channelRead(LegacyQueryHandler.java:94) [server-1.18.1-20211210.034407-srg.jar%23292!/:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) [netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.network.ConnectionProtocol.m_178321_(net.minecraft.network.protocol.PacketFlow, int, net.minecraft.network.FriendlyByteBuf)" because the return value of "io.netty.util.Attribute.get()" is null
at net.minecraft.network.PacketDecoder.decode(PacketDecoder.java:36) ~[server-1.18.1-20211210.034407-srg.jar%23292!/:?]
at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:507) ~[netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:446) ~[netty-all-4.1.68.Final.jar%2332!/:4.1.68.Final]
... 29 more

please publish 1.12 version,thank you

Hi! I've recently discovered this mod which is like a 1.12.2 mod called Better Combat: Rebirth and apon loading into my saved world called Nina North the game crashes with this mod. Here's both the crash report and the log:

Crash report: https://pastebin.com/AgG13LKR

Log: 2020-11-06-2.log.gz

Edit and disclaimer: Mixin was already booted before the crash happened when trying to load onto a saved world so there's no need for Mixin Bootstrap and if I were to try to make a new world the game would've crashed still due to this issue that's within this mod.

For some reason, only version 0.0.0 is being shown in the CurseForge Launcher. When I manually install the 0.0.1 update, it shows an error icon saying it isn't supported. The 0.0.1 version also requires the Architectury API for some reason now.

Another issue I have noticed, when holding down the RIGHT CLICK button, the sword continuously swings really fast. It is somewhat game-breaking.

Also, when holding a sword in the off-hand in creative mode and attempting to interact/place blocks, nothing works.

I love this mod a lot, but I am going to wait for the bugs to be fixed before I add it to the Fabric Version of my Modpack. I will do further testing with the Forge Version later!