buildthomas / mockdatastoreservice Goto Github PK

I want to get MockDataStoreService working so I can test DataStore2 (and possibly push this upstream into Lemur as the default DataStoreService implementation), I'll try and add as much as necessary until my local copy stops erroring, then push upstream.

Issues that need figuring out:

LPGhatguy/lemur#115

UpdateAsync only yields if the transform function returns nil which isn't accurate behavior.

• MockDataStoreService
• MockGlobalDataStore
• MockOrderedDataStore
• MockDataStorePages
• MockDataStoreUtils (all utility functions go here)
• MockDataStoreConstants (all constants go here)

Might require an extra class that acts as the master of all data/interfaces and that MockDataStoreService/MockGlobalDataStore/MockOrderedDataStore accesses this instead of owning the data itself, otherwise it requires adding extra methods to these classes which would clash with the design principle of sticking to the Roblox API.

Have an option to have every transaction of MockDataStoreService be logged in some shape or form.

Right now it clashes with the purpose of the module, because ImportFromJSON/ExportToJSON are not part of the default Roblox API for datastores.

My code:

local MockDataStoreService = require(script.DataStoreService)

local ods = MockDataStoreService:GetOrderedDataStore("myDataStore")
print(ods:ExportToJSON())

Yes, the myDataStore OrderedDataStore does actually have keys in it. But this code just prints []

• MockDataStore has a lot of sub modules and it is annoying to copy everything multiple times initially and upon updates.
  creating a Release or Downloadable Source file would improve user experience greatly (not everyone uses Rojo)

With this recent update to the datastoreservice, I believe the mockdatastoreservice should reflect this change and remove the write lock.

Currently, as of v1.0.2, 37 tests are failing on the master branch.

To reproduce, simply checkout this repository @ the tag v1.0.2, generate a place file from place.project.json, and run the tests:

This was mentioned in #23.

MockDataStoreService should support Wally

I refer to a :UpdateAsync request which tries to write to the DataStore, not when it returns nil.

I don't know about other requests / scenarios.

So when I was testing it a while back I noticed :UpdateAsync calls are unrealistically fast.

In my testing, yield times for a simple table with some small contents when using actual datastores is something like this:

• On Studio: 1.5 - 3.0 seconds;
• In-Game: .3 - .8 seconds:

But when I used this module it took WAYY less than that, something like .02 seconds or close.

This might be what this person referenced here:

#18

But I'm not sure.