bugsduggan / pybot Goto Github PK

Traceback (most recent call last):
  File "./run.py", line 7, in <module>
    pybot.run(sys.argv[1:])
  File "/Users/sambuca/pybot/pybot/__init__.py", line 292, in run
    pybot.connect()
  File "/Users/sambuca/pybot/pybot/__init__.py", line 149, in connect
    self.socket.connect((self.server, self.port))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 224, in meth
    return getattr(self._sock,name)(*args)

Issue highlighted when argparse parses everything as strings, and sockets only accepts integers

If I rename it to something like foobar it works, just not when it's called commands

Issue created by pybot's git plugin by bugsduggan in #lolhax

Because of the way object-based decorators work, setting a context for a command in the command decorator will cause bad times.

@command(context=CONTEXT_QUERY) should be totally legal happy times syntax but in order to make this happen, command's __init__ method would not be able to take in the function, which would have to be taken at call time. That means that we loose all the shiny logging goodness and commands like commands become insane to implement.

Issue created by pybot's git plugin by bugsduggan in #69

Some of the builtin plugin's commands should only be executed by trusted users. I think there should also be a new decorator admin_command to handle the check for privs.

Commands such as .join will cause badness due to it not including the channel to join (the message argument will be empty). This should be reported to the caller.

Issue created by pybot's git plugin by bugsduggan in #lolhax

Issue created by pybot's git plugin by bugsduggan in #lolhax