bugbuster1701 / contao-visitors-bundle Goto Github PK

https://github.com/contao/core-bundle/blob/master/UPGRADE.md#php-entry-points

• Contao3-Ninja/visitors#226 Suchmaschinenschlüsselwörter bei Yandex
• Contao3-Ninja/visitors#227 Statistik, select onchange entfernen #41

• aus DCA
• aus Sprachdateien
• aus der Insert-Tag Logik

i've tried to install contao-visitors-bundle in my contao 4.4.18 fresh installation
it failed, see screenshot
it seems installed but no database update are available in install tool and module is not in contao backend
now i removed, also the uninstall process was killed
thanks

-------------------------------------------- installation --------------------------------------------

-------------------------------------------- seems installed --------------------------------------------

-------------------------------------------- uninstall --------------------------------------------

ALTER TABLE tl_visitors_category CHANGE visitors_cache_mode visitors_cache_mode TINYINT(1) DEFAULT '1' NOT NULL

Wird immer wieder vorgelegt zum Update

Siehe Contao3-Ninja/visitors#224

Ist eigentlich in dieser Version noch wichtiger, da ja der 3er Zweig wegfallen wird.
Danke 😀

• INSTALLATION_DE.md
• INSTALLATION_EN.md

https://github.com/BugBuster1701/contao-visitors-bundle/blob/master/src/Resources/contao/classes/ModuleVisitorChecks.php#L214

Ersetzen in der Art:

https://github.com/fritzmg/contao-youtube-iframe/blob/2.2.7/system/modules/youtube_iframe/dca/tl_content.php#L17-L29

require":{
"composer/semver": "^1.0",
"jean85/pretty-package-versions": "^1.0",
...
}

Allerdings dann erst ab PHP 7.0/7.1, aber das sollte ja kein Problem mehr sein.

Forum

in src/Resources/contao/classes/Encoding.php, line 161

This method has no explicit visibility which may lead to maintenability issues. You should always declare a visibility for methods and properties.

       "\xc5\xbe"     => "\x9e",
       "\xc5\xb8"     => "\x9f"
    );

  static function toUTF8($text){
  /**
   * Function \ForceUTF8\Encoding::toUTF8
   *
   * This function leaves UTF8 characters alone, while converting almost all non-UTF8 to UTF8.
   *

da gibt es noch 6 weitere Methoden die angepasst werden sollten.

Posted from SensioLabsInsight

aus der Doku: https://symfony.com/doc/current/bundles/best_practices.html

Routing

If the bundle provides routes, they must be prefixed with the bundle alias. For example, if your bundle is called AcmeBlogBundle, all its routes must be prefixed with acme_blog_.

Package phpoffice/phpexcel is abandoned, you should avoid using it. Use phpoffice/phpspreadsheet instead.

"https://de.wow.com/search?s_pt=source2&s_it=aolsem&q=contao%20template%20gratis&s_chn=4"

in ModuleVisitorSearchEngine.php

Use StringUtil::trimsplit() instead.

src/Resources/contao/classes/ModuleVisitorsTag.php:86

in src/Resources/contao/classes/Encoding.php, line 294

Method names should be declared in camelCase. You should rename this method to comply with PSR-1.

    }
    $text = self::toUTF8(static::utf8_decode($text, $option));
    return $text;
  }

  static function UTF8FixWin1252Chars($text){
    // If you received an UTF-8 string that was converted from Windows-1252 as it was ISO8859-1
    // (ignoring Windows-1252 chars from 80 to 9F) use this function to fix it.
    // See: http://en.wikipedia.org/wiki/Windows-1252

    return str_replace(array_keys(self::$brokenUtf8ToUtf8), array_values(self::$brokenUtf8ToUtf8), $text);

Posted from SensioLabsInsight

User Deprecated: Using Controller::getDatePickerString() has been deprecated and will no longer work in Contao 5.0. Specify "datepicker"=>true in your DCA file instead.

src/Resources/contao/dca/tl_visitors.php:152 {▼
    › \t'sql'    => "varchar(10) NOT NULL default ''",
    › \t'eval'   => array('maxlength'=>10, 'rgxp'=>'date', 'helpwizard'=>true, 
'datepicker'=>$this->getDatePickerString(), 'tl_class'=>'w50 wizard')
    › ),
  }

in src/Resources/contao/classes/Encoding.php, line 344

Method names should be declared in camelCase. You should rename this method to comply with PSR-1.

    $encodingLabel = self::normalizeEncoding($encodingLabel);
    if($encodingLabel == 'ISO-8859-1') return self::toLatin1($text);
    return self::toUTF8($text);
  }

  protected static function utf8_decode($text, $option)
  {
    if ($option == self::WITHOUT_ICONV || !function_exists('iconv')) {
       $o = utf8_decode(
         str_replace(array_keys(self::$utf8ToWin1252), array_values(self::$utf8ToWin1252), self::toUTF8($text))
       );

Posted from SensioLabsInsight

In contao < 4 a logged in backend user was not counted when viewing frontend preview.
This exclusion doesn't seem to work in contao 4, so that I get counted in frontend even if logged in in the backend.

Sensio Bundle durch Symfony Bundle ersetzen

User Deprecated: Using specialchars() has been deprecated and will no longer work in Contao 5.0. Use StringUtil::specialchars() instead.

src/Resources/contao/modules/ModuleVisitorStat.php:392

im neuem BE Theme wurden die limit_toggler ersetzt, das zerhackt die Ansicht derzeit, Anpassungen nötig.

in src/Resources/contao/classes/ModuleVisitorStatPageCounter.php, line 185

The next 32 lines appear in src/Resources/contao/classes/ModuleVisitorStatPageCounter.php:185, src/Resources/contao/classes/ModuleVisitorStatPageCounter.php:255 and src/Resources/contao/classes/ModuleVisitorStatPageCounter.php:326.

                                        visitors_page_lang
                                ")
                        ->limit($limit)
                        ->execute($VisitorsID, self::PAGE_TYPE_NORMAL, self::PAGE_TYPE_FORBIDDEN, $this->today);
        
        while ($objPageStatCount->next())
        {
            switch ($objPageStatCount->visitors_page_type) 
            {
            	case self::PAGE_TYPE_NORMAL :
                    $objPage = \PageModel::findWithDetails($objPageStatCount->visitors_page_id);

Posted from SensioLabsInsight

TOP 10 News Beiträge | TOP 10 FAQ Beiträge
Contao3-Ninja/visitors#223

• CSS Anpassungen noch offen
• Übersetzungen

• Contao3-Ninja/visitors#221

Hi,

Composer meldet mir:
Package phpoffice/phpexcel is abandoned, you should avoid using it. Use phpoffice/phpspreadsheet instead.

Könntest Du da anpassen?

`select onchange="this.form.submit()"
Führt bei einigen Browsern zu einer Endlosschleife von Submit Aufrufen.

• Besucher gestern
• Zugriffe gestern
• Zugriffe gesamt auf dieser Seite
• Sprach Variablen

Agent String: Dooble/0.07 (de_DE) WebKit
Bis 1.56 WebKit, ab 2.0.0 "Zero-dependency browser.", nur QT

Agent String 2.1.2: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) QtWebEngine/5.9.3 Chrome/56.0.2924.122 Safari/537.36

siehe 6138465
sonst ist die Endung doppelt.

Unter Contao 4.4.13 sind bei der Übersicht einige Elemente nicht lesbar, weil diese abgeschnitten bzw. überdeckt sind. Das Ganze wird erst sichtbar, wenn man die Statistiken mit den drei Punkten öffnet. Details in diesem Screenshot:

• #24 Insert Tags
• #25 Backend Statistik News/FAQ

Da Chrome Browser auch "Safari" als String im User Agent haben, muss Safari vor Chrome getestet werden. Safari haben kein "Chrome" als String im User Agent.

https://github.com/contao/core-bundle/blob/master/UPGRADE.md#php-entry-points

z.B.

// Old 
<form action="contao/main.php"> 

// New 
<form action="<?= $this->route('contao_backend') ?>">

"https://www.benefind.de/web.php?q=Erweiterungen_entwickeln_f%C3%BCr_Contao_leicht_gemacht.pdf"

in ModuleVisitorSearchEngine.php

das Popup umbauen. Umleitung zum eigenen Entry Point kommt öfters zur Fehlermeldung weil Login nicht erkannt wird.
So wie bei Maintenance Link oben wenn aktiviert wäre ne Idee.
Hab nur noch keine Ahnung wie das in Contao 4 geht.

Nicht zählen wenn Browser DNT übermittelt.

https://www.pixelfreu.de/blog/details/items/dnt-do-not-track.html

Ersetzen:
$GLOBALS['TL_CONFIG']['disableIpCheck']
durch
$GLOBALS['TL_CONFIG']['privacyAnonymizeIp']

und Pfade müssen angepasst werden

z.B. in DCA_Visitors.php Zeile 87

User Deprecated: Using trimsplit() has been deprecated and will no longer work in Contao 5.0. Use StringUtil::trimsplit() instead.

src/Resources/contao/classes/ModuleVisitorLog.php:59 {▶}

[ModuleVisitorsTag::replaceInsertTagsVisitors] [163] BOT: 1
[ModuleVisitorsTag::replaceInsertTagsVisitors] [164] SE : 0
[ModuleVisitorsTag::replaceInsertTagsVisitors] [170] Counted Server: True

Bot wird also erkannt 😕

"https://search.avast.com/AV772/search/web?q=contao+theme"

in ModuleVisitorSearchEngine.php

Da werden die Reader Aliase nicht gezählt?
Forum

Ursprung: 	Frontend
Details: 	BotDetection extension required for extension: Visitors!
Funktion: 	ModuleVisitorChecks checkBot

Obwohl installiert erkennt Visitors wohl nicht, das Botdetection installiert ist.
if ( !in_array( 'botdetection', \ModuleLoader::getActive() ) ) ... funktioniert wohl nicht.

sollte über composer und Angaben in composer.json auch so gefunden werden.

• autoload.php anpassen
• use Zeilen einbauen falls nötig, Code anpassen
• Botdetection Klassen Aufrufe anpassen, über use Zeilen und Klassenname

"Unable to generate a URL for the named route "visitors_frontend_screencount" as such route does not exist." hat das mit diesem Issue hier zu tun?

Originally posted by @Coding-Kiwi in #21 (comment)

in src/Resources/contao/classes/ModuleVisitorsTag.php, line 1087

The next 34 lines appear both in src/Resources/contao/classes/ModuleVisitorsTag.php:1087 and src/Resources/contao/controllers/FrontendVisitors.php:341.

	/**
	 * Get User IP
	 *
	 * @return string
	 */
	protected function visitorGetUserIP()
	{
	    $UserIP = \Environment::get('ip');
	    if (strpos($UserIP, ',') !== false) //first IP
	    {
	        $UserIP = trim( substr($UserIP, 0, strpos($UserIP, ',') ) );

Posted from SensioLabsInsight

User Deprecated: Using System::parseDate() has been deprecated and will no longer work in Contao 5.0. Use Date::parse() instead.

$this->parseDate() ersetzen