bugbuster1701 / contao-banner-bundle Goto Github PK

statt:
/bbfebanner/banclicks?bid=42 bzw. /bbfebanner/banclicks?defbid=42
dann
/bbfebanner/banclicks/bid/42 bzw. /bbfebanner/banclicks/defbid/42

in src/Resources/contao/classes/DcaBanner.php, line 250

The next 47 lines appear both in src/Resources/contao/classes/DcaBanner.php:250 and src/Resources/contao/classes/DcaBanner.php:391.

    
        if ($arrImageSize === false)
        {
            //Interne Banner Grafik
            $output = '<div class="mod_banner_be">' .
                    '<div class="name"><span style="color:red;">'.$GLOBALS['TL_LANG']['tl_banner']['tl_be_read_error'].'</span><br />'.$this->urlEncode($objFile->path).'</div>' .
                    '<div class="right">' .
                    '<div class="left">'.
                    '<div class="published_head">'.$GLOBALS['TL_LANG']['tl_banner']['banner_published'][0].'</div>'.
                    '<div class="published_data">'.($row['banner_published'] =='' ? $GLOBALS['TL_LANG']['tl_banner']['tl_be_no'] : $GLOBALS['TL_LANG']['tl_banner']['tl_be_yes']).' </div>'.
                    '</div>'.

Posted from SensioLabsInsight

• Anzeige in der Backend Statistik, app_dev.php in der Bannerziel-URL: app_dev.php/zweiteseite.html

It seems that in banner ImageSize does not work [completely]? I mean it use only main ImageSize and not Media queries.

Also, it does not use alt and title form file Meta data.

Hallo,

ich habe eine Seite inkl. Banner-Erweiterung auf Contao 4.9 upgedatet.

Installiert ist bugbuster/contao-banner-bundle in Version 1.1.0.

Auf meinem Server lief alles tutti (All-Inkl) nun auf dem Kundenserver (Hetzner) kann ich die einzelnen Banner nicht mehr bearbeiten weil ein Server-Fehler erscheint. Die Übersicht und die Vorschaubilder sind sichtbar, nur das einzelne Element lässt sich nicht bearbeiten wenn ein Bild verknüpft ist. Banner ohne Bilder gehen.

Fehler: Attempted to load class "Imagick" from namespace "BugBuster\Banner". Did you forget a "use" statement for another namespace?

Laut PHPInfo ist imagick aktiv:
imagick module enabled
imagick module version 3.4.4

Log:

[2020-03-30 12:22:02] request.INFO: Matched route "contao_backend". {"route":"contao_backend","route_parameters":{"_route":"contao_backend","_scope":"backend","_token_check":true,"_controller":"Contao\\CoreBundle\\Controller\\BackendController::mainAction"},"request_uri":"http://develop.example.com/contao?act=edit&do=banner&id=12&ref=-j9w9_DH&rt=glaT3ZcWXp2Ta-H3UjBPv6wru0z-wAd9S0-RlWLN7WE&table=tl_banner","method":"GET"} []
[2020-03-30 12:22:02] request.CRITICAL: Uncaught PHP Exception Symfony\Component\ErrorHandler\Error\ClassNotFoundError: "Attempted to load class "Imagick" from namespace "BugBuster\Banner". Did you forget a "use" statement for another namespace?" at /usr/www/users/xxx/example_2019/vendor/bugbuster/contao-banner-bundle/src/Resources/contao/classes/DcaBanner.php line 566 {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Attempted to load class \"Imagick\" from namespace \"BugBuster\\Banner\".\nDid you forget a \"use\" statement for another namespace? at /usr/www/users/xxx/example_2019/vendor/bugbuster/contao-banner-bundle/src/Resources/contao/classes/DcaBanner.php:566)"} []

Ich habe den Debug-Modus via Manager aktiviert, bekomme aber keine weiteren Details im Dev-Log zum dem Fehler. Die aktuellen Meldungen betrefen die users-json. Ich kann die Meldungen gerne posten, sehe aber keine Bezug zum Banner-Modul.

Hi,

images with "jpeg" extention cannot be used in banners.

Use StringUtil::deserialize() instead.

src/Resources/contao/classes/BannerHelper.php:185

Use StringUtil::trimsplit() instead.

z.B. Randabstände

Bei internem Banner
Bei Aufruf von \System::getContainer()->get('contao.routing.url_generator');
kommt:

ServiceNotFoundException
You have requested a non-existent service "contao.routing.url_generator". 
Did you mean this: "contao.slug.generator"?

Workaround:
config/config.yml

contao:
    prepend_locale: false

Banner anlegen und speichern. Statt der Übersicht kommt dann:
Internal Server Error
/files/bilder/09_R%C3%BCdiger-Kaminski_Feldhase.jpg does not exist
at /vendor/contao/image/src/Image.php:59

Dateiname ist "09_Rüdiger-Kaminski_Feldhase.jpg"
Contao 4.4.21

https://github.com/contao/core-bundle/blob/master/DEPRECATED.md#image-service

in src/Resources/contao/controllers/FrontendBanner.php

und dabei über create noch header setzen um Browser Caching auszuschalten.
Es führt sonst dazu das nach dem Ändern einer externen Ziel URL noch die alte aufgerufen wird.

Add to use webp images.

Normalerweise sollten die Farbe sich ändern, wenn über das Auge der Banner ausgeschaltet wird/ist.
Die css class ändert sich dabei von "published" in "unpublished".

• FrontendBanner
• BannerExternal
• BannerInternal
• BannerStatisticHelper
• BannerText
• DcaBanner

alt and title are filled from the banner definition.
alt = Banner Name
title = Banner Comment
If these values are not set there, the meta data would be possible as an alternative

• Checkbox for optional using meta data
• language files
• Migration, for default status of the field, depending on the fields "banner name" and "banner comment"
• using meta data (optional), if necessary and possible
• view status overwrite in backend banner overview
• update manual

User Deprecated: Using deserialize() has been deprecated and will no longer work in Contao 5.0. Use StringUtil::deserialize() instead.

vendor/bugbuster/contao-banner-bundle/src/Resources/contao/classes/BannerSingle.php:377 {▶}
vendor/bugbuster/contao-banner-bundle/src/Resources/contao/classes/BannerInsertTag.php:239 {▶}
vendor/bugbuster/contao-banner-bundle/src/Resources/contao/classes/BannerInsertTag.php:110 {▶}

in src/Resources/contao/modules/ModuleBannerStatistics.php, line 275

The next 22 lines appear both in src/Resources/contao/modules/ModuleBannerStatistics.php:275 and src/Resources/contao/modules/ModuleBannerStatistics.php:360.

                }
                else
                {
                    $Banner['banner_image'] = \Image::get($this->urlEncode($objFile->path), $intWidth, $intHeight,'proportional');
                }
                $arrBannersStat['banner_id'       ]   = $Banner['id'];
                $arrBannersStat['banner_style'    ]   = '';
                $arrBannersStat['banner_name'     ]   = specialchars(ampersand($Banner['banner_name']));
                $arrBannersStat['banner_alt'      ]   = specialchars(ampersand($Banner['banner_name']));
                $arrBannersStat['banner_title'    ]   = $Banner['banner_url'];
                $arrBannersStat['banner_url'      ]   = (strlen($Banner['banner_url']) <61 ? $Banner['banner_url'] : substr($Banner['banner_url'], 0, 28)."[...]".substr($Banner['banner_url'],-24,24) );

Posted from SensioLabsInsight

• See https://3v4l.org/XfAXs

in src/Resources/contao/classes/BannerExternal.php, line 90

The next 95 lines appear both in src/Resources/contao/classes/BannerExternal.php:90 and src/Resources/contao/classes/BannerInternal.php:115.

            'srcset' => \StringUtil::specialchars(ampersand($FileSrc))
        );
        $picture['alt']   = \StringUtil::specialchars(ampersand($this->objBanners->banner_name));
        $picture['title'] = \StringUtil::specialchars(ampersand($this->objBanners->banner_comment));
        
        $arrImageSize[0] = $arrImageSizenNew[0];
        $arrImageSize[1] = $arrImageSizenNew[1];
        $arrImageSize[3] = ' height="'.$arrImageSizenNew[1].'" width="'.$arrImageSizenNew[0].'"';
        
        $objReturn = new \stdClass;
        $objReturn->FileSrc = $FileSrc;

Posted from SensioLabsInsight

Use StringUtil::specialchars() instead.

When trying to link to an event page within the site as an external link you get a 404 error.

Der Pfad stimmt nicht mehr zur Zähl-PHP Datei.

Prüfen ob verwendet.
https://github.com/contao/contao/blob/master/DEPRECATED.md#session-class

https://community.contao.org/de/showthread.php?75383-Backend-gt-Zugriff-auf-Session-Daten-CURRENT-IDS&p=506831&viewfull=1#post506831

9% of all methods have more than 50 lines. This violation is raised when more than 5% methods are too long.

• 94 lines for BannerMultiple::getMultiBanner() in src/Resources/contao/classes/BannerMultiple.php, line 69
• 90 lines for BannerSingle::getSingleBanner() in src/Resources/contao/classes/BannerSingle.php, line 317
• 75 lines for BannerSingle::getSingleBannerFirst() in src/Resources/contao/classes/BannerSingle.php, line 190
• 70 lines for ModuleBannerStatistics::compile() in src/Resources/contao/modules/ModuleBannerStatistics.php, line 73
• 69 lines for ModuleBannerStatistics::addBannerIntern() in src/Resources/contao/modules/ModuleBannerStatistics.php, line 222
• 65 lines for ModuleBannerStatistics::addBannerExtern() in src/Resources/contao/modules/ModuleBannerStatistics.php, line 314
• 63 lines for DcaBanner::listBannerInternal() in [src/Resources/contao/classes/DcaBanner.php](https://github.com/BugBuster1701/contao-banner-bundle/blob/c885b25326c0e29269ea7abe922d26940a963f75/src/Resources/cont

der ist irgendwann man eliminiert worden und kommt nun in Contao 4.8.2 wieder, aber mit anderer Bedeutung.

war zu Conto 3.5 Zeiten schon als deprecated angekündigt.

Siehe #33

• Redirect releativ zu aufgerufene Route lenkt falsch um (app_dev.php/route/action/seite.html = 404
• Anzeige im Backend, app_dev.php in der Bannerziel-URL: app_dev.php/zweiteseite.html

Hello,

we're currently having a problem with the following line

which transforms

https://example.org?utm_source=something&utm_medium=something&utm_campaign=something

to

https://example.org?utm_source=something&utm_medium=something&utm_campaign=something

And this way the campaign doesn't track.

Is it okay to remove the ampersand() call?

Bye Defcon0

Füllen mit Inhalt. https://contao.ninja/contao-4-banner-bundle.html

ersetzen durch foreach()

Forum

Prefix bugbuster ändern

die Installation der Extension hat folgenden Fehler geworfen:

In FileLoader.php line 168:

[Semantical Error] The annotation "@sensio\Bundle\FrameworkExtraBundle\Conf
iguration\Route" in class BugBuster\BannerBundle\Controller\BannerFeControl
ler does not exist, or could not be auto-loaded in /www/htdocs/w0146c19/web
pages/svnrw/dev/vendor/bugbuster/contao-banner-bundle/src/Controller (which
is being imported from "/www/htdocs/xxxxx/xxxx/xxxx/dev/vendor/bug
buster/contao-banner-bundle/src/ContaoManager/../Resources/config/routing.y
ml"). Make sure annotations are installed and enabled.

In AnnotationException.php line 54:

[Semantical Error] The annotation "@sensio\Bundle\FrameworkExtraBundle\Conf
iguration\Route" in class BugBuster\BannerBundle\Controller\BannerFeControl
ler does not exist, or could not be auto-loaded.

User Deprecated: Since contao/core-bundle 4.10: Using "ampersand()" has been deprecated and will no longer work in Contao 5.0. Use "Contao\StringUtil::ampersand()" instead.

• 2x in src/Resources/contao/classes/DcaBanner.php
• src/Resources/contao/classes/BannerInternal.php:147
• src/Resources/contao/classes/BannerSingle.php:404
• src/Resources/contao/classes/BannerInsertTag.php:244
• src/Resources/contao/classes/BannerInsertTag.php:110

Prüfen ob verwendet.
https://github.com/contao/core-bundle/blob/master/DEPRECATED.md#tl_script_url-and-tl_plugins_url

in src/Resources/contao/classes/DcaBanner.php, line 210

The next 31 lines appear both in src/Resources/contao/classes/DcaBanner.php:210 and src/Resources/contao/classes/DcaBanner.php:251.

            case 1: // GIF
            case 2: // JPG
            case 3: // PNG
                $output = '<div class="mod_banner_be">' .
                        '<div class="name"><img alt="'.\StringUtil::specialchars(ampersand($row['banner_name'])).'" src="'. $banner_image .'" height="'.$intHeight.'" width="'.$intWidth.'" /></div>' .
                        '<div class="right">' .
                        '<div class="left">'.
                        '<div class="published_head">'.$GLOBALS['TL_LANG']['tl_banner']['banner_published'][0].'</div>'.
                        '<div class="published_data">'.($row['banner_published'] =='' ? $GLOBALS['TL_LANG']['tl_banner']['tl_be_no'] : $GLOBALS['TL_LANG']['tl_banner']['tl_be_yes']).' </div>'.
                        '</div>'.
                        '<div class="left">' .

Posted from SensioLabsInsight

Entweder weitere Klassen als Auswahl mit aufnehmen oder nur noch ein Schalter für alle.

Korrektur eines Strings in deutsch liegt vor.

In der Bannerübersicht und in der Statistik kommt "keine URL".
Bei Textbanner wird in der Übersicht die gesamte Zeile "Bannerziel-URL:" nicht angezeigt.
Der Link selbst funktioniert aber.

"...Als Alternative können Sie im nächsten Feld eine Zielseite auswählen."
ist hier falsch, da es dieses Feld nur bei internem Banner gibt.

None of the chained routers were able to generate route: Route 'bugbuster_banner_frontend_clicks' not found

 (1/1) RouteNotFoundException

None of the chained routers were able to generate route: Route 'bugbuster_banner_frontend_clicks' not found
in ChainRouter.php line 253

at ChainRouter->generate('bugbuster_banner_frontend_clicks', array())in Template.php line 316

at Template->route('bugbuster_banner_frontend_clicks')in mod_banner_list_dsb.html5 line 13

Forum

• Contao3-Ninja/banner#178
• Contao3-Ninja/banner#176
• Contao3-Ninja/banner#165

src/Resources/contao/classes/BannerInsertTag.php:72

User Deprecated: Using specialchars() has been deprecated and will no longer work in Contao 5.0. Use StringUtil::specialchars() instead.

Ich habe ein Logo mit dem Banner-Modul eingebunden und mit einer Bildgröße versehen.

Leider wird im Frontend die Größe nicht neu berechnet.

Der Log gibt dazu keine Informationen preis.

Contao 4.4.37
Banner: 1.0.9

Backport #37 für Contao 4.4 Variante