I think there is a bug with the pathfinding solution where it doesn't get neighbors correctly when the grid isn't square.

if (y - 1 >= 0 && !visited[y - 1][x].closed) { is up
and ln 85 if (y + 1 < visited[0].length && !visited[y + 1][x].closed) { is down. Since we move up and down ln 85 should check visited.length not visited[0].length else it can run out of bounds with non square (rectangular) grids. Conversely ln 95 should be flipped to check visited[0].length since that is left and right and the nested arrays represent Xs max size.

I'm enjoying the course. Thanks!

I do receive this error message when trying to run the tests locally.

FAIL specs/graph/graph.test.js
● extra credit

 Tests cannot be nested. Test "user 1 with 7 degrees of separation – this will traverse every user that's followed by someone else. five users are unfollowed" cannot run because it is nested within "extra credit".

  73 |
  74 | test("extra credit", function () {
> 75 |   test("user 1 with 7 degrees of separation – this will traverse every user that's followed by someone else. five users are unfollowed", () => {
     |   ^
  76 |     expect(findMostCommonTitle(1, 7)).toBe("Geological Engineer");
  77 |   });
  78 | });

  at Env.it (node_modules/jest-jasmine2/build/jasmine/Env.js:605:19)
  at Object.<anonymous> (specs/graph/graph.test.js:75:3)`

I had to change the outer test to describe

I saw multiple pull requests to fix this so I'm opening an issue to see it solution will get merged.

#23
#13
#9

Bug report

Node Version

12.18.3

Environment

Linux and Windows PC

Current behaviour

I'm trying to run the code locally and there seems to be a build failure when I run npm run start (this is after I did an npm install):

🚨 Build failed.
@parcel/transformer-babel: babelCore(...).loadPartialConfigAsync is not a function

And the site cannot be reached.

Suggested solution

Digging into this it looks like it is something missing in babel core which is currently using version 7.2.0. So I tired bumping the babel version to 7.14.0 and the problem went away. I can do a pull request if that helps.

Hi
I think the version of the viewer in codesanbox is not working. I compared the version in this repository with the version in Codesanbox and some files are missing.

I tried running the files on my machine locally and they work correctly, but the Codesanbox version only prints the word Hi.

sorry if this issue doesn't go here, I didn't know where to report it.

Hey, there are a few test files which aren't structured properly - when the repo is cloned and npm run test is run there are files for which jest complains: “Tests cannot be nested”. I'll submit a PR to fix this.