btdev / berrytube Goto Github PK

When a video is queued using a manifest file, the player allows changing the video quality. Doing so disables the spacebar until the page is refreshed.

If a session that's connected to from multiple locations at once has berry, a new/refreshed connection doesn't get the information that they have berry. They do have access to the commands, but the UI doesn't show.

most likely broken in 2597fe5

Pretty much just gotta bonk the regexes for this

Briefly mentioned in #45, so this issue will only concentrate on syndicated videos, aka "playable only on youtube" videos. Youtube's Data API video endpoint doesn't include a field to indicate that video is a syndicated. However that data can be queried from search endpoint. This query is rather expensive (100 units vs 1 unit).

There's two possible options that I can see (could be more):

• Perform a query to Data API search endpoint with given video id
• Let the player fail to play the content and autoskip + remove

As per:

https://www.npmjs.com/package/youtube-info
https://github.com/philbot9/youtube-info

This is only used as a Youtube's fallback method, no idea if how often we hit this fallback

No one's an assistant anymore... don't need the counter. Not worth the effort to remove the entire concept though, so maybe make the counter show up if an assistant somehow does appear online?

Useful for events that start at a particular time, like MMM

simple implementation just supports mass-adding the items into the queue at the target time.

more complex may add a targetTime/playAfter (or whatever) properties onto the videos so that modifications to the queue use those properties to keep the block at the same target play time, but probably overkill/unnecessary?

When a video is queued with a start offset (like https://www.youtube.com/watch?v=K5SOrhK1E0Q&t=10s), the queuer should be prompted whether they want to queue from the set time or from the start of the video.

(also starting from an offset should be supported to make the above possible)

Different players handle volume differently. Some have different scales. Some have mute as a separate option. It's a clusterfuck, and often breaks when the type of player changes...

Allow flagging a video as spoilery when queuing it. A flagged video doesn't auto-play, but instead shows the video title and a play button of some sort in the player area.

Judging from the console logs, the sort happens before page is fully loaded.

Can be reproduced by refreshing and immediately selecting another tab. It's not 100% but happens often enough.

Ranked polls always reserve space for showing the in-progress results while the poll is open, even if the current user can't see those in-progress results.

When non-ranked poll is closed show the results in order from most-voted -> least-voted.

Normal obscured polls should allow the user to change their vote by clicking another option.

When a YouTube video is queued, BT uses the default title, even if a title in English is available.

Check if other video hosts support multiple titles as well.

Could this be a cookie setting expiring or what?

The user with berry might remain at the top of the list.

Example courtesy of Kris321: https://v.redd.it/8lukdvw6sti11

Probably should just allow queues by link to the thread.

Nick got kicked because You have been banned. shows but the actual ban or the mod who did it doesn't.

https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/

There was a change to accessing databases and it affects the country database used by the module.

There are too many filters to keep track of. A search box that just matches the input against all properties to reduce the list would be useful.

If the input contains no special characters, it should probably strip special characters from filter properties before matching on them.

https://i.imgur.com/04Q0KQo.png

When a mod sends a message prefixed with User: where User is a currently shadowbanned user, the mod's message should act like a message from a shadowbanned user, except it's visible to User as a normal message.

YouTube has broken embeds for age restricted videos. Handle them gracefully instead of breaking the tube player. Probably just check server-side if the video can be embedded, and abort the queue/play operation if not. Preferably show the user a message explaining why.

Check functionality both for 18+ videos and for "for kids" videos. Check functionality when a video is restricted when it's queued, and when it's not restricted when queued but becomes restricted before playing.

• Send numbers to clients when placeholders are used?
• Warn poll creator?
• Prevent creation of such polls?

The API currently used by BT will be shut down in February.

See the announcement and the migration guide.

When a (ranked?) poll option has been activated by a user, hovering over the option's button shows cursor:not-allowed, but clicking the button does seem to remove the vote (pls verify).

We should probably just make the cursor normal, and leave the functionality in.

The value chosen in the poll close timer dropdown is ignored when using the "create runoff" option.

The current theme is saved in multiple places. When a theme override is removed, users who aren't online at the time are still stuck on the overriden theme.

Seems to apply to both skipping current video, and to skipping to some volatile video.

Emotes should be copied when included in a text selection.

If the flair id is 0 it's a number, otherwise it's a string.

Somehow

Reason:
For emotes that can include user defined text, the user has to remember what the full emote syntax is, or click the emote through the emote search. This can get quite cumbersome in a long run.

So a possibility to switch between the syntaxes either through pressing tab or another key combination would be quite helpful.

From what I understand, the current playlist mechanics do not distinguish volatile from non-volatile when it comes to removal. I think it would make sense for Berry to be able to remove volatile videos, mostly for convenience (someone given berry accidentally queues the wrong video and wants to remove it, for example). Obviously we'd not want to give berry any control over perma-queued things, but why not let Berry remove volatile videos?

(let me know if it's actually problematic, I'll see what I can do to help)

Allow queuing multiple videos at a time using a whitespace separated list of URLs.

This used to work...

Maybe perhaps somehow?

Upon unbanning a user, it registers in the log as a BANNED

To allow adding special handling for common errors, like linking imgur pages instead of the image, or linking gifv "images" instead of actual images.

When a video is searched for, the result should in some way indicate when that video was last queued.

Maybe through a checkbox? Need to check how the confirmation works.