bsherman / netmaker-traefik Goto Github PK

Can a link to the official netmaker docker compose example with traefik be included in the header in the "The official netmaker docker-compose example now uses Traefik, so I'm archiving this repo" header?

It's not obvious where to find it and the Readme of the offical repo still links very prominently to this repo. I believe this might be the what is considered the official example? https://docs.netmaker.org/server-installation.html#compose-file-annotated

Remove extra $ in *.$${NM_BASE_DOMAIN}

• traefik.http.middlewares.nmui-security.headers.accessControlAllowOriginList=*.$${NM_BASE_DOMAIN}

Corrected

• traefik.http.middlewares.nmui-security.headers.accessControlAllowOriginList=*.${NM_BASE_DOMAIN}

Is this line a mistake

• traefik.http.middlewares.nmui-security.headers.accessControlAllowOriginList=*.$${NM.BASE_DOMAIN}

should it be?

• traefik.http.middlewares.nmui-security.headers.accessControlAllowOriginList=*.${NM_BASE_DOMAIN}

Hi,
I wanted to flag the following- especially in case I've done something wrong-

If you run up the supplied docker-compose.yml you'll get an error and Traefik will be unable to start
'docker.errors.InvalidArgument: "host" network_mode is incompatible with port_bindings'

Removing the port bindings in the .yml file seems to fix this-

    ports:
      - "80:80"
      - "443:443"

Please let me know if this is incorrect!